[TIMOB-27768] iOS: TypeError: Cannot read property 'logger' of undefined

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2020-04-09T15:29:40.000+0000
Affected Version/s	Release 9.0.0, Release 8.3.1
Fix Version/s	Release 9.0.1
Components	iOS
Labels	n/a
Reporter	Ewan Harris
Assignee	Samir Mohammed
Created	2020-02-14T16:50:07.000+0000
Updated	2020-04-09T15:29:40.000+0000

Description

Building a project with extensions, where one of the extensions does not contain a build phase will error with the below, easy fix to just convert to an arrow function

(node:96371) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'logger' of undefined
    at /Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/iphone/cli/commands/_build.js:3450:12
    at Array.forEach (<anonymous>)
    at iOSBuilder.<anonymous> (/Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/iphone/cli/commands/_build.js:3439:51)
    at Array.forEach (<anonymous>)
    at iOSBuilder.<anonymous> (/Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/iphone/cli/commands/_build.js:3345:26)
    at Array.forEach (<anonymous>)
    at iOSBuilder.createXcodeProject (/Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/iphone/cli/commands/_build.js:3325:19)
    at /Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/node_modules/async/dist/async.js:3880:24
    at replenish (/Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/node_modules/async/dist/async.js:1011:17)
    at iterateeCallback (/Users/awam/Library/Application Support/Titanium/mobilesdk/osx/8.3.1.GA/node_modules/async/dist/async.js:995:17)

Steps to reproduce

1. Build Hans' app

Actual

Above error

Expected

No error

Comments

Samir Mohammed 2020-02-21

PR: https://github.com/appcelerator/titanium_mobile/pull/11493
Samir Mohammed 2020-03-30

9_0_X: https://github.com/appcelerator/titanium_mobile/pull/11581
Christopher Williams 2020-03-31

merged to 9_0_X, master
Samir Mohammed 2020-04-09

*Closing ticket.* Fix verified in SDK version 9.1.0.v20200406120646. and 9.0.1.v20200408050151 Test and other information can be found at: 9_0_X: https://github.com/appcelerator/titanium_mobile/pull/11581 Master: https://github.com/appcelerator/titanium_mobile/pull/11493

JSON Source