[TIMOB-27823] Android: javascript files/content assumed to be binary for Ti.Blob on apilevel 29+
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2020-04-09T12:16:08.000+0000 |
| Affected Version/s | Release 9.0.0 |
| Fix Version/s | Release 9.0.1 |
| Components | Android |
| Labels | n/a |
| Reporter | Christopher Williams |
| Assignee | Christopher Williams |
| Created | 2020-03-25T17:31:19.000+0000 |
| Updated | 2020-04-09T12:16:08.000+0000 |
Description
This was caught by our test suite on android emulator. It seems Android changed the underlying mime type mapping result for javascript files to report
'application/javascript' (whereas before it reported 'text/javascript')
Our TiBlob code assumes most 'application/' mime types are binary, and as a result thinks JS files hold binary content.
master: https://github.com/appcelerator/titanium_mobile/pull/11568 9_0_X: https://github.com/appcelerator/titanium_mobile/pull/11569
Technically, this was not yet FR'd by QE - but given that the unit test suite caught this issue and pass with the fix (and that it's breaking builds without the fix), I merged it in anyways. The PRs have been merged to 9_0_X and master.
FR Passed, Code present in newest SDK
9.1.0.v20200406120646and9.0.1.v20200408050151and test suite now passes.