Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-28128] CLI: SDK install not preserving symlinks inside zip file

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2020-09-22T22:42:56.000+0000
Affected Version/sn/a
Fix Version/stitanium 5.2.3, appc-cli-8.1.1
ComponentsCLI
Labelsn/a
ReporterChristopher Williams
AssigneeChristopher Williams
Created2020-09-11T18:16:53.000+0000
Updated2020-09-22T22:43:07.000+0000

Description

macOS xcframework make extensive use of symlinks (mostly symlinked folders). The 3rd-party npm package we use to unzip (AdmZip) does not support symlinks and mangles the extracted symlinks in the SDK zip file. I've been able to work around this in our build scripts, but it shows up in module builds if we use the CLI to install the SDK we want to build against - and therefore will show up for end developers.

Comments

  1. Christopher Williams 2020-09-12

    PR to fix this in node-appc: https://github.com/appcelerator/node-appc/pull/283 Will need to be merged, released and rolled into titanium cli (which then would need to be released). Form what [~eharris] stated, it sounds like titaniumlib has the same issue so a fix would need to get in there?
  2. Ewan Harris 2020-09-12

    node-appc PR merged, next steps: * Update node-appc inside titanium cli * Update titanium cli inside appc-cli/appc-cli-titanium Alongside that, I will update titaniumlib and release new versions of the editors early next week
  3. Christopher Williams 2020-09-12

    titanium cli 5.2.3 contains the updated node-appc from https://github.com/appcelerator/titanium/pull/359
  4. Christopher Williams 2020-09-12

    titanium lib PR: https://github.com/appcelerator/titaniumlib/pull/27/files

JSON Source