[TIMOB-28145] iOS: Support string values with units for property values
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2021-06-23T09:34:13.000+0000 |
| Affected Version/s | Release 9.2.0 |
| Fix Version/s | Release 10.0.1 |
| Components | iOS |
| Labels | n/a |
| Reporter | Christopher Williams |
| Assignee | Gary Mathews |
| Created | 2020-09-18T17:13:03.000+0000 |
| Updated | 2021-06-23T09:34:13.000+0000 |
Description
I ran into this on the unit tests when we had image mismatches for a view with a border radius and shadow. I finally realized the issue is that the shadow's values are purely numeric, so are done in points (or dip) - so the actual pixel value will differ based on device density/scale.
For API parity, it would make sense for shadow property values to support String values that denote a unit in the same way other view properties like width/height/top/bottom do.
master: https://github.com/appcelerator/titanium_mobile/pull/12807
merged to master and 10_0_X