Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-6366] iOS: Misspelled color name in Webcolor.m

GitHub Issuen/a
TypeBug
PriorityTrivial
StatusClosed
ResolutionFixed
Resolution Date2012-07-11T23:11:33.000+0000
Affected Version/sn/a
Fix Version/sRelease 2.1.0
ComponentsiOS
Labelsapi, module_window, qe-testadded
ReporterArthur Evans
AssigneeArthur Evans
Created2011-11-29T17:03:03.000+0000
Updated2012-10-30T22:00:58.000+0000

Description

Webcolor.m contains a list of color names. Most of them are standard web colors. One of them is an iOS-specific color called "stripped." 56 [UIColor groupTableViewBackgroundColor],@"stripped", I'm pretty sure this is supposed to be "striped." If not, I recommend we rename it to "nude" to avoid confusion.

Comments

  1. Paul Dowsett 2012-04-18

    hehe :D
  2. Arthur Evans 2012-04-18

    Rather than relying on the fact that the background for group table views is striped, we could expose this as a constant somewhere--possibly add a set of system color values under UI/iOS.
  3. Blain Hamon 2012-04-18

    Agreed. Ti.UI.iOS.color constants, I suppose? There's actually quite a few metacolors (Textures and the like that are treated like colors) that we can expose, including the everpopular linen.
  4. Arthur Evans 2012-05-21

    In line with the other texture constants added recently, I propose Ti.UI.iOS.COLOR_GROUP_TABLEVIEW_BACKGROUND as a replacement for 'stripped'. I don't think there's any actual way to deprecate the 'stripped' color name unless we do an extra string comparison for every color value, which seems like a waste. **Test Case** 
       var win = Titanium.UI.createWindow({  
       title:'Mr. Stripey',
       backgroundColor: Ti.UI.iOS.COLOR_GROUP_TABLEVIEW_BACKGROUND
   });
   win.open();
    Expected results: stripey window.
  5. Max Stepanov 2012-05-22

    PR merged https://github.com/appcelerator/titanium_mobile/pull/2249
  6. Eric Merriman 2012-06-18

    Verified fixed with SDK 2.1.0.v20120618102300 on iPod 4th gen
  7. Anshu Mittal 2012-07-11

    Reopening to update labels.

JSON Source