[TIMOB-7233] Android: evalJS and evalFile methods deprecated in TiContext

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2012-03-05T09:29:58.000+0000
Affected Version/s	Release 1.8.0.1
Fix Version/s	Sprint 2012-05, Release 2.0.0
Components	Android
Labels	module_module, qe-testadded, regression
Reporter	Eduardo Gomez
Assignee	Marshall Culpepper
Created	2012-01-16T15:35:17.000+0000
Updated	2012-07-05T10:30:03.000+0000

Description

Issue

One of the General changes while porting modules to our current SDK 1.8.0.1 was remove TiContext.

Customer's remarks

Inside my Android module, I have to execute some JavaScript statements in the current context. I was using TiContext to do that in pre-1.8.0.1 versions of SDK. Since TiContext is deprecated where in 1.8.0.1 Android module SDK can I find evalJS() and evalFile() methods?

General changes

{noformat} TiContext is being replaced, and any implementation utilizing TiContext will take a performance / stability hit compared to using the desired API's directly. In most of the places where TiContext is used as an argument, the TiContext argument can be removed entirely or replaced with an Activity reference. {noformat}

evalJS and evalFile methods migrated

	public Object evalFile(String filename)
		throws IOException
	{
		return evalFile(filename, null, -1);
	}

	public Object evalJS(String src)
	{
		if (krollBridge == null)
		{
			Log.e(LCAT,"on evalJS, evaluator is null and shouldn't be");
		}
		return krollBridge.evalJS(src);
	}

References

https://wiki.appcelerator.org/display/guides/Android+Module+Porting+Guide+for+1.8.0.1

Attachments

File	Date	Size
com.arcaner.testmodule2-android-0.1.zip	2012-02-29T10:38:54.000+0000	46708

Comments

Neeraj Gupta 2012-02-10

We need to get some insight into how TiContext evalJS / evalFile are being currently used, as it makes a significant impact on the amount of time it will take us to re-introduce this functionality.

Marshall Culpepper 2012-02-29

Make sure to run this test for both V8 and Rhino: * Copy the attached module zip into a project and add this to your tiapp.xml:

   <modules>
       <module>com.arcaner.testModule2</module>
   </modules>

* Use this code inside the app:

   var test = require("com.arcaner.testModule2");
   test.evalJS("Ti.API.debug('Hello World'); 100+1");
   test.evalJSWithContext("Ti.API.debug('Hello from TiContext'); 1.1+100;");
   test.evalFileWithContext("test.js");

* In the console, you should see these messages printed when the application runs:

   D/TiAPI   ( 6489): Hello World
   D/Testmodule2Module( 6489): (KrollRuntimeThread) [100,465] Result = 101.0
   D/TiAPI   ( 6489): Hello from TiContext
   D/Testmodule2Module( 6489): (KrollRuntimeThread) [1,466] TiContext Result = 101.1
   D/TiAPI   ( 6489): Hello world from a file
   D/Testmodule2Module( 6489): (KrollRuntimeThread) [1,467] TiContext File Result = 102.0

Note: This is the java snippet that was used to expose these APIs for the module:

   	@Kroll.method
   	public void evalJS(String code) {
   		Object result = KrollRuntime.getInstance().evalString(code);
   		Log.d(LCAT, "Result = " + result);
   	}
   
   	@Kroll.method
   	public void evalJSWithContext(String code) {
   		Object result = getTiContext().evalJS(code);
   		Log.d(LCAT, "TiContext Result = " + result);
   	}
   
   	@Kroll.method
   	public void evalFileWithContext(String path) {
   		try {
   			Object result = getTiContext().evalFile(path);
   			Log.d(LCAT, "TiContext File Result = " + result);
   		} catch (Exception e) {
   			Log.e(LCAT, "Error", e);
   		}
   	}

Marshall Culpepper 2012-02-29

Pull request is ready: https://github.com/appcelerator/titanium_mobile/pull/1538
Natalie Huynh 2012-03-19

Tested with 2.0.0.v20120319003254 v8/rhino on Droid 2.2.2 and Emulator 2.3.3. Getting the correct console output

JSON Source