Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-8099] module.xcconfig file is not processed

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2012-03-20T16:37:25.000+0000
Affected Version/sRelease 2.0.0
Fix Version/sRelease 2.0.0, Sprint 2012-06
ComponentsTooling
Labelsregression
ReporterJeff English
AssigneeStephen Tramer
Created2012-03-20T08:20:01.000+0000
Updated2017-03-22T17:12:40.000+0000

Description

When attempting to build an application that uses an iPhone module with a custom module.xcconfig file, the module.xcconfig file is not processed during the build and the result is a build failure. Steps to reproduce: 1. Download Titanium SDK version 2.0.0 (06fdce0) 2. Create a new application is Titanium Studio 3. Copy the Styled Label module zip file into the project (or install in the Titanium system folder) 4. Update the tiapp.xml file to include the version of the styled label module 5. Build the application The build should fail. If you examine the module.xcconfig file in the application's build folder you will see that none of the information from the styled label's module.xcconfig file has been added. The build log will list a number of undefined symbols due to the fact that the module.xcconfig information was not included. This problem was introduced on March 9, 2012 with the change to compiler.py (commit: 7cccc3fccae5bf0cfaa4629afd17fb8f56012924). It appears that the indentation on lines 308-310 is incorrect, with the result being that none of the subsequent lines are processed. (See [TIMOB-7833])

Comments

  1. Stephen Tramer 2012-03-20

    Note that the all_load also has to be removed from the module.xcconfig in order to get the build to work properly. The forced loading of symbols during the link causes a problem; there's an existing ticket for this.
  2. Stephen Tramer 2012-03-20

    TESTING

    ----

    Run tabnanny on the support/iphone contents from your project clone and make sure that there's no output:

       titanium_mobile> python -m tabnanny support/iphone
       

    Run the scenario described as above (you will need to pull down the module, and change the titanium.xcconfig and module.xcconfig to point to the correct 2.0.0 version, and remove the all_load).

  3. Mauro Parra-Miranda 2012-03-26

    Hello Stephen, can you please share the ticket number of the forced loading? What does it mean for customers? Should they wait for a recompiled version of all paid modules? Best, Mauro
  4. Qiao Liang 2012-05-22

    Hello Stephen, can you point out the solution for this issue? It is marked as dup. But I cannot find the thread that resolve this. Regards, Qiao Liang
  5. Lee Morris 2017-03-22

    Closing ticket due to time passed.

JSON Source