{ "id": "112763", "key": "TIMOB-13543", "fields": { "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "15547", "description": "2013 Sprint 14", "name": "2013 Sprint 14", "archived": true, "released": true, "releaseDate": "2013-07-15" }, { "id": "15548", "description": "2013 Sprint 14 API", "name": "2013 Sprint 14 API", "archived": true, "released": true, "releaseDate": "2013-07-15" }, { "id": "15479", "description": "Release 3.1.2", "name": "Release 3.1.2", "archived": true, "released": true, "releaseDate": "2013-07-31" }, { "id": "14982", "description": "Release 3.2.0", "name": "Release 3.2.0", "archived": false, "released": true, "releaseDate": "2013-12-19" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2013-07-10T20:37:14.000+0000", "created": "2013-04-12T14:09:27.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "activityExitAnimation", "android", "close", "exalture", "module_window", "open", "qe-testadded", "window" ], "versions": [ { "id": "14982", "description": "Release 3.2.0", "name": "Release 3.2.0", "archived": false, "released": true, "releaseDate": "2013-12-19" } ], "issuelinks": [ { "id": "27992", "type": { "id": "10002", "name": "Duplicate", "inward": "is duplicated by", "outward": "duplicates" }, "outwardIssue": { "id": "113184", "key": "AC-3176", "fields": { "summary": "Android: Add support for custom activity close animation", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } }, { "id": "30115", "type": { "id": "10011", "name": "Includes", "inward": "is included by", "outward": "includes" }, "inwardIssue": { "id": "114033", "key": "TIMOB-13796", "fields": { "summary": "Android: Implement new window architecture", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } } ], "assignee": { "name": "bijuexalture", "key": "bijuexalture", "displayName": "Biju pm", "active": true, "timeZone": "Asia/Kolkata" }, "updated": "2013-10-23T23:15:18.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Problem*\r\nThe ability to animate enter and exit activities on opening windows is working fine, but this is only useful when you need to progress forward in an apps UI. If one wants to close windows and go backwards (hit the back button) they cannot use the animations which only work on win.open() and not on win.close(). The pull request below allows the ability to use the activityAnimations when closing a window.\r\n\r\ntest case for the pull request\r\n{code}\r\n\r\nvar win = Ti.UI.createWindow({\r\n\tbackgroundColor:'white'\r\n});\r\n\r\nvar button = Ti.UI.createButton({title:'open'});\r\nbutton.addEventListener('click', function (){\r\n\tvar win = Ti.UI.createWindow({\r\n\t\tbackgroundColor:'blue',\r\n\t\tmodal:false\r\n\t});\r\n\twin.addEventListener('android:back', function(){\r\n\t\twin.close({\r\n\t\t activityExitAnimation: Ti.Android.R.anim.slide_out_right\r\n\t\t});\r\n\t})\r\n\twin.open({\r\n\t activityEnterAnimation: Ti.Android.R.anim.fade_in,\r\n\t})\r\n\t\r\n})\r\nwin.add(button);\r\nwin.open();\r\n{code}", "attachment": [], "flagged": false, "summary": "Android: add support for activityEnterAnimation and activityExitAnimation for Window.close method", "creator": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "environment": "titanium 3.2.0 master\r\nandroid 4.1", "comment": { "comments": [ { "id": "247270", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "pull request \nhttps://github.com/appcelerator/titanium_mobile/pull/4152", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T14:14:44.000+0000", "updated": "2013-04-12T14:14:44.000+0000" }, { "id": "247306", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Martin, what version of Ti SDK are you experiencing this on?", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T18:23:32.000+0000", "updated": "2013-04-12T18:23:32.000+0000" }, { "id": "247308", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Unable to reproduce with 3.0.2GA and 3.1.xx on Android 4.1.2. Fading working as expected on both exit and entrance to new blue window. Can you please provide more details as well as steps to reproduce so that I may have better luck reproducing this issue? For reference on how to submit a bug report: \nhttps://wiki.appcelerator.org/display/guides/How+to+Submit+a+Bug+Report\nRegards,\nCarter", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T18:34:41.000+0000", "updated": "2013-04-12T18:34:41.000+0000" }, { "id": "247309", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "This feature was introduced for 3.2.0 and as mentioned in the environment this bugs is on 3.2.0 master \n\nIn fact after working on it it apperas that activityExitAnimtation doesn't do what we expect it to do. It doesn't hanfdle the closing of your window but how the current window disappear. So it s much of a new addition tu support window close\n animation", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T18:34:55.000+0000", "updated": "2013-04-12T18:34:55.000+0000" }, { "id": "247322", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "You won't be able to test this with any official release. It s not yet in. You have to build and use the master branch", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T18:54:22.000+0000", "updated": "2013-04-12T18:54:22.000+0000" }, { "id": "247341", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Martin, wasn't this implemented in 3.1? I made a mistake using 3.0.2 before, I thought it was implemented then. Regardless this is a bug due to the activityEnterAnimation working but the exit is not. \nThanks for bringing this to our attention,\nCarter", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T21:01:22.000+0000", "updated": "2013-04-12T21:01:22.000+0000" }, { "id": "247342", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Docs say 3.1: \r\nhttp://docs.appcelerator.com/titanium/3.0/#!/api/openWindowParams-property-activityExitAnimation", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T21:01:58.000+0000", "updated": "2013-04-12T21:01:58.000+0000" }, { "id": "247347", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "Yes you are right. That s it. It often misunderstood what activityExitAnimation does and I did!\r\nMy pull request add what I was expecting it to do, it adds support for animation when closing a heavyweight window\r\nI will update my test case tomorrow to ahow its full potential( alreDy using it and it s working great)", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T21:19:52.000+0000", "updated": "2013-04-12T21:19:52.000+0000" }, { "id": "247348", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "Maybe you could rename that ticket to \"support for activityEnterAnimation and activityExitAnimation for Window.close method\"", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T21:21:00.000+0000", "updated": "2013-04-12T21:21:00.000+0000" }, { "id": "247350", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "I'm pretty sure that activityEnterAnimation is working, it's just activityExitAnimation that is not triggering. Am I missing something?", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T21:26:00.000+0000", "updated": "2013-04-12T21:26:00.000+0000" }, { "id": "247351", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "Both were working. While creating that pullrequest i thought the exit one wasn't working I was expexting it to define the animation when I close my window\r\nI was wrong. My pull request adds the support for what I was missing: animation upon window close. \r\nThe two properties can be used for Aactivity.start and Activity.finish ", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T21:30:05.000+0000", "updated": "2013-04-12T21:30:05.000+0000" }, { "id": "247357", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ok, so the activityEnterAnimation is for the new window that is being opened and the activityExitAnimation is for the OLD window that is being opened over, for some reason I didn't realize this before. Now I understand your need for the close activityAnimations for when you want to return to previous windows using an animation, Ill change around the ticket description to reflect this.\n", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T21:53:26.000+0000", "updated": "2013-04-12T21:53:26.000+0000" }, { "id": "247358", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "I didn't realized that either. That's why my bug request was misleading you. Sorry", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T21:57:00.000+0000", "updated": "2013-04-12T21:57:00.000+0000" }, { "id": "247360", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ok, made the changes, feel free to add to it for clarity. I may have removed your first test code on accident, if you want to replace it, go ahead if you think it is needed.", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T21:58:09.000+0000", "updated": "2013-04-12T21:58:09.000+0000" }, { "id": "247361", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "I ll update the testcase tomorrow to show the full potential", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-12T21:59:05.000+0000", "updated": "2013-04-12T21:59:05.000+0000" }, { "id": "247362", "author": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ok, thanks again for your input and pull request. Engineering will review it asap. ", "updateAuthor": { "name": "clathrop", "key": "clathrop", "displayName": "Carter Lathrop", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-04-12T22:01:04.000+0000", "updated": "2013-04-12T22:01:04.000+0000" }, { "id": "247402", "author": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "body": "new test case showing the full power of it\r\n{code}\r\nvar win = Ti.UI.createWindow({\r\n backgroundColor:'white'\r\n});\r\n \r\nvar button = Ti.UI.createButton({title:'open'});\r\nbutton.addEventListener('click', function (){\r\n var win = Ti.UI.createWindow({\r\n backgroundColor:'blue',\r\n modal:false\r\n });\r\n win.addEventListener('android:back', function(){\r\n win.close({\r\n activityEnterAnimation: Ti.Android.R.anim.fade_in,\r\n activityExitAnimation: Ti.Android.R.anim.slide_out_right\r\n });\r\n })\r\n win.open({\r\n activityEnterAnimation: Ti.Android.R.anim.fade_in,\r\n activityExitAnimation: Ti.Android.R.anim.slide_out_right\r\n })\r\n \r\n})\r\nwin.add(button);\r\nwin.open();\r\n{code}\r\nEverything else seems fine to me. Thanks for your work", "updateAuthor": { "name": "farfromrefuge", "key": "farfromrefuge", "displayName": "Martin Guillon", "active": false, "timeZone": "Europe/Berlin" }, "created": "2013-04-13T07:04:47.000+0000", "updated": "2013-04-13T07:04:47.000+0000" }, { "id": "255138", "author": { "name": "bijuexalture", "key": "bijuexalture", "displayName": "Biju pm", "active": true, "timeZone": "Asia/Kolkata" }, "body": "add support enter animation and exit animation for window close activity\r\nhttps://github.com/appcelerator/titanium_mobile/pull/4344", "updateAuthor": { "name": "bijuexalture", "key": "bijuexalture", "displayName": "Biju pm", "active": true, "timeZone": "Asia/Kolkata" }, "created": "2013-05-31T09:49:38.000+0000", "updated": "2013-05-31T09:49:38.000+0000" }, { "id": "261319", "author": { "name": "ayeung", "key": "ayeung", "displayName": "Allen Yeung", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Fixed as a part of https://github.com/appcelerator/titanium_mobile/pull/4417", "updateAuthor": { "name": "ayeung", "key": "ayeung", "displayName": "Allen Yeung", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-07-10T20:37:06.000+0000", "updated": "2013-07-10T20:37:06.000+0000" }, { "id": "263612", "author": { "name": "pagarwal", "key": "pagarwal", "displayName": "Priya Agarwal", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Updated Label.\r\nClosing as Fixed.\r\nVerified with:\r\n\r\nStudio: 3.1.2.201307261628\r\nSDK: 3.1.2.v20130726192706\r\nacs:1.0.4\r\nalloy:1.2.0-alpha\r\ntitanium:3.1.1\r\ntitanium-code-processor:1.0.2-alpha\r\nOS: OSX 10.8.4\r\nDevice: Google Nexus 7 (v4.2.1)\r\n\r\nactivityEnterAnimation and activityExitAnimation working well both for Window.close and Window.open method.", "updateAuthor": { "name": "pagarwal", "key": "pagarwal", "displayName": "Priya Agarwal", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2013-07-29T08:16:28.000+0000", "updated": "2013-07-29T08:16:28.000+0000" } ], "maxResults": 20, "total": 20, "startAt": 0 } } }