{
"id": "132212",
"key": "TIMOB-17215",
"fields": {
"issuetype": {
"id": "1",
"description": "A problem which impairs or prevents the functions of the product.",
"name": "Bug",
"subtask": false
},
"project": {
"id": "10153",
"key": "TIMOB",
"name": "Titanium SDK/CLI",
"projectCategory": {
"id": "10100",
"description": "Titanium and related SDKs used in application development",
"name": "Client"
}
},
"fixVersions": [
{
"id": "15422",
"description": "Release 3.3.0",
"name": "Release 3.3.0",
"archived": false,
"released": true,
"releaseDate": "2014-07-16"
},
{
"id": "15972",
"description": "Release 3.4.0",
"name": "Release 3.4.0",
"archived": false,
"released": true,
"releaseDate": "2014-09-28"
}
],
"resolution": {
"id": "1",
"description": "A fix for this issue is checked into the tree and tested.",
"name": "Fixed"
},
"resolutiondate": "2014-07-07T16:23:59.000+0000",
"created": "2014-06-25T07:28:01.000+0000",
"priority": {
"name": "High",
"id": "2"
},
"labels": [
"module_xml",
"overwrite",
"qe-testadded",
"xml"
],
"versions": [],
"issuelinks": [],
"assignee": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"updated": "2014-07-07T16:23:59.000+0000",
"status": {
"description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.",
"name": "Closed",
"id": "6",
"statusCategory": {
"id": 3,
"key": "done",
"colorName": "green",
"name": "Done"
}
},
"components": [
{
"id": "10207",
"name": "Tooling"
}
],
"description": "Its not possible to override resources such as xml or images that is used by a android module. e.g. changing the theme of a module's activity.\r\n\r\nSo the app folder APPFOLDER/platform/android/res/ will not override the MODULEFOLDER/platform/android/res/\r\n\r\nThis makes modules very unflexible to style/setup. ",
"attachment": [],
"flagged": false,
"summary": "Android Module Resources cannot be overridden",
"creator": {
"name": "viezel",
"key": "viezel",
"displayName": "Mads Moller",
"active": true,
"timeZone": "Europe/Berlin"
},
"subtasks": [],
"reporter": {
"name": "viezel",
"key": "viezel",
"displayName": "Mads Moller",
"active": true,
"timeZone": "Europe/Berlin"
},
"environment": "SDK 3.2.x, 3.3.0.RC\r\nOSX",
"closedSprints": [
{
"id": 135,
"state": "closed",
"name": "2014 Sprint 13 Tooling",
"startDate": "2014-06-23T23:44:04.894Z",
"endDate": "2014-07-04T00:00:00.000Z",
"completeDate": "2014-07-07T16:26:26.229Z",
"originBoardId": 100
}
],
"comment": {
"comments": [
{
"id": "310865",
"author": {
"name": "ingo",
"key": "ingo",
"displayName": "Ingo Muschenetz",
"active": true,
"timeZone": "America/Los_Angeles"
},
"body": "Thank you. And to confirm, this exists as of 3.2.0?",
"updateAuthor": {
"name": "ingo",
"key": "ingo",
"displayName": "Ingo Muschenetz",
"active": true,
"timeZone": "America/Los_Angeles"
},
"created": "2014-06-25T10:08:54.000+0000",
"updated": "2014-06-25T10:08:54.000+0000"
},
{
"id": "310872",
"author": {
"name": "viezel",
"key": "viezel",
"displayName": "Mads Moller",
"active": true,
"timeZone": "Europe/Berlin"
},
"body": "Correct",
"updateAuthor": {
"name": "viezel",
"key": "viezel",
"displayName": "Mads Moller",
"active": true,
"timeZone": "Europe/Berlin"
},
"created": "2014-06-25T11:22:07.000+0000",
"updated": "2014-06-25T11:22:07.000+0000"
},
{
"id": "310981",
"author": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"body": "Master pull request: https://github.com/appcelerator/titanium_mobile/pull/5850\r\n3_3_X pull request: https://github.com/appcelerator/titanium_mobile/pull/5851\r\n\r\nI also added warning messages whenever a resource or xml value is being overwritten. This is useful to make sure you are overwriting the module's resources.",
"updateAuthor": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"created": "2014-06-25T21:31:37.000+0000",
"updated": "2014-06-25T21:31:37.000+0000"
},
{
"id": "311033",
"author": {
"name": "viezel",
"key": "viezel",
"displayName": "Mads Moller",
"active": true,
"timeZone": "Europe/Berlin"
},
"body": "Hi Chris, \r\n\r\nThat was quick :) \r\nWill it also take into account the tiapp.xml manifest changes?\r\nLets say I want to override an module activity within my tiapp with a new custom android theme. will that work as well ?\r\n\r\ncheers",
"updateAuthor": {
"name": "viezel",
"key": "viezel",
"displayName": "Mads Moller",
"active": true,
"timeZone": "Europe/Berlin"
},
"created": "2014-06-26T06:45:22.000+0000",
"updated": "2014-06-26T06:45:22.000+0000"
},
{
"id": "311076",
"author": {
"name": "skypanther",
"key": "skypanther",
"displayName": "Tim Poulsen",
"active": true,
"timeZone": "America/New_York"
},
"body": "I need a test app and functional review steps before I can review this PR. [~viezel] can you attach a test project?",
"updateAuthor": {
"name": "skypanther",
"key": "skypanther",
"displayName": "Tim Poulsen",
"active": true,
"timeZone": "America/New_York"
},
"created": "2014-06-26T14:04:30.000+0000",
"updated": "2014-06-26T14:04:30.000+0000"
},
{
"id": "311117",
"author": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"body": "To test, I simply created the folder {{platform/android/res/values}} and create a {{strings.xml}} file in it with the following contents:\r\n\r\n{code}\r\n\r\n\r\n\tTest\r\n Log Me In\r\n\r\n{code}\r\n\r\nNext, enable the Facebook module in the {{tiapp.xml}}:\r\n\r\n{code}\r\n\r\n facebook\r\n\r\n{code}\r\n\r\nRun:\r\n\r\n{code}\r\nti build -p android --build-only --log-level trace\r\n{code}\r\n\r\nExamine the generated {{build/android/res/values/strings.xml}} and make sure that the \"com_facebook_loginview_log_in_button\" says \"Log Me In\" instead of \"Log In\".",
"updateAuthor": {
"name": "cbarber",
"key": "cbarber",
"displayName": "Chris Barber",
"active": true,
"timeZone": "America/Chicago"
},
"created": "2014-06-26T18:05:43.000+0000",
"updated": "2014-06-26T18:05:43.000+0000"
},
{
"id": "311133",
"author": {
"name": "skypanther",
"key": "skypanther",
"displayName": "Tim Poulsen",
"active": true,
"timeZone": "America/New_York"
},
"body": "Using the steps described by Chris, the change works as expected.",
"updateAuthor": {
"name": "skypanther",
"key": "skypanther",
"displayName": "Tim Poulsen",
"active": true,
"timeZone": "America/New_York"
},
"created": "2014-06-26T18:51:46.000+0000",
"updated": "2014-06-26T18:51:46.000+0000"
},
{
"id": "311885",
"author": {
"name": "sdowse",
"key": "sdowse",
"displayName": "Samuel Dowse",
"active": true,
"timeZone": "America/Los_Angeles"
},
"body": "Verified fixed on:\r\nMac OSX 10.9.3\r\nAppcelerator Studio, build: 3.3.0.201406271159\r\nTitanium SDK, build: 3.3.0.v20140701104113\r\nTitanium CLI, build: 3.3.0-rc4\r\nAlloy: 1.4.0-rc3\r\n\r\nFollowed test steps provided by [~cbarber].\r\nModule resource has been overridden successfully.\r\n\"com_facebook_loginview_log_in_button\" says \"Log Me In\" as expected.\r\nClosing.",
"updateAuthor": {
"name": "sdowse",
"key": "sdowse",
"displayName": "Samuel Dowse",
"active": true,
"timeZone": "America/Los_Angeles"
},
"created": "2014-07-01T20:01:15.000+0000",
"updated": "2014-07-01T20:01:15.000+0000"
}
],
"maxResults": 8,
"total": 8,
"startAt": 0
}
}
}