{
	"id": "138107",
	"key": "TIMOB-17868",
	"fields": {
		"issuetype": {
			"id": "1",
			"description": "A problem which impairs or prevents the functions of the product.",
			"name": "Bug",
			"subtask": false
		},
		"project": {
			"id": "10153",
			"key": "TIMOB",
			"name": "Titanium SDK/CLI",
			"projectCategory": {
				"id": "10100",
				"description": "Titanium and related SDKs used in application development",
				"name": "Client"
			}
		},
		"fixVersions": [
			{
				"id": "16723",
				"description": "Windows Platform Support, ListView updates, Vector overlays in maps",
				"name": "Release 4.1.0",
				"archived": false,
				"released": true,
				"releaseDate": "2015-07-08"
			}
		],
		"resolution": {
			"id": "7",
			"description": "",
			"name": "Invalid"
		},
		"resolutiondate": "2015-01-07T22:48:35.000+0000",
		"created": "2014-10-15T17:52:57.000+0000",
		"priority": {
			"name": "High",
			"id": "2"
		},
		"labels": [
			"merge-3.4.2"
		],
		"versions": [],
		"issuelinks": [],
		"assignee": {
			"name": "ingo",
			"key": "ingo",
			"displayName": "Ingo Muschenetz",
			"active": true,
			"timeZone": "America/Los_Angeles"
		},
		"updated": "2015-06-23T19:51:14.000+0000",
		"status": {
			"description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.",
			"name": "Closed",
			"id": "6",
			"statusCategory": {
				"id": 3,
				"key": "done",
				"colorName": "green",
				"name": "Done"
			}
		},
		"components": [
			{
				"id": "12642",
				"name": "Windows",
				"description": "Windows authoring support"
			}
		],
		"description": "protect() and unprotect() should be unnecessary for the developer to call directly, but there seem to be some cases where they appear to be required. We need to understand the reasons they are used, and upgrade the infrastructure to remove that necessity.\r\n\r\nYou need to ensure that `Ti.UI.createAlertDialog` API is exposed, so please copy and paste this into the `TiUIModule.cpp` js string:\r\n{code}\r\n\"\t Object.defineProperties(self.TiUIAlertDialog.prototype, {\"\r\n\"\t\t 'buttonNames': {set:function(value){for(var i=0,len=value.length;i<len;i++) this.addButton(value[i]); this._buttonNames=value;},get:function(){return this._buttonNames;},enumerable: true}\"\r\n\"\t});\"\r\n\"\texports.createAlertDialog = function(args) {\"\r\n\"\t\tvar a = new self.TiUIAlertDialog();\"\r\n\"\t\ta.applyProperties(args);\"\r\n\"\t\treturn a;\"\r\n\"\t};\"\r\n{code}\r\n\r\nYou also need to remove the protect/unprotect() calls inside AlertDialog.\r\n\r\nHere's the test, and steps to reproduce: (code under steps)\r\n\r\n1. Click on the button\r\n2. See the alert dialog\r\n3. Click on any of the two buttons in less than one second since shown\r\nAt this point you will see something is the console log\r\n4. Repeat set number 3 but this time wait over a second\r\n\r\nAt this point the log will not show.\r\n\r\n{code}\r\nvar win = Ti.UI.createWindow();\r\nvar btn = Ti.UI.createButton({\r\n    title: 'here'\r\n});\r\nwin.add(btn);\r\nbtn.addEventListener('click', function () {\r\n    var a = Ti.UI.createAlertDialog({title: 'title',message: 'message',buttonNames: ['ok', 'cancel']});\r\n    a.addEventListener('click', function () {\r\n        Ti.API.info('Alert clicked!!!');\r\n    });\r\n    a.show();\r\n    setTimeout(function () {\r\n        Ti.GC();\r\n        Ti.API.info('Garbage collection called');\r\n    }, 1000);\r\n});\r\nwin.open();\r\n{code}\r\n\r\nExplanation:\r\n\r\nSince the `protect` and `unprotect` have been removed, the alert dialog proxy will die when garbage collection is called. In the button event listener we're calling GC (for testing purposes only) after one second. If you click on the button before GC, you're saved and the event listener of the alert is called. If you wait for the GC to be called, the event listener is not called.\r\n\r\nThe `share_ptr` is likely hiding a bug. In the \"click\" event handler of the alert's button (native event handler), we're checking if the proxy is still alive or not, and if it's not, we just ignore the callback to avoid a crash. But we need to realize that the native alert object and its buttons may still alive. And the question is, when will the native alert and its buttons be release from memory?\r\n\r\nThis is the reason for a `protect` and `unprotect` in the alert dialog proxy. I added the `protect` and `unprotect` back to test, and everything will go back to normal.",
		"attachment": [],
		"flagged": false,
		"summary": "Windows: Investigate necessity of protect() and unprotect() usage",
		"creator": {
			"name": "ingo",
			"key": "ingo",
			"displayName": "Ingo Muschenetz",
			"active": true,
			"timeZone": "America/Los_Angeles"
		},
		"subtasks": [],
		"reporter": {
			"name": "ingo",
			"key": "ingo",
			"displayName": "Ingo Muschenetz",
			"active": true,
			"timeZone": "America/Los_Angeles"
		},
		"environment": null,
		"comment": {
			"comments": [
				{
					"id": "338270",
					"author": {
						"name": "mlangston",
						"key": "mlangston",
						"displayName": "Matt Langston",
						"active": true,
						"timeZone": "America/Los_Angeles"
					},
					"body": "This ticket is invalid because HAL assumes responsibility for all JavaScriptCore memory management via RAII.",
					"updateAuthor": {
						"name": "mlangston",
						"key": "mlangston",
						"displayName": "Matt Langston",
						"active": true,
						"timeZone": "America/Los_Angeles"
					},
					"created": "2015-01-07T22:48:35.000+0000",
					"updated": "2015-01-07T22:48:35.000+0000"
				},
				{
					"id": "355790",
					"author": {
						"name": "emerriman",
						"key": "emerriman",
						"displayName": "Eric Merriman ",
						"active": true,
						"timeZone": "America/Los_Angeles"
					},
					"body": "Closing as invalid. If you feel this is inaccurate, please reopen.",
					"updateAuthor": {
						"name": "emerriman",
						"key": "emerriman",
						"displayName": "Eric Merriman ",
						"active": true,
						"timeZone": "America/Los_Angeles"
					},
					"created": "2015-06-23T19:51:09.000+0000",
					"updated": "2015-06-23T19:51:09.000+0000"
				}
			],
			"maxResults": 2,
			"total": 2,
			"startAt": 0
		}
	}
}