{ "id": "140180", "key": "TIMOB-18071", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16704", "description": "Release 3.5.0", "name": "Release 3.5.0", "archived": false, "released": true, "releaseDate": "2015-01-13" }, { "id": "16593", "description": "Release 4.0.0", "name": "Release 4.0.0", "archived": false, "released": true, "releaseDate": "2015-05-21" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2014-12-15T19:29:57.000+0000", "created": "2014-11-21T20:43:07.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "qe-assigned" ], "versions": [], "issuelinks": [ { "id": "43753", "type": { "id": "10122", "name": "Gantt: start-finish", "inward": "is triggered by", "outward": "is triggering" }, "outwardIssue": { "id": "141058", "key": "TIMOB-18145", "fields": { "summary": "iphone module build succeed though there is a missing architecture", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "43684", "type": { "id": "10011", "name": "Includes", "inward": "is included by", "outward": "includes" }, "inwardIssue": { "id": "100426", "key": "TIMOB-10757", "fields": { "summary": "CLI: Module Build", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "6", "description": "gh.issue.epic.desc", "name": "Epic", "subtask": false } } } }, { "id": "43145", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "140126", "key": "TIMOB-18065", "fields": { "summary": "Add compiled architectures to module manifest template", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "updated": "2015-01-18T04:14:33.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" }, { "id": "10230", "name": "BlackBerry", "description": "BlackBerry Platform" }, { "id": "13103", "name": "CLI", "description": "Node-based command line interface" }, { "id": "10206", "name": "iOS", "description": "iOS Platform" }, { "id": "10207", "name": "Tooling" } ], "description": "With the addition of 64-bit support, it becomes helpful to know the architectures available in a compiled module. We can then use this ins tooling to make sure modules are compiled correctly for use.\r\n\r\nSee TIMOB-18065 for more information.\r\n\r\nOnce the module build is complete, we need to check the architectures specified and fail the build if they do not match.\r\n\r\n* If the line exists, but is wrong, suggest the updated version. If they are missing 64-bit for iOS, warn them\r\n* If the line does not exist, suggest what it should be.", "attachment": [], "flagged": false, "summary": "CLI: Fail build if compiled architectures do not match module manifest", "creator": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 288, "state": "closed", "name": "2014 Sprint 25 Tooling", "startDate": "2014-12-08T17:30:22.215Z", "endDate": "2014-12-20T02:30:00.000Z", "completeDate": "2014-12-29T18:24:09.765Z", "originBoardId": 121 } ], "comment": { "comments": [ { "id": "334197", "author": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Feon, is this something you or [~skypanther] could tackle?", "updateAuthor": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2014-12-01T21:44:55.000+0000", "updated": "2014-12-01T21:44:55.000+0000" }, { "id": "334281", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "I can give it a shot.", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2014-12-02T02:10:32.000+0000", "updated": "2014-12-02T02:10:32.000+0000" }, { "id": "335014", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/6433\r\n\r\nFunctional Test:\r\n\r\n1. create a module \r\n{code}ti create -p all -t module -n test -u http:// --id com.appc.test{code}\r\n\r\nh6. For iOS\r\n1. cd into module iphone directory\r\n2. comment out {{architectures: armeabi armeabi-v7a x86}} in {{manifest}}\r\n3. run {{./build.py}}\r\n4. build should fail with follow error\r\n{code} missing required manifest key 'architectures' {code}\r\n5. edit architectures value in manifest, build again build should fail\r\n{code} \r\n[WARN] there is discrepancy between the architectures specified in module manifest and compiled binary.\r\n[WARN] architectures in manifest: i386, arm64, armv7\r\n[WARN] compiled binary architectures: x86_64, i386, arm64, armv7\r\nplease update manifest to match module binary architectures.\r\n{code}\r\n6. undo all changes to manifest, module should be build successfully.\r\n\r\nh6. For Android\r\n1. cd into module android directory\r\n2. comment out {{architectures: armeabi armeabi-v7a x86}} in {{manifest}}\r\n3. run {{ant}}\r\n4. build should fail with follow error\r\n{code}\r\nBUILD FAILED\r\n/Users/feonsua/work/testapps/360/mods/newTestMod/android/build.xml:11: Missing required manifest key 'architectures'.\r\n{code}\r\n5.edit architectures value in manifest, build should fail\r\n{code}\r\ncheck.build.arch:\r\n [echo] Architectures in manifest: armeabi armeabi-v7a\r\n [echo] Compiled binary architectures: armeabi;armeabi-v7a;x86\r\n\r\nBUILD FAILED\r\n/Users/feonsua/Library/Application Support/Titanium/mobilesdk/osx/3.6.0/module/android/build.xml:374: The following error occurred while executing this line:\r\n/Users/feonsua/Library/Application Support/Titanium/mobilesdk/osx/3.6.0/module/android/build.xml:376: There is discrepancy between the architectures specified in manifest and compiled binary.\r\n{code}\r\n6. undo all changes to manifest, module should be build successfully.", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2014-12-05T08:23:38.000+0000", "updated": "2014-12-05T08:23:38.000+0000" }, { "id": "335040", "author": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "body": "FR/CR passed. PR merged.", "updateAuthor": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "created": "2014-12-05T14:38:46.000+0000", "updated": "2014-12-05T14:38:46.000+0000" }, { "id": "335041", "author": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "body": "Reopen to backport to 3_5_X", "updateAuthor": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "created": "2014-12-05T14:49:33.000+0000", "updated": "2014-12-05T14:49:33.000+0000" }, { "id": "335042", "author": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "body": "3_5_X backport https://github.com/appcelerator/titanium_mobile/pull/6434", "updateAuthor": { "name": "skypanther", "key": "skypanther", "displayName": "Tim Poulsen", "active": true, "timeZone": "America/New_York" }, "created": "2014-12-05T14:49:47.000+0000", "updated": "2014-12-05T14:49:47.000+0000" }, { "id": "335180", "author": { "name": "pinnamuri", "key": "pinnamuri", "displayName": "Praveen Innamuri", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PR passed, but found a parity with iphone module build. If x86_64 arch is removed, then there is a warning in the build logs, but the build still succeed. However, if any arch is missing for android module, then the build has failed with appropriate warning. Created TIMOB-18145 for this.", "updateAuthor": { "name": "pinnamuri", "key": "pinnamuri", "displayName": "Praveen Innamuri", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2014-12-06T00:28:11.000+0000", "updated": "2014-12-06T00:28:11.000+0000" }, { "id": "335750", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified fixed using:\r\n\r\nTitanium SDK 3.5.0.v20141208122514\r\nStudio 3.4.1.201410281743 \r\nXcode 6.1.1", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2014-12-09T23:56:37.000+0000", "updated": "2014-12-09T23:56:37.000+0000" }, { "id": "336373", "author": { "name": "jalter", "key": "jalter", "displayName": "Jon Alter", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Getting this error in the log when building an iOS module even though the architectures being built are correct:\r\n{code}\r\n[WARN] built module is missing 64-bit support.\r\n[WARN] there is discrepancy between the architectures specified in module manifest and compiled binary.\r\n[WARN] architectures in manifest: x86_64, i386, arm64, armv7\r\n[WARN] compiled binary architectures: x86_64, (cputype, i386, (16777228), armv7, cpusubtype, (0))\r\nplease update manifest to match module binary architectures.\r\n{code}\r\n\r\nh6. PR\r\nmaster: https://github.com/appcelerator/titanium_mobile/pull/6482\r\n3_5_X: https://github.com/appcelerator/titanium_mobile/pull/6485", "updateAuthor": { "name": "jalter", "key": "jalter", "displayName": "Jon Alter", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2014-12-15T15:53:01.000+0000", "updated": "2014-12-15T19:07:20.000+0000" }, { "id": "336408", "author": { "name": "vduggal", "key": "vduggal", "displayName": "Vishal Duggal", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PRs merged\r\n3_5_X - https://github.com/appcelerator/titanium_mobile/pull/6485", "updateAuthor": { "name": "vduggal", "key": "vduggal", "displayName": "Vishal Duggal", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2014-12-15T19:29:57.000+0000", "updated": "2014-12-15T19:29:57.000+0000" }, { "id": "338081", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified using functional test by [~fmiao] for android & as expected build fails if compiled architectures do not match module manifest.\r\n\r\nEnvironment:\r\nAppc Studio : 3.4.1.201410281743\r\nTi SDK : 3.5.0.v20150106150919, 3.6.0.v20150106160923\r\nCLI : 3.4.1\r\nAlloy : 1.5.1 GA\r\nCode Processor : 1.1.1\r\nMAC Yosemite : 10.10", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-01-07T00:46:50.000+0000", "updated": "2015-01-07T00:46:50.000+0000" }, { "id": "338756", "author": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Closing as fixed.", "updateAuthor": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-01-12T23:00:15.000+0000", "updated": "2015-01-12T23:00:15.000+0000" }, { "id": "339596", "author": { "name": "mdsb100", "key": "mdsb100", "displayName": "曹俊", "active": true, "timeZone": "America/Los_Angeles" }, "body": "what time or which version do you publish it?", "updateAuthor": { "name": "mdsb100", "key": "mdsb100", "displayName": "曹俊", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-01-17T16:23:08.000+0000", "updated": "2015-01-17T16:23:08.000+0000" }, { "id": "339617", "author": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~mdsb100] What do you mean?", "updateAuthor": { "name": "ingo", "key": "ingo", "displayName": "Ingo Muschenetz", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-01-18T04:14:33.000+0000", "updated": "2015-01-18T04:14:33.000+0000" } ], "maxResults": 14, "total": 14, "startAt": 0 } } }