{ "id": "151029", "key": "TIMOB-19477", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16925", "description": "WatchKit Support--all going into 5.0 now", "name": "Release 5.0.0", "archived": true, "released": true, "releaseDate": "2015-09-16" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2015-09-11T00:30:41.000+0000", "created": "2015-09-08T18:46:17.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [], "versions": [ { "id": "16925", "description": "WatchKit Support--all going into 5.0 now", "name": "Release 5.0.0", "archived": true, "released": true, "releaseDate": "2015-09-16" } ], "issuelinks": [ { "id": "48945", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "151088", "key": "DE-342", "fields": { "summary": "Sample apps Movies, Employees Directory etc. missing app icons", "status": { "description": "A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.", "name": "Resolved", "id": "5", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "50672", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "151494", "key": "TISTUD-7727", "fields": { "summary": "Studio: Make Icon in tiapp.xml work", "status": { "description": "This issue is being actively worked on at the moment by the assignee.", "name": "In Progress", "id": "3", "statusCategory": { "id": 4, "key": "indeterminate", "colorName": "yellow", "name": "In Progress" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "7", "description": "gh.issue.story.desc", "name": "Story", "subtask": false } } } }, { "id": "48980", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "151153", "key": "TIMOB-19509", "fields": { "summary": "DefaultIcon.png needs to support platform specific versions", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "48931", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "151060", "key": "TIMOB-19486", "fields": { "summary": "Android: Generate missing app icons based on DefaultIcon.png", "status": { "description": "This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.", "name": "Reopened", "id": "4", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "48944", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "151081", "key": "ALOY-1302", "fields": { "summary": "Alloy needs to have a consistent behavior with Ti on App Icons", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "48933", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "151061", "key": "TIMOB-19487", "fields": { "summary": "Windows: Generate missing app icons based on DefaultIcon.png", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "48929", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "151059", "key": "TIMOB-19485", "fields": { "summary": "MobileWeb: Generate missing app icons based on DefaultIcon.png", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "updated": "2016-02-23T08:21:45.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10207", "name": "Tooling" } ], "description": "With the introduction of Asset Catalog support for app icons for iOS 9, we no longer use the appicon.png and appicon@2x.png images other than to resize them to generate missing images.\r\n\r\nFurthermore, it build now requires appicon.png or appicon@2x.png to be at least 180x180 pixels.\r\n\r\nSince this is sort of awkward change of behavior, it would be better to introduce a new image called \"DefaultIcon.png\" that we use to generate all missing icons as well as the iTunesArtwork for iOS builds.\r\n\r\nInitially this would be implemented for iOS. Android, Windows, and Mobile Web support would be implemented in different tickets.\r\n\r\nSince the DefaultIcon.png should not be apart of a built app, it must not go in the Resources directory and thus shall be searched for in the project root directory.", "attachment": [ { "id": "56671", "filename": "defaultContent.png", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-10T10:47:38.000+0000", "size": 107623, "mimeType": "image/png" }, { "id": "56670", "filename": "DefaultIcon.png", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-10T10:47:59.000+0000", "size": 91321, "mimeType": "image/png" }, { "id": "56672", "filename": "withDefaultAndAllIcons.png", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-10T10:47:38.000+0000", "size": 108350, "mimeType": "image/png" }, { "id": "56673", "filename": "withDefaultandSomeMissingIcons.png", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-10T10:47:38.000+0000", "size": 174871, "mimeType": "image/png" } ], "flagged": false, "summary": "Add support for DefaultIcon.png to generate missing app icons/artwork", "creator": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "subtasks": [], "reporter": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "environment": null, "closedSprints": [ { "id": 487, "state": "closed", "name": "2015 Sprint 18 Tooling", "startDate": "2015-08-31T15:59:21.784Z", "endDate": "2015-09-12T00:59:00.000Z", "completeDate": "2015-09-14T23:09:59.452Z", "originBoardId": 121 } ], "comment": { "comments": [ { "id": "362725", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Master PR: https://github.com/appcelerator/titanium_mobile/pull/7157\r\n5_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/7158", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2015-09-10T06:40:37.000+0000", "updated": "2015-09-10T06:40:37.000+0000" }, { "id": "362743", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "h4. Test cases Titanium CLI:\r\nA. Brand new project via Ti, *ti create*, *ti build -p ios*\r\nB. *ti build -p ios -T dist-adhoc*\r\nC. Scenario where DefaultIcon.png (use [^DefaultIcon.png] in ticket), and ALL icons described [here|http://docs.appcelerator.com/platform/latest/#!/guide/Icons_and_Splash_Screens] exists, but are different from DefaultIcon.png. (This is the situation when a user decide to IGNORE the DefaultIcon.png and have his very own other icons). *ti build -p ios*\r\nD. Scenario where DefaultIcon.png is missing, but ALL icons described [here|http://docs.appcelerator.com/platform/latest/#!/guide/Icons_and_Splash_Screens] exists. (This is the situation when a user updates an existing project to the latest SDK). *ti build -p ios*\r\nE. Scenario where DefaultIcon.png is missing, but SOME icons described [here|http://docs.appcelerator.com/platform/latest/#!/guide/Icons_and_Splash_Screens] are missing. (This is the situation when a user updates an existing project with missing icons to the latest SDK). *ti build -p ios*\r\n\r\nh4. Expected Results:\r\nA. Build success. See inside build->iphone->Assets.xcassets and see these files [^defaultContent.png]\r\nB. Build success. See inside build->iphone->build->Products->Release-iphoneos->SGIcon.app->Show Package Content, there's the iTunesArtwork.png and iTunesArtwork@2x.png\r\nC. Build success. User's icons should be prioritized over the use of DefaultIcon.png. See inside build->iphone->Assets.xcassets and see these files [^withDefaultAndAllIcons.png]\r\nD. Build success. See inside build->iphone->Assets.xcassets and see these files [^withDefaultAndAllIcons.png]\r\nE. Build Fail. See error prompt \r\n{code}\r\n[ERROR] There are missing app icons\r\n[ERROR] You must either create the missing icons below or create an image named \"DefaultIcon.png\" in the root of your project\r\n[ERROR] If the DefaultIcon.png image is present, the build will use it to generate all missing icons\r\n[ERROR] It is highly recommended that the DefaultIcon.png be 1024x1024\r\n[ERROR] Unable to create missing icons:\r\n[ERROR] Resources/iphone/appicon-Small@3x.png - Used for iPhone - required size: 87x87\r\n[ERROR] Resources/iphone/appicon-Small-40@3x.png - Used for iPhone - required size: 120x120\r\n[ERROR] Resources/iphone/appicon-60@3x.png - Used for iPhone - required size: 180x180\r\n[ERROR] An error occurred during build after 2s 554ms\r\n{code}\r\n\r\nReviewed and Tested. Approved and merging master PR first. ", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-10T09:58:27.000+0000", "updated": "2015-09-10T12:07:14.000+0000" }, { "id": "362744", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-10T11:09:54.000+0000", "updated": "2015-09-10T12:34:19.000+0000" }, { "id": "362768", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Master PR 2: https://github.com/appcelerator/titanium_mobile/pull/7163", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2015-09-10T18:20:41.000+0000", "updated": "2015-09-10T18:20:41.000+0000" }, { "id": "363562", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PRs approved and merged.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-11T00:30:20.000+0000", "updated": "2015-09-11T00:30:20.000+0000" }, { "id": "363602", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified implemented, using:\r\n\r\nMacOS 10.11 (15A279b)\r\nStudio 5.0.0.201508271032\r\nTi SDK 5.0.0.v20150910192021\r\nAppc NPM 4.2.0-1\r\nAppc CLI 4.1.3-9\r\nTi CLI 4.0.1\r\nAlloy 1.6.2\r\nArrow 1.2.48\r\nXcode 7.0 (7A218)\r\nNode v0.10.37\r\nJava 1.7.0_45\r\nproduction\r\n\r\nApp icons are successfully generated for classic projects, user specified icons are used over the generated icons, and errors are correctly thrown if DefaultIcon.png and user icons are missing, when required.", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-11T16:36:38.000+0000", "updated": "2015-09-11T16:36:38.000+0000" } ], "maxResults": 6, "total": 6, "startAt": 0 } } }