{ "id": "151179", "key": "TIMOB-19522", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "14826", "description": "Release 5.1.0-remaining iOS9 features, Android M features", "name": "Release 5.1.0", "archived": false, "released": true, "releaseDate": "2015-11-20" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2015-09-16T18:37:14.000+0000", "created": "2015-09-15T06:07:35.000+0000", "priority": { "name": "Low", "id": "4" }, "labels": [ "activityindicator" ], "versions": [], "issuelinks": [], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2015-12-13T20:19:45.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "Currently, the {{style}} property of the {{Ti.UI.ActivityIndicator}} needed to be if-cased for Android, MobileWeb and Windows on the one side and iOS on the other (using the .iPhone.) namespace.\r\n\r\n{code}\r\nTitanium.UI.iPhone.ActivityIndicatorStyle.BIG\r\nTitanium.UI.iPhone.ActivityIndicatorStyle.DARK\r\nTitanium.UI.iPhone.ActivityIndicatorStyle.PLAIN\r\nTitanium.UI.ActivityIndicatorStyle.BIG\r\nTitanium.UI.ActivityIndicatorStyle.BIG_DARK\r\nTitanium.UI.ActivityIndicatorStyle.DARK\r\nTitanium.UI.ActivityIndicatorStyle.PLAIN\r\n{code}\r\n\r\nFor parity, we should migrate the iOS constants to work on the name namespace as the other platforms do and warn the dev about the deprecated namespace like we have done earlier with related use cases.", "attachment": [], "flagged": false, "summary": "iOS: Platform parity in Ti.UI.ActivityIndicator \"style\" property", "creator": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "closedSprints": [ { "id": 485, "state": "closed", "name": "2015 Sprint 19 SDK", "startDate": "2015-09-12T00:30:29.539Z", "endDate": "2015-09-26T00:30:00.000Z", "completeDate": "2015-09-28T02:29:14.458Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "363976", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "* Moved {{style}} value from {{Ti.UI.iPhone.ActivityIndicatorStyle.\\*}} to {{Ti.UI.ActivityIndicatorStyle.*}}\r\n* Deprecated {{Ti.UI.iPhone.ActivityIndicatorStyle.\\*}} starting in 5.1.0\r\n* Updated docs to reflect changed behavior\r\n\r\nDemo code:\r\n{code}\r\nvar win = Ti.UI.createWindow({\r\n\tbackgroundColor : \"#555\",\r\n\tlayout : \"vertical\"\r\n});\r\n\r\nvar act1 = Ti.UI.createActivityIndicator({\r\n\tstyle : Ti.UI.iPhone.ActivityIndicatorStyle.PLAIN,\r\n\ttop : 30\r\n});\r\n\r\nvar act2 = Ti.UI.createActivityIndicator({\r\n\tstyle : Ti.UI.iPhone.ActivityIndicatorStyle.BIG,\r\n\ttop : 30\r\n});\r\n\r\nvar act3 = Ti.UI.createActivityIndicator({\r\n\tstyle : Ti.UI.iPhone.ActivityIndicatorStyle.DARK,\r\n\ttop : 30\r\n});\r\n\r\nwin.add(act1);\r\nwin.add(act2);\r\nwin.add(act3);\r\n\r\nact1.show();\r\nact2.show();\r\nact3.show();\r\n\r\nwin.open(); \r\n{code}\r\n\r\nPR pending: https://github.com/appcelerator/titanium_mobile/pull/7190", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2015-09-15T17:28:40.000+0000", "updated": "2015-09-15T18:14:56.000+0000" }, { "id": "364102", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Thanks! PR Merged.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-16T18:36:58.000+0000", "updated": "2015-09-16T18:36:58.000+0000" }, { "id": "364105", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Another PR to fix a mistake in last PR: https://github.com/appcelerator/titanium_mobile/pull/7199", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-09-16T18:46:54.000+0000", "updated": "2015-09-16T18:46:54.000+0000" }, { "id": "366709", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "Verified as fixed, can confirm that I receive the appropriate message when using the deprecated class:\r\n\r\n{code:java}\r\n[WARN] : Titanium.UI.iPhone.ActivityIndicatorStyle.PLAIN DEPRECATED in 5.1.0, in favor of Ti.UI.ActivityIndicatorStyle.PLAIN.\r\n[DEBUG] : Loading: /var/mobile/Containers/Bundle/Application/D2D9A719-9F07-403D-BE06-4548DA34AEC5/timob19522.app/_app_props_.json, Resource: _app_props__json\r\n[WARN] : Titanium.UI.iPhone.ActivityIndicatorStyle.BIG DEPRECATED in 5.1.0, in favor of Ti.UI.ActivityIndicatorStyle.BIG.\r\n[WARN] : Titanium.UI.iPhone.ActivityIndicatorStyle.DARK DEPRECATED in 5.1.0, in favor of Ti.UI.ActivityIndicatorStyle.DARK.\r\n{code}\r\n\r\nOSX El Capitan 10.11\r\nStudio: 4.3.1.201509302304\r\nTi SDK: 5.2.0.v20151009071418\r\nAppc NPM: 4.2.1-1\r\nAppc CLI: 5.1.0-38", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2015-10-13T21:43:03.000+0000", "updated": "2015-10-13T21:43:03.000+0000" }, { "id": "372778", "author": { "name": "jtoth", "key": "jtoth", "displayName": "Justin Toth", "active": true, "timeZone": "America/New_York" }, "body": "I think there's a bug here... In my app, which is named \"Housters\", the warning in the log states:\r\n\r\n*[WARN] Titanium.UI.iPhone.ActivityIndicatorStyle.DARK DEPRECATED in 5.1.0, in favor of Housters.UI.ActivityIndicatorStyle.DARK.*\r\n\r\nThis is obviously incorrect, Housters.UI.ActivityIndicatorStyle.DARK doesn't exist. It should say Ti.UI.ActivityIndicatorStyle.DARK.\r\n\r\nTested on Ti SDK 5.1.0.GA and iPhone 6 Simulator.", "updateAuthor": { "name": "jtoth", "key": "jtoth", "displayName": "Justin Toth", "active": true, "timeZone": "America/New_York" }, "created": "2015-12-13T19:59:13.000+0000", "updated": "2015-12-13T19:59:13.000+0000" }, { "id": "372779", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "The compiler replaces \"Titanium\" in the logs when running on devices. It's fixed globally in 5.2.0 as part of TIMOB-20015. Greets!", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2015-12-13T20:19:45.000+0000", "updated": "2015-12-13T20:19:45.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }