{ "id": "152238", "key": "TIMOB-19759", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16997", "name": "Release 5.2.0", "archived": false, "released": true, "releaseDate": "2016-02-23" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2015-12-07T05:25:20.000+0000", "created": "2015-10-22T02:00:26.000+0000", "priority": { "name": "Low", "id": "4" }, "labels": [ "qe-5.2.0", "tab", "tabGroup" ], "versions": [], "issuelinks": [ { "id": "50586", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "154926", "key": "TIDOC-2444", "fields": { "summary": "TabGroup/Tab focus/blur selected/unselected events not correctly documented", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "49410", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "139164", "key": "TIMOB-18099", "fields": { "summary": "iOS: Parity: Clean up tab events", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Low", "id": "4" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2016-02-15T13:50:48.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "On Android you listen for the events on the Tab object, but on iOS you listen for the events on the TabGroup. ", "attachment": [], "flagged": false, "summary": "iOS: Parity: tab listeners", "creator": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 536, "state": "closed", "name": "2015 Sprint 25 SDK", "startDate": "2015-12-05T01:30:40.415Z", "endDate": "2015-12-19T01:30:00.000Z", "completeDate": "2015-12-29T03:19:42.127Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "370211", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "On Android, Windows and iOS the TabGroup has a {{focus}} event with information on the previous and current active tab, even though it is [documented as Android and Windows only|http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.TabGroup-event-focus].\r\n\r\nFor iOS we've now added {{selected}} and {{unselected}} events to the TabGroup with TIMOB-18099, which really should have been added to the Tab, like [Android|http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.Tab-event-selected] has.\r\n\r\n* TIMOB-18099 should be reverted.\r\n* The TabGroup's {{focus}} event should be documented for iOS as well.\r\n* The {{selected}} and {{unselected}} events should be added to the Tab for both iOS and Windows.", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-11-13T16:07:45.000+0000", "updated": "2015-11-13T16:09:02.000+0000" }, { "id": "371478", "author": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR pending https://github.com/appcelerator/titanium_mobile/pull/7498. \r\n\r\n{code:title=DemoCode.java|borderStyle=solid}\r\nvar win1 = Ti.UI.createWindow({\r\n backgroundColor : 'blue',\r\n title \t\t\t: 'Blue'\r\n});\r\nwin1.add(Ti.UI.createLabel({text: 'I am a blue window.'}));\r\n \r\nvar win2 = Ti.UI.createWindow({\r\n backgroundColor : 'red',\r\n title \t\t\t: 'Red'\r\n});\r\nwin2.add(Ti.UI.createLabel({text: 'I am a red window.'}));\r\n \r\nvar tab1 = Ti.UI.createTab({\r\n window : win1,\r\n title : 'Blue'\r\n}),\r\ntab2 = Ti.UI.createTab({\r\n window : win2,\r\n title : 'Red'\r\n}),\r\ntabGroup = Ti.UI.createTabGroup({\r\n tabs: [tab1, tab2]\r\n});\r\n\r\n//Should display deprecated message.\r\n tabGroup.addEventListener(\"focus\", function(e){\r\n \tTi.API.info(\"tabGroup is focused \");\r\n \tTi.API.info(e);\r\n\r\n });\r\n\r\n tabGroup.addEventListener(\"blur\", function(e){\r\n \tTi.API.info(\"tabGroup is blured \");\r\n \tTi.API.info(e);\r\n});\r\n\r\n //Should display deprecated message.\r\n tab1.addEventListener(\"focus\", function(e){\r\n \tTi.API.info(\"Tab1 is focused \");\r\n });\r\n\r\n tab1.addEventListener(\"blur\", function(e){\r\n \tTi.API.info(\"Tab is blured \");\r\n});\r\n\r\n\r\ntab2.addEventListener(\"selected\", function(e){\r\n \tTi.API.info(\"Tab2 is selected\");\r\n \tTi.API.info(e);\r\n });\r\n\r\n tab2.addEventListener(\"unselected\", function(e){\r\n \tTi.API.info(\"Tab2 is unselected\");\r\n \tTi.API.info(e.index);\r\n});\r\n\r\ntabGroup.open();\r\n{code}", "updateAuthor": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-11-25T19:29:54.000+0000", "updated": "2015-11-25T19:48:26.000+0000" }, { "id": "371533", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Shouldn't we first deprecate the tabgroup's selected and unselected events we've added in 5.1.0 and remove them in 6.0?\n\nAlso, I think the PR is missing adding iOS as platform to the tabgroup's focus and blur events?", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-11-26T07:04:42.000+0000", "updated": "2015-11-26T07:04:42.000+0000" }, { "id": "371568", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~apetkov] Kindly address the comments.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-11-27T03:42:40.000+0000", "updated": "2015-11-27T03:42:40.000+0000" }, { "id": "371673", "author": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR updated. Deprecated the unselected/selected events. Also added platform tags to the focus/blur events on the docs.", "updateAuthor": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-11-30T20:02:01.000+0000", "updated": "2015-11-30T20:02:23.000+0000" }, { "id": "372258", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PR merged.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-12-07T05:25:03.000+0000", "updated": "2015-12-07T05:25:03.000+0000" }, { "id": "375014", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "Verified fixed, {{focus}} event now returns deprecated message, in favour of new {{selected}} & {{unselected}} events.\r\nNew events working correctly.\r\n\r\nTested on:\r\niPhone 6s Plus Device (9.2) & iPhone 6 Plus Device (8.4) \r\nMac OSX El Capitan 10.11 (15A284)\r\nTi SDK: 5.2.0.v20160114021251\r\nAppc NPM: 4.2.3-1\r\nApp CLI: 5.2.0-231\r\nXcode 7.2\r\nNode v4.2.3\r\n\r\n*Closing Ticket.*\r\n\r\n\r\n\r\n", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2016-01-20T23:52:36.000+0000", "updated": "2016-01-20T23:52:36.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }