{ "id": "152372", "key": "TIMOB-19802", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17072", "name": "Release 5.1.2", "archived": false, "released": true, "releaseDate": "2016-01-12" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2015-12-02T22:58:24.000+0000", "created": "2015-10-27T12:05:36.000+0000", "priority": { "name": "Low", "id": "4" }, "labels": [], "versions": [ { "id": "14826", "description": "Release 5.1.0-remaining iOS9 features, Android M features", "name": "Release 5.1.0", "archived": false, "released": true, "releaseDate": "2015-11-20" } ], "issuelinks": [ { "id": "49899", "type": { "id": "10002", "name": "Duplicate", "inward": "is duplicated by", "outward": "duplicates" }, "inwardIssue": { "id": "152373", "key": "TIMOB-19803", "fields": { "summary": "Android: CardView should not have both borderRadius and cardCornerRadius", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "49991", "type": { "id": "10120", "name": "Gantt: finish-start", "inward": "has to be done after", "outward": "has to be done before" }, "outwardIssue": { "id": "152345", "key": "TIMOB-19798", "fields": { "summary": "CardView: contentPadding(X) and cardCornerRadius should use default unit", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "49893", "type": { "id": "10120", "name": "Gantt: finish-start", "inward": "has to be done after", "outward": "has to be done before" }, "inwardIssue": { "id": "152342", "key": "TIMOB-19796", "fields": { "summary": "Android: CardView Layout property not working as expected", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "49896", "type": { "id": "10120", "name": "Gantt: finish-start", "inward": "has to be done after", "outward": "has to be done before" }, "inwardIssue": { "id": "152573", "key": "TIMOB-19842", "fields": { "summary": "Android: CardView cardPreventCornerOverlap and cardUseCompatPadding should not start with card", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "50019", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "153581", "key": "TIMOB-20090", "fields": { "summary": "Android: Cardview doc requires changes", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "49897", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "152573", "key": "TIMOB-19842", "fields": { "summary": "Android: CardView cardPreventCornerOverlap and cardUseCompatPadding should not start with card", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "updated": "2015-12-03T02:15:05.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "The following sample shows that both {{backgroundColor}} and {{cardBackgroundColor}} work, but the one with {{backgroundColor}} doesn't show a border/corner radius. Because of TIMOB-19801 I cannot verify, but I guess when I would set both I would see a rectangle without radius behind one that has?\r\n\r\nIs there an actual use case to have both (working, if we resolve TIMOB-19801)? If so, then we need to document the difference. If not, then I'd say we rename {{cardBackgroundColor}} to {{backgroundColor}}.\r\n\r\n{code:javascript}\r\nvar win = Ti.UI.createWindow({\r\n\tlayout: 'vertical'\r\n});\r\n\r\nvar card1 = Ti.UI.Android.createCardView({\r\n\ttop: 20,\r\n\tleft: 20,\r\n\tright: 20,\r\n\tcontentPadding: 20,\r\n\r\n\tcardBackgroundColor: '#F00'\r\n});\r\n\r\ncard1.add(Ti.UI.createLabel({\r\n\ttext: 'cardBackgroundColor',\r\n\tcolor: '#000'\r\n}));\r\n\r\nwin.add(card1);\r\n\r\nvar card2 = Ti.UI.Android.createCardView({\r\n\ttop: 20,\r\n\tleft: 20,\r\n\tright: 20,\r\n\tcontentPadding: 20,\r\n\r\n\tbackgroundColor: '#F00'\r\n});\r\n\r\ncard2.add(Ti.UI.createLabel({\r\n\ttext: 'backgroundColor',\r\n\tcolor: '#000'\r\n}));\r\n\r\nwin.add(card2);\r\n\r\nwin.open();\r\n{code}\r\n\r\n*UPDATE:* I'm not convinced deviating from standard properties like [backgroundColor|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.View-property-backgroundColor], [borderRadius|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.View-property-borderRadius], [elevation|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.View-property-elevation] and [*Padding|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.TextField-property-paddingLeft].\r\n\r\n* *Pro:* Easier to translate what you read in the [Android reference|https://developer.android.com/reference/android/support/v7/widget/CardView.html] to your Titanium app.\r\n* *Con:* Titanium developers are used to our naming conventions throughout what is after all a cross-platform SDK, even for platform-specific components.\r\n\r\nGiven my experience that most Titanium developers do not read the target platform references but rely on our docs and - lazy as developers are - the predictability of our API I think we should:\r\n\r\n* Remove the {{card}} prefix from the CardView specific properties.\r\n* Rename {{(card)CornerRadius}} to {{borderRadius}}.\r\n* Remove the {{content}} prefix from the {{contentPadding*}} properties.", "attachment": [ { "id": "57150", "filename": "android_20151027-125702.png", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-10-27T12:05:27.000+0000", "size": 44848, "mimeType": "image/png" } ], "flagged": false, "summary": "Android: CardView should use standard property names", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": "SDK 5.1.0.v20151026164636", "closedSprints": [ { "id": 529, "state": "closed", "name": "2015 Sprint 24 SDK", "startDate": "2015-11-21T01:30:12.670Z", "endDate": "2015-12-05T01:30:00.000Z", "completeDate": "2015-12-07T03:57:17.094Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "368605", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "I see that right now we follow the [original API|https://developer.android.com/reference/android/support/v7/widget/CardView.html] exactly. I think that might be better indeed, but then we should make sure that {{backgroundColor}} is not there in the API reference or document the difference (use cases).", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-11-02T09:30:51.000+0000", "updated": "2015-11-02T09:30:51.000+0000" }, { "id": "370670", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2015-11-18T08:25:09.000+0000", "updated": "2015-11-18T08:25:09.000+0000" }, { "id": "370684", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Confirmed the PR fixes it.\r\n\r\nHowever, I'm not convinced deviating from standard properties like [backgroundColor|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.View-property-backgroundColor], [borderRadius|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.View-property-borderRadius], [elevation|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.View-property-elevation] and [*Padding|https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.TextField-property-paddingLeft].\r\n\r\n* *Pro:* Easier to translate what you read in the [Android reference|https://developer.android.com/reference/android/support/v7/widget/CardView.html] to your Titanium app.\r\n* *Con:* Titanium developers are used to our naming conventions throughout what is after all a cross-platform SDK, even for platform-specific components.\r\n\r\nGiven my experience that most Titanium developers do not read the target platform references but rely on our docs and - lazy as developers are - the predictability of our API I think we should:\r\n\r\n* Remove the {{card}} prefix from the CardView specific properties.\r\n* Rename {{(card)CornerRadius}} to {{borderRadius}}.\r\n* Remove the {{content}} prefix from the {{contentPadding*}} properties.", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-11-18T12:31:08.000+0000", "updated": "2015-11-18T12:31:08.000+0000" }, { "id": "370788", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "body": "I agree with your recommendations.", "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2015-11-19T05:31:36.000+0000", "updated": "2015-11-19T05:31:36.000+0000" }, { "id": "370802", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2015-11-19T09:02:12.000+0000", "updated": "2015-12-01T04:37:23.000+0000" }, { "id": "371753", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "body": "Master reviewed and merged.\r\n\r\nBackport 5_1_X https://github.com/appcelerator/titanium_mobile/pull/7518", "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2015-12-01T06:53:42.000+0000", "updated": "2015-12-01T06:53:53.000+0000" }, { "id": "371755", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "body": "Backport merged.", "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2015-12-01T07:12:30.000+0000", "updated": "2015-12-01T07:12:30.000+0000" }, { "id": "371968", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix.\r\nIf the properties with the prefix 'card' & 'content' are used we see depreciation warnings in the console along with suggestions for the new property names.\r\nAlso, the new property names works as expected.\r\ne.g:\r\n{code}\r\n[WARN] : TiUICardView: (main) [144,144] The cardBackgroundColor property is deprecated, use backgroundColor instead.\r\n[WARN] : TiUICardView: (main) [0,144] The cardCornerRadius property is deprecated, use borderRadius instead.\r\n[WARN] : TiUICardView: (main) [0,144] The cardElevation property is deprecated, use elevation instead.\r\n[WARN] : TiUICardView: (main) [0,144] The cardMaxElevation property is deprecated, use maxElevation instead.\r\n[WARN] : TiUICardView: (main) [0,144] The contentPadding property is deprecated, use padding instead.\r\n[WARN] : TiUICardView: (main) [2,146] The cardCornerRadius property is deprecated, use borderRadius instead.\r\n[WARN] : TiUICardView: (main) [0,146] The contentPaddingBottom property is deprecated, use paddingBottom instead.\r\n[WARN] : TiUICardView: (main) [0,146] The contentPaddingLeft property is deprecated, use paddingLeft instead.\r\n[WARN] : TiUICardView: (main) [0,146] The contentPaddingRight property is deprecated, use paddingRight instead.\r\n[WARN] : TiUICardView: (main) [0,146] The contentPaddingTop property is deprecated, use paddingTop instead.\r\n{code}\r\n\r\nClosing.\r\n\r\nEnvironment:\r\nAppc Studio : 4.4.0.201511241829\r\nTi SDK : 5.1.2.v20151202061227\r\nTi CLI : 5.0.5\r\nAlloy : 1.7.26\r\nMAC Yosemite : 10.10.5\r\nAppc NPM : 4.2.2\r\nAppc CLI : 5.1.0\r\nNode: v0.12.27\r\nNexus 6P - Android 6.0", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-12-02T22:54:35.000+0000", "updated": "2015-12-02T22:57:34.000+0000" }, { "id": "371970", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Reopening to edit comment", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-12-02T22:56:55.000+0000", "updated": "2015-12-02T22:56:55.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }