{ "id": "153025", "key": "TIMOB-19939", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16997", "name": "Release 5.2.0", "archived": false, "released": true, "releaseDate": "2016-02-23" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2015-11-24T19:24:24.000+0000", "created": "2015-11-12T13:15:16.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "qe-5.2.0" ], "versions": [], "issuelinks": [ { "id": "49962", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "153231", "key": "TIMOB-20000", "fields": { "summary": "Rename appearance properties to keyboardAppearance", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2016-01-22T00:42:51.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "The different places where we have the {{keyboardType}} property all list the two {{KEYBOARD_APPEARANCE_*}} constants as valid values, although these are only valid for the {{appearance}} property.\r\n\r\n* http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.TextField-property-keyboardType\r\n* http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.TextArea-property-keyboardType\r\n* http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.AlertDialog-property-keyboardType\r\n* http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.AlertDialog-property-loginKeyboardType\r\n* http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.AlertDialog-property-passwordKeyboardType\r\n\r\nThis is because in the YML's we use {{KEYBOARD_*}} wildcards:\r\nhttps://github.com/appcelerator/titanium_mobile/search?q=KEYBOARD_*\r\n\r\nUnless we can make exceptions we should either:\r\n\r\n# List each of them manually\r\n# Rename the constants for {{keyboardType}} to {{KEYBOARD_TYPE_*}}\r\n\r\nI'm for the second option; deprecate in next 5.x and remove the old in 6.0.\r\nThat's why I've created this ticket in TIMOB instead of TIDOC.", "attachment": [], "flagged": false, "summary": "keyboardType should not list KEYBOARD_APPEARANCE_* constants", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": null, "closedSprints": [ { "id": 529, "state": "closed", "name": "2015 Sprint 24 SDK", "startDate": "2015-11-21T01:30:12.670Z", "endDate": "2015-12-05T01:30:00.000Z", "completeDate": "2015-12-07T03:57:17.094Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "370565", "author": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR pending https://github.com/appcelerator/titanium_mobile/pull/7459/files \r\n\r\nDemo Code:\r\n{code}\r\nTi.UI.setBackgroundColor('white');\r\nvar win = Ti.UI.createWindow({\r\n title: 'Click window to test'\r\n});\r\n\r\nvar field = Ti.UI.createTextArea({\r\n width : 300,\r\n height : 50,\r\n top : 200,\r\n right : 0 ,\r\n backgroundColor : \"#f0f0f0\",\r\n value : \"Hello\",\r\n keyboardType : Titanium.UI.KEYBOARD_ASCII,\r\n appearance: Titanium.UI.KEYBOARD_APPEARANCE_LIGHT,\r\n});\r\n\r\n\r\n var textField = Ti.UI.createTextField({\r\n borderStyle : Ti.UI.INPUT_BORDERSTYLE_ROUNDED,\r\n color : '#336699',\r\n top : 100, \r\n right : 0,\r\n width : 250, \r\n height : 60,\r\n backgroundColor :'Green',\r\n keyboardType : Titanium.UI.KEYBOARD_TWITTER,\r\n appearance : Titanium.UI.KEYBOARD_APPEARANCE_DARK\r\n});\r\n\r\nvar search = Titanium.UI.createSearchBar({\r\n barColor :'#000', \r\n showCancel :true,\r\n height :43,\r\n top :20,\r\n left :0,\r\n keyboardType : Titanium.UI.KEYBOARD_TYPE_URL,\r\n keyboardAppearance : Titanium.UI.KEYBOARD_APPEARANCE_DARK\r\n});\r\nfield.autocorrect = false;\r\n\r\nwin.add(textField);\r\nwin.add(field);\r\nwin.add(search);\r\nwin.open();\r\n{code}\r\n\r\nExpected Results : A warning stating that keyboard_twitter and keyboard_ASCII is deprecated. \r\n A warning stating that appearance is deprecated in favor of keyboardApperance.", "updateAuthor": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2015-11-17T20:08:50.000+0000", "updated": "2015-11-24T18:46:57.000+0000" }, { "id": "371365", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "CR + FT passed. The following logs appear as supposed to:\r\n{code}\r\n[WARN] Titanium.UI.KEYBOARD_ASCII DEPRECATED in 5.2.0, in favor of UI.KEYBOARD_TYPE_ASCII.\r\n[WARN] Titanium.UI.KEYBOARD_TWITTER DEPRECATED in 5.2.0, in favor of UI.KEYBOARD_TYPE_TWITTER.\r\n[WARN] Titanium.UI.TextField.appearance DEPRECATED in 5.2.0, in favor of UI.TextField.keyboardAppearance.\r\n[WARN] Titanium.UI.TextArea.appearance DEPRECATED in 5.2.0, in favor of UI.TextArea.keyboardAppearance.\r\n{code}\r\nPR approved!", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2015-11-24T19:05:36.000+0000", "updated": "2015-11-24T19:05:36.000+0000" }, { "id": "374890", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "Verified as fixed, with SDK {{5.2.0.v20160114021251}} Receive DEPRECATED warning messages in console as per the expected results.\r\nTested on:\r\niPhone 6s Plus Device (9.2)\r\nMac OSX El Capitan 10.11 (15A284)\r\nTi SDK: 5.2.0.v20160114021251\r\nAppc NPM: 4.2.2 \r\nApp CLI: 5.2.0-220 \r\nXcode 7.2\r\nNode v4.2.3\r\nClosing Ticket.", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2016-01-20T00:29:59.000+0000", "updated": "2016-01-20T00:29:59.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }