{ "id": "153074", "key": "TIMOB-19968", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16997", "name": "Release 5.2.0", "archived": false, "released": true, "releaseDate": "2016-02-23" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2015-12-09T05:51:41.000+0000", "created": "2015-11-13T10:05:20.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [ "appthinning" ], "versions": [ { "id": "14826", "description": "Release 5.1.0-remaining iOS9 features, Android M features", "name": "Release 5.1.0", "archived": false, "released": true, "releaseDate": "2015-11-20" } ], "issuelinks": [], "assignee": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "updated": "2016-02-18T23:54:41.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "Switching the {{use-app-thinning}} setting in {{tiapp.xml}} does not force a rebuild. If you enable it, image assets catalogs *will* be added, but the images not removed. If you disable it, the images *will* be added, but the image asset catalogs not be removed.\r\n\r\nCode:\r\nhttps://github.com/appcelerator/titanium_mobile/blob/6e66f239d1ffeebd1448658b69e3a189b81b2828/iphone/cli/commands/_build.js#L2345-L2359", "attachment": [], "flagged": false, "summary": "Changing use-app-thinning does not force rebuild", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": "SDK 5.1.0.RC (5.1.0.v20151104190037)", "closedSprints": [ { "id": 531, "state": "closed", "name": "2015 Sprint 23 Tooling", "startDate": "2015-11-10T23:44:28.164Z", "endDate": "2015-11-21T02:44:00.000Z", "completeDate": "2015-11-23T20:21:44.795Z", "originBoardId": 121 }, { "id": 534, "state": "closed", "name": "2015 Sprint 24 Tooling", "startDate": "2015-11-23T20:23:31.316Z", "endDate": "2015-12-05T02:23:00.000Z", "completeDate": "2015-12-07T18:44:25.555Z", "originBoardId": 121 }, { "id": 538, "state": "closed", "name": "2015 Sprint 25 Tooling", "startDate": "2015-12-07T18:48:43.028Z", "endDate": "2015-12-19T03:48:00.000Z", "completeDate": "2016-01-04T19:45:31.946Z", "originBoardId": 121 } ], "comment": { "comments": [ { "id": "370196", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "[~cbarber] Why not just force a rebuild if {{tiapp.xml}} has been changed, since in 90% of the cases this is required anyway. Saves us checking a lot of stuff.", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-11-13T10:06:07.000+0000", "updated": "2015-11-13T10:06:07.000+0000" }, { "id": "370206", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "[~fokkezb] Good find, but I snuck the fix into https://github.com/appcelerator/titanium_mobile/pull/7412/files#diff-f430483233aa01af5b10df8390f9635dR2392 which is still waiting to be merged. :)\r\n\r\nAs far as always rebuilding whenever the {{tiapp.xml}} is changed, I think don't think that's a good idea. There are a number of things in the {{tiapp.xml}} that do not trigger a rebuild. What if they modify the Android section? Furthermore, things like description, publisher, and URL should be put in a plain text file (that could be encrypted) instead of the {{main.m}}, thus eliminating the need to run {{xcodebuild}}.", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2015-11-13T15:26:47.000+0000", "updated": "2015-11-13T15:26:47.000+0000" }, { "id": "370226", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Haha, sneaky!\r\n\r\nMy thought about it is this... as a developer I need fast, incremental builds when I'm writing JavaScript/Alloy code. Expanding my app, fixing bugs etc. When I make changes to {{tiapp.xml}} - and probably {{platform}} as well - I'm in a different mode in which I prefer accuracy over speed. So if we can simplify the build process and by doing so make it more reliable (now, but also as we add stuff and maybe forget to update these checks) then I'd go for that.", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2015-11-13T18:53:56.000+0000", "updated": "2015-11-13T18:53:56.000+0000" }, { "id": "370242", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Still not convinced. Platform engineers will need to be more careful in the future.", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2015-11-13T20:08:05.000+0000", "updated": "2015-11-13T20:08:05.000+0000" }, { "id": "371394", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Please remember to resolve this ticket as soon as TIMOB-19694 is resolved.", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2015-11-24T21:58:36.000+0000", "updated": "2015-11-24T21:58:36.000+0000" }, { "id": "372493", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Resolving ticket. Follow the description to test.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2015-12-09T05:51:17.000+0000", "updated": "2015-12-09T05:51:17.000+0000" }, { "id": "377302", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified fixed, using:\r\n\r\nMacOS 10.11.3 (15D21)\r\nStudio 4.5.0.201602170821\r\nTi SDK 5.2.0.v20160216202526\r\nAppc NPM 4.2.3-2\r\nAppc CLI 5.2.0-269\r\nAlloy 1.7.33\r\nXcode 7.2 (7C68)\r\n\r\nToggling the {{}} setting in the tiapp.xml now forces a rebuild. Tested with a default app and performing multiple builds with the setting toggled after every other build.", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-18T23:54:41.000+0000", "updated": "2016-02-18T23:54:41.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }