{ "id": "153557", "key": "TIMOB-20083", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16980", "description": "New V8", "name": "Release 6.0.0", "archived": false, "released": true, "releaseDate": "2016-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-07-12T03:31:30.000+0000", "created": "2015-12-02T07:57:22.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "breaking-change", "notable", "watch" ], "versions": [ { "id": "17532", "name": "Release 5.1.1", "archived": false, "released": true, "releaseDate": "2015-11-24" } ], "issuelinks": [ { "id": "50011", "type": { "id": "10120", "name": "Gantt: finish-start", "inward": "has to be done after", "outward": "has to be done before" }, "inwardIssue": { "id": "150916", "key": "TIMOB-19455", "fields": { "summary": "Add Swift versions of the applewatch templates", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } } ], "assignee": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "updated": "2018-08-06T17:49:32.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" }, { "id": "10207", "name": "Tooling" } ], "description": "After TIMOB-19455 adds a {{watchos2-swift}} template and defaults to it we should remove the {{watchos1}} template and the related code in the build script.\r\n\r\n*cli/lib/creators/applewatch.js*\r\n\r\n* Remove the check for watchos1: https://github.com/FokkeZB/titanium_mobile/blob/TIMOB-19455/cli/lib/creators/applewatch.js#L220-L223\r\n\r\n*iphone/cli/commands/_build.js*\r\n\r\n* An check should be added to fail if if the extension is V1.\r\n* All usage of {{hasWatchAppV1}}, {{hasWatchAppV2orNewer}}, {{isWatchAppV1Extension}}, {{isWatchAppV1}}, {{isWatchAppV2orNewer}} should be changed to assume V2 or newer.\r\n\r\n*templates/applewatch/watchos1/template*\r\n\r\n* Should be removed", "attachment": [], "flagged": false, "summary": "Remove watchos1 template and related code", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": null, "closedSprints": [ { "id": 679, "state": "closed", "name": "2016 Sprint 14 Tooling", "startDate": "2016-07-02T00:26:00.079Z", "endDate": "2016-07-16T00:26:00.000Z", "completeDate": "2016-07-18T03:19:39.426Z", "originBoardId": 199 }, { "id": 555, "state": "closed", "name": "2016 Sprint 1 SDK", "startDate": "2016-01-02T01:31:50.127Z", "endDate": "2016-01-16T01:31:00.000Z", "completeDate": "2016-01-18T00:52:43.848Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "373858", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/7611\r\n\r\nFunctional Test:\r\n1. Build a project without watchOS apps\r\n2. Build should succeed.\r\n3. Build a project that has a watchOS 1 app\r\n4. Build should terminate with following error message:\r\n{code}\r\n[ERROR] watchOS 1 app detected\r\n[ERROR] Titanium 6.0.0 does not support watchOS 1 apps\r\n{code}\r\n5. Build a project that has a watchOS 2 app\r\n6. Build should succeed.", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2016-01-05T23:16:55.000+0000", "updated": "2016-01-05T23:23:49.000+0000" }, { "id": "373876", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "CR and FT Passed. \r\nQuestion:\r\nShould we warn or fail already on step 3 when calling *appc new -t applewatch --template watchos1*? instead of having the dev disappointed later at step 4.? [~fokkezb] thoughts?", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-01-06T04:32:05.000+0000", "updated": "2016-01-06T04:32:05.000+0000" }, { "id": "373890", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "[~cng] won't it already fail if you use a template name that no longer exists?", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-01-06T08:15:35.000+0000", "updated": "2016-01-06T08:15:35.000+0000" }, { "id": "373892", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~fokkezb] oh ya, you are quite right. So this PR FT failed.\r\nh4. Expected behavior\r\nStep 3 should fail and say the template doesn't exist.\r\n\r\nh4. Actual behavior\r\nPR still allowed me to generate the extension/", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-01-06T08:23:43.000+0000", "updated": "2016-01-06T08:23:43.000+0000" }, { "id": "373894", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Well, then thats a separate bug which should also happen if you do {{appc new -t applewatch --template foo}}", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-01-06T08:28:15.000+0000", "updated": "2016-01-06T08:28:15.000+0000" }, { "id": "373910", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "The CLI should be already handling non-existent template.\r\nAlso, this is the error message I get.\r\n{code}\r\n// appc new -t applewatch --template watchos1\r\n[ERROR] Unable to find template \"watchos1\"\r\n[ERROR] Failed to create project after 4ms\r\n\r\n// appc new -t applewatch --template foo\r\n[ERROR] Unable to find template \"foo\"\r\n[ERROR] Failed to create project after 5ms\r\n{code}", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2016-01-06T17:27:11.000+0000", "updated": "2016-01-06T17:27:11.000+0000" }, { "id": "373963", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "I see. must be because i overwrote an existing sdk version which already had that template in place. let me clean that directory, reinstall sdk that has your code, and test again.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-01-07T00:00:03.000+0000", "updated": "2016-01-07T00:00:03.000+0000" }, { "id": "373971", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "OK PR Approved and merged!", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-01-07T03:21:51.000+0000", "updated": "2016-01-07T03:21:51.000+0000" }, { "id": "377084", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "As discussed, this should be in 6.0 not 5.4 because it breaks when you build an existing Titanium app with a watchos1 extension.\r\n\r\n/cc [~cng]", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-17T08:29:41.000+0000", "updated": "2016-02-17T08:29:41.000+0000" }, { "id": "377086", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~fmiao] I'll need this PR that was merged, to be reverted on master. Thanks.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-17T08:35:45.000+0000", "updated": "2016-02-17T08:35:45.000+0000" }, { "id": "377089", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Ideally we could split it up:\r\n\r\n5.4: Remove the create support (the watchos1 template itself and the check for watchos1 in cli/lib/creators/applewatch.js)\r\n6.0: Remove the build support in iphone/cli/commands/_build.js", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-17T08:42:20.000+0000", "updated": "2016-02-17T08:42:20.000+0000" }, { "id": "377093", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Agreed with Fokke. [~fmiao] can you PR to re-insert build support in iphone/cli/commands/_build.js on master branch?", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-17T09:40:52.000+0000", "updated": "2016-02-17T09:40:52.000+0000" }, { "id": "377187", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~bimmel] Worthwhile mention on release notes as Fokke has described:\r\n5.4.0: Developers cannot create watch apps using watchos1 templates\r\n6.0.0: Developers who has watchos1 watch apps will fail to build. (no longer support watchos1)\r\n\r\n[~fmiao] we can merge the PR to re-insert build support for watchos1, but don't resolve this ticket until we remove it again in 6.0.0.\r\nThis ticket will remain open until 6.0.0 release.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-18T07:44:06.000+0000", "updated": "2016-02-18T07:44:06.000+0000" }, { "id": "377300", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/7757\r\n\r\nIt would be alot easier if we have a branch for 5_4_X.", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2016-02-18T22:48:23.000+0000", "updated": "2016-02-18T22:49:15.000+0000" }, { "id": "377301", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Just so everybody is clear, we MUST always leave the WatchOS1 extension detection code in the iOS build even after WatchOS1 is dead and gone.\r\n\r\nSecond, we MUST display a deprecation warning when building an app with a WatchOS1 extension. We should sneak this deprecation warning in ASAP.\r\n\r\nThird, when we do end up dropping support for WatchOS1 extensions, the iOS build must emit a fatal error and exit when a WatchOS1 extension is detected.", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2016-02-18T23:03:27.000+0000", "updated": "2016-02-18T23:03:27.000+0000" }, { "id": "377321", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PR merged.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-19T04:06:25.000+0000", "updated": "2016-02-19T04:06:25.000+0000" }, { "id": "377338", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "[~cbarber] agree, [~fmiao] can you make sure we keep what for 6.0 will be the fatal error in your PR for 5.4, but then as deprecation warning (without the exit)?\r\n\r\nhttps://github.com/appcelerator/titanium_mobile/pull/7757/files#diff-f430483233aa01af5b10df8390f9635dL1491", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-19T07:33:19.000+0000", "updated": "2016-02-19T07:33:19.000+0000" }, { "id": "390399", "author": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/8123", "updateAuthor": { "name": "fmiao", "key": "fmiao", "displayName": "Feon Sua Xin Miao", "active": true, "timeZone": "America/Vancouver" }, "created": "2016-07-11T23:03:42.000+0000", "updated": "2016-07-11T23:03:42.000+0000" }, { "id": "390422", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "APPROVED.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-07-12T03:31:20.000+0000", "updated": "2016-07-12T03:31:20.000+0000" }, { "id": "440213", "author": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.", "updateAuthor": { "name": "emerriman", "key": "emerriman", "displayName": "Eric Merriman ", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-08-06T17:49:32.000+0000", "updated": "2018-08-06T17:49:32.000+0000" } ], "maxResults": 20, "total": 20, "startAt": 0 } } }