{ "id": "154519", "key": "TIMOB-20274", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19101", "name": "Hyperloop 2.1.0", "archived": false, "released": true, "releaseDate": "2017-04-28" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-04-08T08:41:50.000+0000", "created": "2016-01-26T21:39:19.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [], "versions": [], "issuelinks": [ { "id": "54833", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "167467", "key": "TIMOB-24661", "fields": { "summary": "iOS: Hyperloop: keys[num].indexOf is not a function with a module", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2017-05-05T13:05:30.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "13715", "name": "Hyperloop", "description": "Hyperloop project" } ], "description": "As found by [~developer82] and reported on [Stack Overflow|http://stackoverflow.com/questions/34999704/hyperloop-compilation-error] the Hyperloop plugin fails when the source of the app does not actually use Hyperloop. It will crash with:\r\n\r\n{code}\r\n[INFO] Skipping Hyperloop compile, no usage found …\r\n[TRACE] Symbol references up-to-date\r\n[DEBUG] Skipping stub generation\r\n\r\n/Users/fokkezb/dev/tests/nohl/plugins/hyperloop/hooks/ios/hyperloop.js:581\r\n\t\treturn callback();\r\n ^\r\nReferenceError: callback is not defined\r\n{code}\r\n\r\nPR incoming", "attachment": [], "flagged": false, "summary": "Hyperloop: Plugin fails if the source does not contain HL references", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": "Hyperloop plugin 1.1.0", "closedSprints": [ { "id": 565, "state": "closed", "name": "2016 Sprint 2 SDK", "startDate": "2016-01-16T01:30:40.264Z", "endDate": "2016-01-30T01:30:00.000Z", "completeDate": "2016-01-31T01:27:07.537Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "375320", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "PR on master: https://github.com/appcelerator/hyperloop.next/pull/3", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-01-26T21:40:08.000+0000", "updated": "2016-01-26T21:40:08.000+0000" }, { "id": "378068", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Reopening this issue, since it would break default hyperloop-based projects using hyperloop.next master. Please validate [~fokkezb], it might be related to leaving out [this|https://github.com/appcelerator/hyperloop.next/pull/3/files#diff-885c43ae7ca7944399f2103332eb9419L669] line.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-02-28T13:41:55.000+0000", "updated": "2016-02-28T13:42:24.000+0000" }, { "id": "378118", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Thanks [~hansknoechel], my fix mixed up async and async style\r\n\r\nFix: https://github.com/appcelerator/hyperloop.next/pull/5", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-29T07:34:06.000+0000", "updated": "2016-02-29T07:34:53.000+0000" }, { "id": "378127", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Approved, now working as expected! [~cng] The fix-version is 5.2.1, does this relate to the SDK or just for the QE to test?", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-02-29T08:28:46.000+0000", "updated": "2016-02-29T08:28:46.000+0000" }, { "id": "378128", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "A bit of both actually. but since hyper loop hasn't graduated from labs, I don't think QE has a test plan for this. So I'll remove the fixVersion for now til hyper loop becomes GA.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-29T08:39:00.000+0000", "updated": "2016-02-29T08:39:00.000+0000" }, { "id": "390737", "author": { "name": "wluu", "key": "wluu", "displayName": "Wilson Luu", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Closing ticket as fixed. Verified that you can build a mobile project without any reference to Hyperloop, even though it's enabled for your project.\r\n\r\nTested on:\r\n\r\nAppcelerator Studio, build: 4.7.0.201607130543\r\nAppc CLI NPM: 4.2.7\r\nAppc CLI Core: 5.4.0-33\r\nArrow: 1.8.2\r\nSDK: 5.4.0.v20160713141635\r\nHyperloop: 1.2.3\r\nNode: v4.4.7\r\nOS: Mac OS X (10.11.5)\r\nXcode: 7.3.1\r\nDevices: iphone 6 plus (9.1)\r\n", "updateAuthor": { "name": "wluu", "key": "wluu", "displayName": "Wilson Luu", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-07-14T21:51:35.000+0000", "updated": "2016-07-14T21:52:31.000+0000" }, { "id": "416072", "author": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "body": "[~hansknoechel] -- I know this is marked as closed but we started seeing this 2.0.1 for a few different apps. The same apps did not have any problems when running 2.0.0. Unfortunately, it seems to happen randomly with no changes to the app. The only way to be sure it doesn't crash is to comment out the hyperloop references in tiapp.xml.\r\n\r\n\r\n{noformat}\r\n[DEBUG] Removing empty directories\r\n[INFO] Starting Hyperloop assembly\r\n[INFO] Skipping Hyperloop compile, no usage found ...\r\n[TRACE] Forcing regeneration of wrappers\r\n[DEBUG] Generating stubs\r\n2017-03-28T21:45:09.325Z | ERROR | An uncaught exception was thrown!\r\nCannot convert undefined or null to object\r\n2017-03-28T21:45:09.326Z | ERROR | Cannot convert undefined or null to object\r\nBrentons-MacBook-Pro:titanium-template brenton$ clear && npm run build:ios\r\n{noformat}\r\n", "updateAuthor": { "name": "brentonhouse", "key": "brentonhouse", "displayName": "Brenton House", "active": true, "timeZone": "America/Chicago" }, "created": "2017-03-28T22:03:45.000+0000", "updated": "2017-03-28T22:03:45.000+0000" }, { "id": "416195", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~brentonhouse] I also encounter this with Hyperloop 2.0.1 and will be investigating it further. The error better matches AC-703, which was marked as a duplicate of this issue.", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-03-29T17:15:10.000+0000", "updated": "2017-03-29T17:15:10.000+0000" }, { "id": "416877", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Encountered this again during smoke tests. As mentioned, adding Hyperloop references or removing the module allows the project to build. [~hansknoechel], have you encountered this since its closing?", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-04-05T21:10:48.000+0000", "updated": "2017-04-05T21:10:48.000+0000" }, { "id": "417065", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "[~ewieber], this is indeed a regression in 2.0.1. This PR will prevent the error by stopping the Hyperloop compile process early if no usage found, so that the following steps won't be run with incomplete data which caused the error in this case.\r\n\r\nPR (master): https://github.com/appcelerator/hyperloop.next/pull/145\r\nPR (2_0_X): https://github.com/appcelerator/hyperloop.next/pull/146", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-04-07T20:50:14.000+0000", "updated": "2017-04-07T21:01:31.000+0000" }, { "id": "417541", "author": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified fix with the following environment:\r\nNode Version: 6.10.1\r\nNPM Version: 3.10.10\r\nMac OS: 10.12.4\r\nAppc CLI: 6.2.0\r\nAppc CLI NPM: 4.2.9\r\nTitanium SDK version: 6.0.3.GA\r\nAppcelerator Studio, build: 4.8.1.201612050850\r\nXcode 8.2.1\r\nHyperloop 2.1.0\r\niOS 10, and Android 6.0\r\n\r\nBuilt to simulator/emulator and device, and found no errors for hyperloop-enabled apps with no hyperloop references.", "updateAuthor": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-04-17T23:51:32.000+0000", "updated": "2017-04-17T23:51:32.000+0000" } ], "maxResults": 11, "total": 11, "startAt": 0 } } }