{ "id": "154927", "key": "TIMOB-20405", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17684", "name": "Release 5.2.1", "archived": false, "released": true, "releaseDate": "2016-03-25" }, { "id": "17706", "name": "Release 5.4.0", "archived": false, "released": true, "releaseDate": "2016-08-11" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-02-19T03:48:31.000+0000", "created": "2016-02-15T14:12:17.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [], "versions": [ { "id": "16997", "name": "Release 5.2.0", "archived": false, "released": true, "releaseDate": "2016-02-23" } ], "issuelinks": [ { "id": "50587", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "144214", "key": "TIMOB-18515", "fields": { "summary": "iOS: TabGroup - Support UIEdgeInsets for Tab items so we can have Instagram-like tabs with only images", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } } ], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2016-03-01T23:31:13.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "Using the new property introduced by TIMOB-18515 you get strange behaviour when you play with {{iconSets}} to not only reposition but also enlarge the icon:\r\n\r\n{code}\r\n\"Tab\": {\r\n iconInsets: {\r\n top: 2,\r\n right: -4,\r\n bottom: -10,\r\n left: -4\r\n }\r\n}\r\n{code}\r\n\r\nThe icon resizes when you select/unselect the tab. And when you repeatedly tap on the icon it will continue to grow. See the attached video. While the behavior is native, we should only allow the {{top}} and {{left}} property to calculate the negative {{bottom}} and {{right}} automatically.", "attachment": [ { "id": "58239", "filename": "insets.mov", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-15T14:12:09.000+0000", "size": 359672, "mimeType": "video/quicktime" } ], "flagged": false, "summary": "iconInsets: Weird behaviour when not repositioning but also enlarging icon", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": "SDK 5.2.0", "closedSprints": [ { "id": 574, "state": "closed", "name": "2016 Sprint 4 SDK", "startDate": "2016-02-13T01:33:48.415Z", "endDate": "2016-02-27T01:33:00.000Z", "completeDate": "2016-02-29T03:44:48.886Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "376922", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "If it is only meant to be used to reposition we should expose only top and left and calculate bottom and right. (negative of their counterparts).", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-15T14:15:08.000+0000", "updated": "2016-02-15T14:15:08.000+0000" }, { "id": "376927", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Just created a native demo project, it's a native behavior: https://www.dropbox.com/s/bvqi8ro5a7muplo/Native.mov?dl=0\r\n\r\nWhat we can do (and [~cng] suggested) is to update the docs and link to the Apple docs to ensure people don't set \"bad\" values. Or (what [~fokkezb] suggested) to handle it internally. What's the best solution? I would stick to the native behavior if possible. Calculating stuff internally can always cause more trouble.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-02-15T18:52:22.000+0000", "updated": "2016-02-15T18:52:22.000+0000" }, { "id": "376948", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "Let's just remove right and bottom and calculate those as the negative of what you set to left and top. That way you can still off-center it any way you like but not stretch and get strange behavior.\r\n\r\nWe could do this in 5.2.1 since it would not break anything.", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-02-16T08:12:01.000+0000", "updated": "2016-02-16T08:12:01.000+0000" }, { "id": "377016", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/7742\r\nDemo: \r\n{code:javascript}\r\nTitanium.UI.setBackgroundColor('#fff');\r\nvar tabGroup = Titanium.UI.createTabGroup();\r\n\r\nvar win1 = Titanium.UI.createWindow();\r\nvar tab1 = Titanium.UI.createTab({\r\n\twindow: win1,\r\n\ticon:'images/tabs/KS_nav_ui.png',\r\n\ticonInsets: {\r\n\t\ttop: 6\r\n\t}\r\n});\r\n\r\nvar win2 = Titanium.UI.createWindow();\r\nvar tab2 = Titanium.UI.createTab({\r\n\twindow: win2,\r\n\ticon:'images/tabs/KS_nav_ui.png',\r\n\ttitle: \"Test\"\r\n});\r\n\r\ntabGroup.addTab(tab1);\r\ntabGroup.addTab(tab2);\r\n\r\ntabGroup.open();\r\n{code}\r\n\r\nYou guys decide if it's 5.2.1 or 5.4.0 :-)", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-02-16T21:40:13.000+0000", "updated": "2016-02-16T21:41:53.000+0000" }, { "id": "377320", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "PR Merged!", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-02-19T03:48:24.000+0000", "updated": "2016-02-19T03:48:24.000+0000" }, { "id": "377611", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "5.2.1 backport: https://github.com/appcelerator/titanium_mobile/pull/7769", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-02-23T07:39:23.000+0000", "updated": "2016-02-23T07:39:23.000+0000" }, { "id": "378389", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified fixed, using:\r\n\r\nMacOS 10.11.3 (15D21)\r\nStudio 4.5.0.201602170821\r\nTi SDK 5.2.1.v20160228190750\r\nAppc NPM 4.2.3\r\nAppc CLI 5.2.0\r\nAlloy 1.7.33\r\nXcode 7.2 (7C68)\r\n\r\nIcons no longer change size when tapping on them multiple times, with the iconInsets property set. Tested using the provided code and modifying the two-tab sample project.", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-03-01T23:31:13.000+0000", "updated": "2016-03-01T23:31:13.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }