{ "id": "159422", "key": "TIMOB-23175", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17706", "name": "Release 5.4.0", "archived": false, "released": true, "releaseDate": "2016-08-11" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-04-11T04:52:49.000+0000", "created": "2016-04-08T14:12:07.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [], "versions": [ { "id": "17993", "description": "Release 5.2.2", "name": "Release 5.2.2", "archived": false, "released": true, "releaseDate": "2016-04-05" } ], "issuelinks": [], "assignee": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "updated": "2016-05-26T19:47:49.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" }, { "id": "10207", "name": "Tooling" } ], "description": "I'm using SDK 5.2.2.GA which is [known to work|https://github.com/appcelerator/titanium_mobile/blob/5_2_X/android/package.json#L20] with {{>=17 <23.x}}.\r\n\r\nI'm using Android Build Tools 23.0.0 so as expected I get a warning when I run {{ti info -t android}}.\r\n\r\nBut, for some reason we [replace|https://github.com/appcelerator/titanium_mobile/blob/master/node_modules/titanium-sdk/lib/android.js#L445] {{<}} with {{<=}} so the warning is:\r\n\r\n{code}\r\nAndroid Issues\r\n !\r\n Android Build Tools 23.0.0 are too new and may or may not work with Titanium.\r\n If you encounter problems, select a supported version with:\r\n ti config android.buildTools.selectedVersion ##.##.##\r\n where ##.##.## is a version in /users/fokkezb/Library/Android/sdk/build-tools that is <=23.x\r\n{code}\r\n\r\nThis is confusing since the version I have meets {{<=23.x}}.\r\n\r\nWe should not replace {{<}} with {{<=}}.", "attachment": [], "flagged": false, "summary": "Warning \"Android Build Tools X are too new\" should not replace < with <=", "creator": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "subtasks": [], "reporter": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "environment": null, "closedSprints": [ { "id": 625, "state": "closed", "name": "2016 Sprint 09 Tooling", "startDate": "2016-04-23T00:30:12.823Z", "endDate": "2016-05-07T00:30:00.000Z", "completeDate": "2016-05-09T03:55:41.390Z", "originBoardId": 121 } ], "comment": { "comments": [ { "id": "382274", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Agreed. If we use {{<=}}, then https://github.com/appcelerator/titanium_mobile/blame/master/node_modules/titanium-sdk/lib/android.js#L827 would say the tools are supported and the error wouldn't show.", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2016-04-11T03:46:56.000+0000", "updated": "2016-04-11T03:46:56.000+0000" }, { "id": "382276", "author": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/7931 \r\n[~cbarber] for your review", "updateAuthor": { "name": "msamah", "key": "msamah", "displayName": "Ashraf Abu", "active": false, "timeZone": "Asia/Singapore" }, "created": "2016-04-11T04:20:36.000+0000", "updated": "2016-04-11T04:20:36.000+0000" }, { "id": "382299", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "With https://github.com/appcelerator/titanium_mobile/pull/7931 and https://github.com/appcelerator/titanium_mobile/blob/master/node_modules/titanium-sdk/lib/android.js#L445 you will now get {{<<=23.x}} in the message.\r\n\r\nWhy don't we just the message to use the {{maxSupported}} without change:\r\n\r\n{code:js}\r\n__('\\n where ##.##.## is a version in ') + results.sdk.buildTools.path.split('/').slice(0,-1).join('/') + __(' that meets ') + results.sdk.buildTools.maxSupported\r\n{code}", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-04-11T09:01:00.000+0000", "updated": "2016-04-11T09:01:17.000+0000" }, { "id": "382327", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Fixed verbiage:\r\nMaster PR: https://github.com/appcelerator/titanium_mobile/pull/7932\r\n5_3_X PR: https://github.com/appcelerator/titanium_mobile/pull/7933", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2016-04-11T15:12:35.000+0000", "updated": "2016-04-11T15:12:35.000+0000" }, { "id": "382332", "author": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "body": "exactly ;)", "updateAuthor": { "name": "fokkezb", "key": "fokke", "displayName": "Fokke Zandbergen", "active": true, "timeZone": "Europe/Amsterdam" }, "created": "2016-04-11T16:29:45.000+0000", "updated": "2016-04-11T16:29:45.000+0000" }, { "id": "386940", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix.\r\n\r\nClosing.\r\n\r\nEnvironment:\r\nAppc Studio : 4.6.0.201605180604\r\nTi SDK : 5.3.0.v20160523083840, 5.4.0.v20160526011354\r\nTi CLI : 5.0.8\r\nAlloy : 1.8.7\r\nMAC El Capitan : 10.11.4\r\nAppc NPM : 4.2.5-5\r\nAppc CLI : 5.3.0-47\r\nNode: 4.2.2\r\n", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2016-05-26T19:47:37.000+0000", "updated": "2016-05-26T19:47:37.000+0000" } ], "maxResults": 6, "total": 6, "startAt": 0 } } }