{ "id": "159493", "key": "TIMOB-23193", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17608", "name": "Release 6.1.0", "archived": false, "released": true, "releaseDate": "2017-05-26" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-09-15T17:38:40.000+0000", "created": "2016-04-12T04:26:27.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "qe-5.3.0" ], "versions": [ { "id": "17707", "name": "Release 5.3.0", "archived": false, "released": true, "releaseDate": "2016-06-04" } ], "issuelinks": [ { "id": "52711", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "163165", "key": "TISTUD-8591", "fields": { "summary": "Windows: Move to new build options for windows sdk and cert", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "52371", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "162520", "key": "TIMOB-23760", "fields": { "summary": "Windows: --wp-sdk option should handle actual Windows SDK versions", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2017-05-19T22:08:46.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "h5.Description\r\n\r\nCurrently in the CLI we have a couple of options that are target specific in their naming, namely *\\--wp-sdk* and *\\--ws-cert*, these options should become target agnostic in their naming as the usage has changed with the introduction of support for Windows 10 and they are no longer specific to a certain target, for example --wp-sdk can be used to change the SDK for a ws-local build, and a cert can be passed into a phone build", "attachment": [], "flagged": false, "summary": "Windows: Change target specific build options into target agnostic build options", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "Windows 10 Pro\r\nVisual Studio 2015 Community Update 2\r\nAppc Core: 5.3.0-12\r\nAppc NPM: 4.2.5-1\r\nTi SDK: 5.3.0.v20160411153728", "closedSprints": [ { "id": 627, "state": "closed", "name": "2016 Sprint 10 SDK", "startDate": "2016-05-07T00:43:56.954Z", "endDate": "2016-05-21T00:43:00.000Z", "completeDate": "2016-05-23T02:06:04.349Z", "originBoardId": 114 }, { "id": 707, "state": "closed", "name": "2016 Sprint 19 SDK", "startDate": "2016-09-10T00:17:15.164Z", "endDate": "2016-09-24T00:17:00.000Z", "completeDate": "2016-09-26T05:17:04.253Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "395859", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "So what about introducing\r\n\r\n* *win-cert* for replacement of *ws-cert*\r\n* *win-sdk* for replacement of *wp-sdk*\r\n\r\nI found another confusing options from the [Command-Line Interface Reference|http://docs.appcelerator.com/platform/latest/#!/guide/Appcelerator_Command-Line_Interface_Reference]:\r\n\r\n* *wp8-publisher-guid*\r\n* *wp-product-guid*\r\n\r\nI'm not sure if *wp8-publisher-guid* is actually used but we might want to change them into *win-publisher-id* and *win-product-guid*.\r\n", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-12T02:31:16.000+0000", "updated": "2016-09-12T02:32:13.000+0000" }, { "id": "395874", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "That renaming sounds good to me (y). For backwards compatibility with Studio would it be best to keep the existing options around but hidden from -h and then removing them in another release? Maybe hide/deprecate in the version you decide and then remove in 7.0.0? If I remember right I think the hiding of options can be done in config.js. Also, I'll file a ticket now for Studio to adopt these once done\r\n\r\nAs for those two confusing options, I believe they are intended specifically for moving a phone 8 app phone to 8.1, this is probably a holdover from mobile web. I guess maybe we could follow the same process as the above if they're deemed unneeded?", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2016-09-12T09:00:46.000+0000", "updated": "2016-09-12T09:01:08.000+0000" }, { "id": "395978", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Yes, for backwards compatibility I would think we want to deprecate {{wp-\\*}} and {{ws-\\*}} options in {{6.1.0}} and remove it in next major version {{7.0.0}}.\r\n\r\n* ws-cert → win-cert\r\n* wp-sdk → win-sdk\r\n* wp-product-guid → win-product-guid\r\n\r\nFor {{wp8-publisher-guid}}, I'm not yet sure if we really use it in non-mobieweb build. If it is Windows Phone 8.0 specific option, I think we can deprecate and remove it as of {{7.0.0}} because we are not supporting Windows Phone 8.0 anymore.\r\n\r\nOr more proactively, we might want think about deprecating/removing support for Windows Phone 8.1 in {{7.0.0}}? > [~cng]\r\n\r\n", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-13T04:17:35.000+0000", "updated": "2016-09-13T04:17:35.000+0000" }, { "id": "395981", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "ok confirmed {{wp8-publisher-guid}} does not exist. There's {{wp-publisher-guid}} instead. This will be renamed to {{win-publisher-guid}}.", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-13T04:57:50.000+0000", "updated": "2016-09-13T04:57:50.000+0000" }, { "id": "395999", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Ah no, renaming {{wp-publisher-guid}} to {{win-publisher-guid}} seems more confusing because we already have {{win-publisher-id}} which is used to specify Windows Publisher ID. I think we want to keep {{wp-publisher-guid}} for now and remove it in the version where we remove Windows Phone 8.1 support.", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-13T10:10:29.000+0000", "updated": "2016-09-13T10:11:14.000+0000" }, { "id": "396058", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "https://github.com/appcelerator/titanium_mobile_windows/pull/868", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-14T00:59:32.000+0000", "updated": "2016-09-14T00:59:32.000+0000" }, { "id": "419356", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "We forgot to add {{fixVersion}}...this should go to {{6.1.0}}.\r\n\r\n*Test Case*\r\n\r\n{code}\r\n// testing win-cert\r\nappc run -p windows --target dist-winstore -l trace --win-cert generated.cer\r\n\r\n// testing win-sdk works with 10.0\r\nappc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0\r\n\r\n// testing win-sdk works with specific 10.0 version\r\nappc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0.10586.0\r\n\r\n// win-product-guid\r\nappc run -p windows --build-only --target wp-device -l trace --win-product-guid f0473be1-c557-4f98-a103-4ba9f453b5b0\r\n{code}", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-05-09T09:42:22.000+0000", "updated": "2017-05-09T09:42:22.000+0000" }, { "id": "419384", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified improvements, tested with commands from [~kota] mentioned above. \r\n\r\n*Test steps*\r\n* Created a titanium project \r\n* Ran the following command {{appc run -p windows --target dist-winstore -l trace --win-cert generated.cer}}\r\n* Followed the prompts \r\n* Application was built to the {{dist}} folder without any issues \r\n* Then ran the following command {{appc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0}}\r\n* Application was built successfully \r\n* Then ran the following command {{appc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0.10586.0}}\r\n* Application built successfully \r\n* Then ran the following com {{appc run -p windows --build-only --target wp-device -l trace --win-product-guid f0473be1-c557-4f98-a103-4ba9f453b5b0}}\r\n* Application was built without any issues \r\n\r\n*Environment*\r\nAPPC CLI: 6.2.0\r\nWindows Mobile 10 device Lumia 640 (10.0.14393)\r\n\r\nOperating System:\r\nName = Microsoft Windows 10 Pro\r\nVersion = 10.0.14393\r\nArchitecture = 32bit\r\nCPUs = 4\r\nMemory = 17034395648\r\n\r\nNode.js:\r\nNode.js Version = 6.10.1", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-09T18:11:03.000+0000", "updated": "2017-05-09T18:11:03.000+0000" }, { "id": "420053", "author": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~kota], does this sound like a good summary for this ticket for the 6.1.0 release note?\r\n\r\n* Deprecated the commands for wp-* and ws-*\r\n* The following replaces the deprecated commands:\r\n** ws-cert > win-cert\r\n** wp-sdk > win-sdk\r\n** wp-product-guid > win-product-guid", "updateAuthor": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-05-19T17:51:24.000+0000", "updated": "2017-05-19T17:51:24.000+0000" }, { "id": "420072", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~bimmel] Yes, that sounds good (y)", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-05-19T22:08:46.000+0000", "updated": "2017-05-19T22:08:46.000+0000" } ], "maxResults": 12, "total": 12, "startAt": 0 } } }