{ "id": "159831", "key": "TIMOB-23275", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17706", "name": "Release 5.4.0", "archived": false, "released": true, "releaseDate": "2016-08-11" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-05-05T13:33:53.000+0000", "created": "2016-04-26T18:28:42.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "parity", "qe-5.3.0", "qe-5.4.0", "windows" ], "versions": [ { "id": "17707", "name": "Release 5.3.0", "archived": false, "released": true, "releaseDate": "2016-06-04" } ], "issuelinks": [ { "id": "51500", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "154547", "key": "TIMOB-20281", "fields": { "summary": "Windows: Implement enabled property for View", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "updated": "2016-06-27T17:14:55.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "While reviewing a windows ticket, implementing the enabled property for view elements, it was found that it was not implemented for iOS. This should be fixed to achieve parity between android & windows. \r\n\r\n*TEST CODE:*\r\n{code:java}\r\nvar win = Ti.UI.createWindow({});\r\n\r\nvar view1 = Ti.UI.createView({\r\n backgroundColor: \"Magenta\",\r\n enabled: true,\r\n left: 0,\r\n top: 50,\r\n height: 100,\r\n width: 100\r\n});\r\n\r\nview1.addEventListener('click', function() {\r\n alert(\"CLICKED! 1\");\r\n});\r\n\r\nvar view2 = Ti.UI.createView({\r\n backgroundColor: \"green\",\r\n enabled: false,\r\n top: 50,\r\n left: 200,\r\n height: 100,\r\n width: 100\r\n});\r\n\r\nview2.addEventListener('click', function() {\r\n alert(\"CLICKED! 2\");\r\n});\r\n\r\nwin.add(view1);\r\nwin.add(view2);\r\nwin.open()\r\n{code}\r\n\r\n\r\nh2. Steps to Reproduce\r\n1. Create a default classic mobile project.\r\n2. Apply test code above to app.js file.\r\n3. Deploy app to iOS simulator / device.\r\n4. After launching the app, click / tap on left view.\r\n5. Click / tap on right view.\r\n\r\nh2. Actual Result\r\nLeft view *enabled* property is set to {{true}} : Alert appears when clicked.\r\nRight view *enabled* property is set to {{false}} : Alert appears when clicked.\r\n\r\n\r\nh2. Expected Result.\r\nLeft view *enabled* property is set to {{true}} : Alert *should* appear when clicked.\r\nRight view *enabled* property is set to {{false}} : Alert *should NOT* appear when clicked.", "attachment": [], "flagged": false, "summary": "Windows: Deprecate Ti.UI.View.enabled, rename to touchEnabled", "creator": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "subtasks": [], "reporter": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "environment": "Tested on: \r\nWindows 10 Pro / OSX El Capitan Version 10.11.4\r\nNexus 6P Android 6.0 / iOS 8.4 / 9.3 \r\nAppc Studio: 4.6.0.201604081249 \r\nTi SDK: 5.3.0.v20160421080259 \r\nAppc NPM: 4.2.5-3\r\nAppc Core: 5.3.0-34 \r\nNode: v4.4.2", "closedSprints": [ { "id": 624, "state": "closed", "name": "2016 Sprint 09 SDK", "startDate": "2016-04-23T00:39:45.452Z", "endDate": "2016-05-07T00:39:00.000Z", "completeDate": "2016-05-09T03:43:10.279Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "384107", "author": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~htbryant] On iOS the property is called touchEnabled, enabled isn't a property of the view on iOS according to the documentation. To Achieve parity we need to rename touchEnabled to enabled on iOS or rename it on Windows. Since its also called touchEnabled on android it would be best to rename the property on windows. ", "updateAuthor": { "name": "apetkov", "key": "apetkov", "displayName": "Angel Petkov", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2016-04-27T18:10:04.000+0000", "updated": "2016-04-27T18:10:04.000+0000" }, { "id": "384191", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "We used to call it {{enabled}} in earlier releases and introduced {{touchEnabled}} in both iOS and Android instead, which was a while ago. I'd prefer Windows to migrate the property, since it's a new platform. /cc [~cwilliams]", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-04-28T11:52:45.000+0000", "updated": "2016-04-28T11:52:45.000+0000" }, { "id": "384232", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "I agree that it would be a better option for Windows to adopt the {{touchEnabled}} property.", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2016-04-28T17:55:15.000+0000", "updated": "2016-04-28T17:55:15.000+0000" }, { "id": "384323", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "Looks like we need to rename the new \"enabled\" property to touchEnabled. We should probably leave \"enabled\", log a warning that it's deprecated and forward the call to enabled.", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2016-04-29T14:06:04.000+0000", "updated": "2016-04-29T14:06:04.000+0000" }, { "id": "384717", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "https://github.com/appcelerator/titanium_mobile_windows/pull/666", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2016-05-04T13:36:43.000+0000", "updated": "2016-05-04T13:36:43.000+0000" }, { "id": "384844", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "We retained the Ti.UI.View.enabled property and it basically just forwards the property/getter/setter to touchEnabled and logs a warning to console that enabled is deprecated, please use touchEnabled.", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2016-05-05T13:34:36.000+0000", "updated": "2016-05-05T13:34:36.000+0000" }, { "id": "389137", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "Verified as fixed, using the {{enabled}} property on windows now returns a deprecated message, and now supports the {{touchEnabled}} property. \r\n\r\nTested on: \r\nWindows 10 Pro \r\nWindows Phone 10.0 (Microsoft Lumia 640 LTE) \r\nAppc Studio: 4.7.0.201606220541\r\nTi SDK: 5.4.0.v20160617074028\r\nAppc NPM: 4.2.7-2\r\nAppc Core: 5.4.0-18\r\nNode: v4.4.4\r\n\r\n*Closing Ticket.*", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2016-06-27T17:14:43.000+0000", "updated": "2016-06-27T17:14:43.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }