{ "id": "161445", "key": "TIMOB-23575", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16980", "description": "New V8", "name": "Release 6.0.0", "archived": false, "released": true, "releaseDate": "2016-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-07-12T01:36:13.000+0000", "created": "2016-06-29T16:40:18.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [ "parity", "qe-5.4.0" ], "versions": [ { "id": "17706", "name": "Release 5.4.0", "archived": false, "released": true, "releaseDate": "2016-08-11" }, { "id": "17707", "name": "Release 5.3.0", "archived": false, "released": true, "releaseDate": "2016-06-04" } ], "issuelinks": [], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2016-09-05T13:52:30.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "h5.Description\r\n\r\nWhen building for Windows Platform currently the following is performed when generating app icons, [as seen in the code|https://github.com/appcelerator/titanium_mobile_windows/blob/master/cli/commands/_build/copy.js#L343-L344]\r\n\r\n# Check for icon in \\app\\assets\\windows\r\n# Check for icon in \\\r\n# Check for presence of \\DefaultIcon-windows.png and generate using this if it exists\r\n# Check for presence of \\DefaultIcon.png and generate using this if it exists\r\n\r\nTo be in parity with other platforms the locations should be changed to the following in this order:\r\n\r\n# Check for icon in \\Resources\\windows\\\r\n# Check for icon in \\Resources\\\r\n# Check for \\DefaultIcon-windows.png and generate using this if it exists\r\n# Check for \\DefaultIcon.png and generate using this if it exists\r\n\r\nh5.Steps to reproduce\r\n\r\n# Build a classic Titanium project for the Windows Platform using {{appc run -p windows -T wp-device --build-only}}\r\n# Copy the icons from {{\\build\\windows\\Assets\\}} to {{\\Resources\\windows\\}}\r\n# Build the project using {{appc run -p windows -T wp-device --build-only}}\r\n# Copy the icons from {{\\build\\windows\\Assets\\}} to {{\\Resources\\}}\r\n# Build the project using {{appc run -p windows -T wp-device --build-only}}\r\n\r\nh5.Actual result\r\n\r\nIn both step 3 and 5, app icons will be generated\r\n\r\nh5.Expected result\r\n\r\nIn both step 3 and 5, app icons should not be generated as they are located in the correct locations", "attachment": [], "flagged": false, "summary": "Windows: CLI does not check correct directories when detecting app icons", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "Windows 10 Pro\r\nTi SDK: 5.4.0.v20160629063537\r\nAppc NPM: 4.2.7-2 \r\nAppc CLI: 5.4.0-23\r\nAppc Studio: 4.7.0.201606220541", "closedSprints": [ { "id": 678, "state": "closed", "name": "2016 Sprint 14 SDK", "startDate": "2016-07-02T00:25:57.921Z", "endDate": "2016-07-16T00:25:00.000Z", "completeDate": "2016-07-18T03:18:29.729Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "390191", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "master: https://github.com/appcelerator/titanium_mobile_windows/pull/775", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2016-07-08T20:30:00.000+0000", "updated": "2016-07-08T20:30:00.000+0000" }, { "id": "395333", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Verified using:\r\n\r\nOS: Microsoft Windows 10 Pro 10.0.14393\r\nAppc core: 6.0.0-38\r\nAppc NPM: 4.2.8-6\r\nTi SDK: 6.0.0.v20160904203840\r\n \r\nThe correct locations are now checked when building.\r\n\r\nClosing ticket", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2016-09-05T13:52:24.000+0000", "updated": "2016-09-05T13:52:24.000+0000" } ], "maxResults": 2, "total": 2, "startAt": 0 } } }