{ "id": "163030", "key": "TIMOB-23872", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16980", "description": "New V8", "name": "Release 6.0.0", "archived": false, "released": true, "releaseDate": "2016-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-09-07T03:31:55.000+0000", "created": "2016-09-06T22:16:14.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "cb-tooling" ], "versions": [], "issuelinks": [], "assignee": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "updated": "2016-09-09T22:35:48.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" }, { "id": "10207", "name": "Tooling" } ], "description": "When the Android build was rewritten for Node.js, a flaw was purposely ported from the old Python code. For iOS, {{}} overrides a custom {{Info.plist}} and a custom {{Info.plist}} overrides the default {{Info.plst}}. However with Android, if a custom {{AndroidManifest.xml}} is present, the {{}} section of the {{tiapp.xml}} does NOT override the custom {{AndroidManifest.xml}} by default. To enable this behavior, you must set {{ti config android.mergeCustomAndroidManifest true}}.\r\n\r\nWe should set this flag to {{true}} so that Android's behavior is in parity with iOS.", "attachment": [], "flagged": false, "summary": "Enable android.mergeCustomAndroidManifest by default", "creator": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "subtasks": [], "reporter": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "environment": null, "closedSprints": [ { "id": 705, "state": "closed", "name": "2016 Sprint 18 Tooling", "startDate": "2016-08-27T00:16:26.485Z", "endDate": "2016-09-10T00:16:00.000Z", "completeDate": "2016-09-13T20:21:37.063Z", "originBoardId": 199 } ], "comment": { "comments": [ { "id": "395467", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Ti SDK master PR: https://github.com/appcelerator/titanium_mobile/pull/8320\r\nTi SDK 6_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/8321", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2016-09-07T02:58:07.000+0000", "updated": "2016-09-07T02:58:07.000+0000" }, { "id": "395468", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "To test:\r\n\r\n# Create a new Titanium app\r\n# Create {{platform/android}} in the project dir\r\n# Build the app for Android... you can do a build-only build\r\n# Copy {{build/android/AndroidManifest.xml}} into {{platform/android}}\r\n# Edit the {{tiapp.xml}} and set the following in the {{}} section:\r\n{code}\r\n\r\n\t\r\n\r\n{code}\r\n# Build the app again and verify that the {{minSdkVersion}} in the {{build/android/AndroidManifest.xml}} is correct\r\n* Before the fix, it will not merge the {{minSdkVersion}} unless the Titanium CLI config contains {{android.mergeCustomAndroidManifest}} is set to {{true}}\r\n* After the fix, it will always override the custom {{AndroidManifest.xml}} just like the {{Info.plist}} for iOS\r\n", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2016-09-07T03:03:09.000+0000", "updated": "2016-09-07T03:03:09.000+0000" }, { "id": "395471", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "CR and FT passed. PRs merged.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-09-07T03:31:46.000+0000", "updated": "2016-09-07T03:31:46.000+0000" }, { "id": "395782", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix.\r\n\r\nThe {{AndroidManifest.xml}} gets overidden by {{tiapp.xml}} successfully.\r\nClosing.\r\n\r\nEnvironment:\r\nAppc Studio : 4.8.0.201609061702\r\nTi SDK : 6.0.0.v20160909001132\r\nTi CLI : 5.0.9\r\nAlloy : 1.9.1\r\nMAC El Capitan : 10.11.6\r\nAppc NPM : 4.2.8-6\r\nAppc CLI : 6.0.0-38\r\nNode: 4.4.4\r\nNexus 6 - Android 6.0.1", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2016-09-09T22:35:34.000+0000", "updated": "2016-09-09T22:35:34.000+0000" } ], "maxResults": 4, "total": 4, "startAt": 0 } } }