{ "id": "163533", "key": "TIMOB-23973", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "16980", "description": "New V8", "name": "Release 6.0.0", "archived": false, "released": true, "releaseDate": "2016-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2016-10-04T04:21:34.000+0000", "created": "2016-09-28T21:36:04.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [ "imageview", "kroll-thread", "listview", "load", "qe-6.0.0", "regression" ], "versions": [ { "id": "17706", "name": "Release 5.4.0", "archived": false, "released": true, "releaseDate": "2016-08-11" }, { "id": "18253", "name": "Release 5.5.0", "archived": false, "released": true, "releaseDate": "2016-09-13" } ], "issuelinks": [ { "id": "52860", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "154159", "key": "TIMOB-20204", "fields": { "summary": "iOS: ListView - onload events of template items not fired", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "52859", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "161904", "key": "TIMOB-23669", "fields": { "summary": "ListView Images are displaying incorrectly", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2016-10-05T17:00:49.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "I think I found an issue on images inside ListViewItem templates, the event did not fire if we have *\"+image+\" property*. \r\nWorks just fine on 5.2.X and 5.3.X, but not on 5.4.GA and 5.5.GA.\r\nActually is very irregular.\r\n\r\n*Not fire the event: (with \"+image=\"\"+\" property)*\r\n{code:java}\r\n\r\n \r\n \r\n{code}\r\n\r\n*Fired normally! ({color:red}without{color} \"+image=\"\"+\" property)*\r\n\r\n{code:java}\r\n \r\n{code}\r\n\r\n\r\nAlso seams if I put \"run-on-main-thread TRUE\", the event fires normally too, but I can't do that in our project.\r\n\r\n{code:java}\r\ntrue\r\n{code}\r\n\r\n\r\nIn our project is comment out, like:\r\n\r\n{code:java}\r\n \r\n{code}\r\n\r\n\r\nP.S. In our case we have 3 events, which they worked acceptably well on the 5.2.x and 5.3.x sdk.\r\nWe have this issues since the 5.4.GA, but just yesterday is that I've isolated the problem in detail.\r\n\r\n\r\n{code:java}\r\n \r\n\r\n{code}\r\n\r\n\r\nThere is any workaround until the fix? We need to release the app :)", "attachment": [ { "id": "60372", "filename": "2313275.jpg", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-09-28T21:37:31.000+0000", "size": 42590, "mimeType": "image/jpeg" }, { "id": "60370", "filename": "index.js", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-09-28T21:34:34.000+0000", "size": 258, "mimeType": "text/javascript" }, { "id": "60373", "filename": "index.tss", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-09-28T21:48:21.000+0000", "size": 479, "mimeType": "application/octet-stream" }, { "id": "60371", "filename": "index.xml", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-09-28T21:34:23.000+0000", "size": 457, "mimeType": "text/xml" }, { "id": "60401", "filename": "TIMOB-23973_used_images.zip", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-10-03T16:09:18.000+0000", "size": 86993, "mimeType": "application/zip" } ], "flagged": false, "summary": "iOS: Events on images inside ListViewItem templates not fired (regression)", "creator": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "subtasks": [], "reporter": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "environment": null, "closedSprints": [ { "id": 722, "state": "closed", "name": "2016 Sprint 20 SDK", "startDate": "2016-09-28T16:50:17.299Z", "endDate": "2016-10-12T16:50:00.000Z", "completeDate": "2016-10-10T06:17:01.016Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "397575", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "updateAuthor": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-09-28T22:01:01.000+0000", "updated": "2016-09-28T22:01:01.000+0000" }, { "id": "397886", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "body": "Let me know if you want me test/change something in this/my side in order to speedup the process? Any \"Objc-C\" code anything is fine!", "updateAuthor": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-10-03T14:42:18.000+0000", "updated": "2016-10-03T14:42:18.000+0000" }, { "id": "397889", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "The issue was initially caused by [this commit|https://github.com/appcelerator/titanium_mobile/pull/7879] and was fixed for one of the use-cases with [this commit|https://github.com/appcelerator/titanium_mobile/pull/8158]. So either we revert the {{load}}-event ticket completely or find a way to process this special event on the kroll-thread correctly.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-10-03T15:10:43.000+0000", "updated": "2016-10-03T15:10:43.000+0000" }, { "id": "397892", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Hui, just fixed it the first issue (load-event). Basically we need to revert all those proxy-changes that have been made by the previous two PR's and add the correct delegate to the view. Yay!", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-10-03T15:38:34.000+0000", "updated": "2016-10-03T15:54:21.000+0000" }, { "id": "397895", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/8461\r\nPR (6_0_X): https://github.com/appcelerator/titanium_mobile/pull/8462\r\n\r\nTest-cases (run with and without main-thread, use the attached images):\r\nhttps://gist.github.com/hansemannn/0f654bcaee125e7df994625bedc6d840\r\n\r\n-But I noticed that this will only work for the load-event, when the {{load}} event does not need to be triggered asynchronously (which is a likely use-case). So I still need to find out how to delegate the string through the proxy and fire it as soon as it's available.- -- *Fixed!*", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-10-03T15:57:12.000+0000", "updated": "2016-10-03T16:12:37.000+0000" }, { "id": "397896", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "body": "Glad you solved it! \r\nTook me hours, days to isolate this issue :)\r\n\r\nI will test then I will report back Hans Knoechel.", "updateAuthor": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-10-03T16:01:45.000+0000", "updated": "2016-10-03T16:01:45.000+0000" }, { "id": "397899", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "body": "Hans Knoechel, Im running here 5.5.1.GA, I duplicated the sdk folder to 5.5.1.dev (usual I do this), now what is PR that I should use:\r\n\r\nPR (master): https://github.com/appcelerator/titanium_mobile/pull/8461 \r\nPR (6_0_X): https://github.com/appcelerator/titanium_mobile/pull/8462", "updateAuthor": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-10-03T16:24:50.000+0000", "updated": "2016-10-03T16:25:14.000+0000" }, { "id": "397901", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "To patch it manually, fork the 5_5_X branch and cherry-pack from either of both (they should both integrate well into 5_5_X). But don't simply replace the files, that could lead to bad side-effects. Cherry-picking is the way to go here.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-10-03T16:27:19.000+0000", "updated": "2016-10-03T16:27:19.000+0000" }, { "id": "397903", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "body": "Usually for small changes I do the above. Many Thanks!", "updateAuthor": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-10-03T16:29:20.000+0000", "updated": "2016-10-03T16:30:27.000+0000" }, { "id": "397909", "author": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "body": "My quick tests, says to me this works like is supposed to! #Kudos for #Hans Knoechel and to #all\r\nShould be Fixed and works ok on 5.5.1.dev :)\r\n\r\n*P.S:* Tested +against our app+ with +use case above reported+ , *is fixed*.", "updateAuthor": { "name": "nunocostapt", "key": "nunocostapt", "displayName": "Nuno Costa", "active": true, "timeZone": "Europe/Lisbon" }, "created": "2016-10-03T17:01:28.000+0000", "updated": "2016-10-03T17:42:24.000+0000" }, { "id": "398034", "author": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "body": "CR and FT passed. PRs merged. Good job.", "updateAuthor": { "name": "cng", "key": "cng", "displayName": "Chee Kiat Ng", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2016-10-04T04:20:56.000+0000", "updated": "2016-10-04T04:20:56.000+0000" }, { "id": "398145", "author": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "body": "Verified as fixed, events are now being fired.\r\n\r\nTested On:\r\n\r\n{noformat}\r\niPhone 6 10.0 Device\r\niPhone 7 10.0 Sim\r\niPhone 5 9.3.5 Device\r\nMac OSX El Capitan 10.12\r\nTi SDK: 6.0.0.v20161005072811\r\nAppc Studio: 4.8.0.201609292239\r\nAppc NPM: 4.2.8-7\r\nApp CLI: 6.0.0-56\r\nXcode 8.0 \r\nNode v4.4.7\r\n{noformat}\r\n\r\n*Closing ticket.*", "updateAuthor": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "created": "2016-10-05T16:58:30.000+0000", "updated": "2016-10-05T16:58:30.000+0000" } ], "maxResults": 12, "total": 12, "startAt": 0 } } }