{ "id": "164685", "key": "TIMOB-24174", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19870", "description": "", "name": "Release 6.1.2", "archived": false, "released": true, "releaseDate": "2017-08-03" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-07-25T21:51:29.000+0000", "created": "2016-11-26T12:29:47.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [ "android", "community", "images", "merge-6.1.2", "notable", "qe-6.1.0", "tableview" ], "versions": [], "issuelinks": [ { "id": "55718", "type": { "id": "10002", "name": "Duplicate", "inward": "is duplicated by", "outward": "duplicates" }, "inwardIssue": { "id": "168509", "key": "TIMOB-24901", "fields": { "summary": "Android: List disclosure indicators increases size from SDK 5.5.1.GA to SDK 6.1.1.v20170615113917", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2017-08-07T23:22:09.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "Adding DENSITY_XXXHIGH images and correcting the size of the other icons:\r\n!tablview.png|thumbnail!\r\n\r\n*Icon sizes:*\r\nlow: 36px\r\nmedium: 48px\r\nhigh: 72px\r\nxhigh: 96px\r\nxxhigh: 144px\r\nxxxhigh: 192px\r\n\r\nPR will also fix setMinimumHeight of the TableViewRow :\r\nhttps://github.com/appcelerator/titanium_mobile/blob/a8aceeaeee02ed9c8ea70c835a0e78960e254a55/android/modules/ui/src/java/ti/modules/titanium/ui/widget/tableview/TiTableViewRowProxyItem.java#L490\r\nTiConvert.toTiDimension is not used on MIN_HEIGHT so the default rows are very small compared to iOS", "attachment": [ { "id": "62012", "filename": "after.png", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-04-12T14:21:33.000+0000", "size": 41746, "mimeType": "image/png" }, { "id": "62013", "filename": "before.png", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-04-12T14:21:33.000+0000", "size": 54914, "mimeType": "image/png" }, { "id": "60784", "filename": "tablview.png", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-11-26T13:35:19.000+0000", "size": 59378, "mimeType": "image/png" }, { "id": "61032", "filename": "test.png", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2016-12-08T22:55:43.000+0000", "size": 14618, "mimeType": "image/png" }, { "id": "60783", "filename": "titanium_check.svg", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-11-26T13:32:50.000+0000", "size": 11761, "mimeType": "image/svg+xml" } ], "flagged": false, "summary": "Android: Update TableView/ListView accessory images, fix spacing", "creator": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "environment": "Android", "closedSprints": [ { "id": 920, "state": "closed", "name": "2017 Sprint 14 SDK", "startDate": "2017-07-02T16:29:41.455Z", "endDate": "2017-07-16T16:29:00.000Z", "completeDate": "2017-07-17T14:39:47.328Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "401847", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/8636\r\n\r\nWould like to have some feedback on the images. The \"hasChild\" could be a bit bigger?", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-11-26T12:44:10.000+0000", "updated": "2016-11-26T12:44:10.000+0000" }, { "id": "401848", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "updated svg", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-11-26T13:32:57.000+0000", "updated": "2016-11-26T13:32:57.000+0000" }, { "id": "402421", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Added more spacing on the right side:\r\n!http://migaweb.de/table2.png!", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-12-01T18:29:23.000+0000", "updated": "2016-12-01T18:29:23.000+0000" }, { "id": "402466", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "[~michael] What is the native behavior here? I'm also wondering why the title have no left-padding by default (we can set it with {{left}}, but is this really how it's done natively as well?). *EDIT*: [Looks like|http://www.vogella.com/tutorials/AndroidListView/img/xinteractive10.png.pagespeed.ic.V0cVgp99SN.png] it's native behavior.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-12-02T15:13:33.000+0000", "updated": "2016-12-03T16:03:01.000+0000" }, { "id": "402527", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Thank you, for looking it up! Perhaps adding a different PR with the possibility to add a padding might be a good idea. On the other hand: you can add a label and position it like you want to. Not sure if most people use a table in the default way.", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2016-12-04T10:16:51.000+0000", "updated": "2016-12-04T10:16:51.000+0000" }, { "id": "403204", "author": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "body": "Verified the improvement, the has child/check graphics look correct. \r\n\r\nTested on:\r\n\r\n{noformat}\r\nmacOS Sierra 10.12.1\r\nNexus 5X (6.0.1)\r\nNexus 6p (7.0)\r\nandroid emulator (4.4.2, 6.0)\r\nTi SDK: 6.1.0.v20161212041915\r\nAppc NPM: 4.2.8\r\nApp CLI: 6.1.0-313\r\nNode v4.6.0\r\n{noformat}\r\n\r\n*Closing Ticket.*", "updateAuthor": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "created": "2016-12-12T19:42:31.000+0000", "updated": "2016-12-12T19:42:31.000+0000" }, { "id": "406838", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "We need to reopen this ticket. There are some serious glitches on some devices (tested with a Nexus 5 GenyMotion simulator):\r\n- http://abload.de/image.php?img=bildschirmfoto2017-02neror.png (6.0.1.GA - still missing right margin)\r\n- http://abload.de/image.php?img=bildschirmfoto2017-02hrr18.png (6.1.0 - too big, still missing right margin) \r\n- http://abload.de/image.php?img=bildschirmfoto2017-02oapwp.png (6.1.0 - too big, still missing right margin)\r\n\r\nIn addition, there is also no title (left) margin on Android, so developers need to \"hack\" around it by setting a manual {{left}} margin on the cells. This should be adapted to match 1:1 the native behavior. And in the same way, we should also update the high-res images for the \"disclosure_64.png\" asset, they don't currently exist.\r\n", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-11T11:14:55.000+0000", "updated": "2017-02-11T11:16:16.000+0000" }, { "id": "406841", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Almost done:\r\n!http://migaweb.de/table_listview.png!\r\n(TableView top, ListView bottom)\r\n\r\nChanges:\r\n* Using the same graphics in the ListViewItems\r\n* set the correct size\r\n* added missing disclosure images\r\n* moved the ListViewItem Label a bit more to the right\r\n\r\n-still searching a way to move the Label inside the TableView-\r\nfound it, going to make a PR soon", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-11T20:10:26.000+0000", "updated": "2017-02-11T20:23:52.000+0000" }, { "id": "406842", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Danke Michael! Looking forward to the PR :-)", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-11T20:29:16.000+0000", "updated": "2017-02-11T20:29:16.000+0000" }, { "id": "406843", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/8832", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-11T21:34:32.000+0000", "updated": "2017-02-11T21:34:32.000+0000" }, { "id": "407396", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Fixed the default values on both table/listview:\r\n\r\n!http://migaweb.de/table_listview2.png!\r\n\r\nAccording to https://github.com/android/platform_frameworks_base/blob/82834baa358f55acb542e17da828b2d497cf8332/core/res/res/values/themes.xml#L146 it should be 6dp", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-18T13:47:14.000+0000", "updated": "2017-02-18T13:47:14.000+0000" }, { "id": "407397", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Very very nice. I'm wondering if the title color is the default as well. That would be the last thing I could think about.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-18T14:57:37.000+0000", "updated": "2017-02-18T14:57:37.000+0000" }, { "id": "407398", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Colors were actually the same it was just disabled! I've enabled it and now they look the same", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-02-18T16:10:44.000+0000", "updated": "2017-02-18T16:10:44.000+0000" }, { "id": "424454", "author": { "name": "ben.bahrenburg@gmail.com", "key": "ben.bahrenburg@gmail.com", "displayName": "Ben Bahrenburg", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~hknoechel] [~lchoudhary] any chance to get this pulled into the 6_1_x branch?", "updateAuthor": { "name": "ben.bahrenburg@gmail.com", "key": "ben.bahrenburg@gmail.com", "displayName": "Ben Bahrenburg", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-07-20T16:13:05.000+0000", "updated": "2017-07-20T16:13:05.000+0000" }, { "id": "424685", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Totally! PR: https://github.com/appcelerator/titanium_mobile/pull/9251", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-07-25T19:30:15.000+0000", "updated": "2017-07-25T19:30:15.000+0000" }, { "id": "424699", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR passed for 6.1.2 PR\r\nPR merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-07-25T21:51:20.000+0000", "updated": "2017-07-25T21:51:20.000+0000" }, { "id": "424834", "author": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~lchoudhary] Can you please close? I have already checked. The fix is in SDK 6.1.2.v20170726115259.", "updateAuthor": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-07-26T20:28:10.000+0000", "updated": "2017-07-26T20:28:10.000+0000" } ], "maxResults": 17, "total": 17, "startAt": 0 } } }