{ "id": "166356", "key": "TIMOB-24438", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17608", "name": "Release 6.1.0", "archived": false, "released": true, "releaseDate": "2017-05-26" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-05-11T23:11:23.000+0000", "created": "2017-02-28T17:39:56.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [ "merge-6.1.0" ], "versions": [ { "id": "18928", "name": "Release 6.0.2", "archived": false, "released": true, "releaseDate": "2017-02-27" } ], "issuelinks": [ { "id": "54486", "type": { "id": "10001", "name": "Cloners", "inward": "is cloned into", "outward": "is cloned from" }, "outwardIssue": { "id": "144531", "key": "TIMOB-18556", "fields": { "summary": "Android: Update Appcompat Libraries", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "54840", "type": { "id": "10001", "name": "Cloners", "inward": "is cloned into", "outward": "is cloned from" }, "inwardIssue": { "id": "167494", "key": "TIMOB-24664", "fields": { "summary": "Android: Update bundled Android libraries to 25.3.1", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2017-05-15T20:52:38.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "Our current SDK release targets API level 23. Some bundled libraries like the Android Support Library were not updated to also target API23.", "attachment": [ { "id": "62168", "filename": "Screen Shot 2017-05-04 at 2.41.28 PM.png", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-04T21:44:08.000+0000", "size": 144543, "mimeType": "image/png" } ], "flagged": false, "summary": "Android: Update bundled Android libraries to 23.4.0", "creator": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "closedSprints": [ { "id": 889, "state": "closed", "name": "2017 Sprint 10 SDK", "startDate": "2017-05-08T00:27:49.740Z", "endDate": "2017-05-22T00:27:00.000Z", "completeDate": "2017-05-22T02:41:01.011Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "408835", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/8858", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-03-03T10:18:11.000+0000", "updated": "2017-03-03T10:18:11.000+0000" }, { "id": "418859", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~jvennemann], Can you please give us a test case to do an FR.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-02T21:31:40.000+0000", "updated": "2017-05-02T21:31:40.000+0000" }, { "id": "419016", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "[~lchoudhary], the easiest way to test this would be to use one of new features added in 23.4.0, like the [AppLaunchChecker|https://developer.android.com/reference/android/support/v4/app/AppLaunchChecker.html].\r\n\r\n*Steps for FR*\r\n1. Create a new Titanium module\r\n2. Add the following import to your {{Module.java}}:\r\n{{import android.support.v4.app.AppLaunchChecker;}}\r\n3. Add this line inside the {{onAppCreate}} method:\r\n{{Log.d(LCAT, String.format(\"hasStartedFromLauncher: %b\", AppLaunchChecker.hasStartedFromLauncher(app)));}}\r\n4. Build the module\r\n5. Copy the module into an app, add it to {{tiapp.xml}} and run it, check the log for the above debug message containing {{hasStartedFromLauncher}} right after it started.\r\n\r\n*Additional tests*\r\nRun the kitchen sink app to verify compatibility with existing apps.", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-05-03T13:48:25.000+0000", "updated": "2017-05-03T13:48:25.000+0000" }, { "id": "419067", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~jvennemann], I get the below error when I try to build the module:\r\n{code}\r\n[ERROR] : Failed to compile Java source files:\r\n[ERROR] : \r\n[ERROR] : warning: [options] bootstrap class path not set in conjunction with -source 1.6\r\n[ERROR] : Note: [KrollBindingGen] Running Kroll binding generator.\r\n[ERROR] : Note: [KrollBindingGen] No binding data found, creating new data file: org.appcelerator.titanium.bindings/testmodule.json\r\n[ERROR] : Note: [KrollBindingGen] Found binding for proxy Example\r\n[ERROR] : Note: [KrollBindingGen] Found binding for module Testmodule\r\n[ERROR] : /Users/lchoudhary/Desktop/workspaces/workspace_2016/testmodule/android/src/com/app/testmodule/TestmoduleModule.java:16: error: cannot find symbol\r\n[ERROR] : import android.support.v4.app.AppLaunchChecker;\r\n[ERROR] : ^\r\n[ERROR] : symbol: class AppLaunchChecker\r\n[ERROR] : location: package android.support.v4.app\r\n[ERROR] : Note: [KrollBindingGen] Generating JSON: file:/Users/lchoudhary/Desktop/workspaces/workspace_2016/testmodule/android/build/generated/json/org/appcelerator/titanium/bindings/testmodule.json\r\n[ERROR] : 1 error\r\n{code}\r\n\r\nits not able to resolve {{android.support}} in {{import android.support.v4.app.AppLaunchChecker;}}", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-03T22:05:38.000+0000", "updated": "2017-05-03T22:05:38.000+0000" }, { "id": "419096", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "[~lchoudhary], are you sure you were building with the correct SDK built from PR [#8858|https://github.com/appcelerator/titanium_mobile/pull/8858]. Note that that PR is for master so it's 6.2.0.\r\n\r\n[~gmathews], backport for 6_1_X branch: https://github.com/appcelerator/titanium_mobile/pull/9016", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-05-04T15:24:44.000+0000", "updated": "2017-05-04T15:24:44.000+0000" }, { "id": "419131", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~jvennemann], Yes I am building with the correct PR.\r\n!Screen Shot 2017-05-04 at 2.41.28 PM.png|thumbnail!\r\n\r\nI have attached my SDK folder structure. It shows I have the correct {{jar}} files from the PR.\r\nAlso, When I add {{import android.support.v4.app.AppLaunchChecker;}} I get {{The import android.support cannot be resolved}}.\r\n\r\nTried it for both {{master}} & {{6.1.0}} PR.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-04T21:44:57.000+0000", "updated": "2017-05-04T21:44:57.000+0000" }, { "id": "419145", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "[~lchoudhary], ok thanks for double checking. Can you please do a module build where you are encountering the error and send me the complete log with the log level set to trace? Maybe there is something different between our environments.\r\n\r\nAs for the unresolved import warning, that is most likely a Studio issue. You need to import the support libraries via Project properties > Java Build Path > Libraries > Add external JARs, so Studio knows about them.\r\n\r\n", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-05-04T23:36:49.000+0000", "updated": "2017-05-04T23:36:49.000+0000" }, { "id": "419347", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR passed with both master & backport PR.\r\n", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-09T00:31:08.000+0000", "updated": "2017-05-09T00:31:08.000+0000" }, { "id": "419407", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix using the steps above.\r\nClosing.\r\n\r\nStudio Ver: 4.9.0.201704240654\r\nSDK Ver: 6.1.0.v20170509114242\r\nOS Ver: 10.12.3\r\nXcode Ver: Xcode 8.3.2\r\nAppc NPM: 4.2.9\r\nAppc CLI: 6.2.0\r\nTi CLI Ver: 5.0.12\r\nAlloy Ver: 1.9.11\r\nNode Ver: 6.10.1\r\nJava Ver: 1.8.0_101\r\nDevices: > google Nexus 6 --- Android 6.0.1", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-09T20:35:39.000+0000", "updated": "2017-05-09T20:36:11.000+0000" }, { "id": "419553", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "Re-opening issue due to a crash when running on devices with Android <= 5.1.\r\n\r\n{code}\r\n[ERROR] TiApplication: Caused by: java.lang.ClassNotFoundException: Didn't find class \"android.support.graphics.drawable.VectorDrawableCompat\" on path: DexPathList[[zip file \"/data/app/com.appc.toolbartest-1/base.apk\"],nativeLibraryDirectories=[/data/app/com.appc.toolbartest-1/lib/x86\r\n{code}\r\n\r\nGoogle introduced support libraries for vector drawables on those devices with Support Libraries version 23.2.0. To resolve this the new support libraries {{animated-vector-drawable}} and {{support-vector-drawable}} need to be added as well.", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-05-11T14:29:20.000+0000", "updated": "2017-05-11T14:29:20.000+0000" }, { "id": "419558", "author": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR (6_1_X): https://github.com/appcelerator/titanium_mobile/pull/9053\r\n\r\nI just did a fix for 6_1_X because we have [#9027|https://github.com/appcelerator/titanium_mobile/pull/9027] open on master which updates the libraries to 25.3.1 and that PR already includes the vector drawable libraries.", "updateAuthor": { "name": "jvennemann", "key": "jvennemann", "displayName": "Jan Vennemann", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-05-11T15:25:34.000+0000", "updated": "2017-05-11T15:25:34.000+0000" }, { "id": "419586", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR passed for https://github.com/appcelerator/titanium_mobile/pull/9053", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-11T23:08:14.000+0000", "updated": "2017-05-11T23:08:14.000+0000" }, { "id": "419732", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix.\r\n\r\nFollowed the test steps above & tests passed.\r\nClosing.\r\n\r\nStudio Ver: 4.9.0.201705110256\r\nSDK Ver: 6.1.0.v20170514022959\r\nOS Ver: 10.12.3\r\nXcode Ver: Xcode 8.3.2\r\nAppc NPM: 4.2.9\r\nAppc CLI: 6.2.1\r\nTi CLI Ver: 5.0.13\r\nAlloy Ver: 1.9.11\r\nNode Ver: 6.10.1\r\nJava Ver: 1.8.0_101\r\nDevices: ⇨ google Nexus 6 --- Android 6.0.1\r\n ⇨ google Nexus 6P --- Android 7.1.1", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-05-15T20:52:14.000+0000", "updated": "2017-05-15T20:52:14.000+0000" } ], "maxResults": 13, "total": 13, "startAt": 0 } } }