{ "id": "168081", "key": "TIMOB-24769", "fields": { "issuetype": { "id": "7", "description": "gh.issue.story.desc", "name": "Story", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-06-27T14:05:34.000+0000", "created": "2017-06-04T18:59:55.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [ "qe-6.2.0" ], "versions": [], "issuelinks": [], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2017-06-29T12:05:35.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "We use the {{SBJSON}} library that was added in the Titanium SDK 0.9. It was never touched since then and nowadays we have the system-class {{NSJSONSerialization}} that does everything we needed from {{SBJSON}} (parse + stringify).\r\n\r\nAs we want to split out legacy code from the core to improve the build-time, removing this library is fundamental to getting started. The library is used in both the core and in TiVerify, so the changes will affect both repos.", "attachment": [], "flagged": false, "summary": "iOS: Remove SBJSON dependency from SDK-core", "creator": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "comment": { "comments": [ { "id": "420892", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR (tiverify/master): https://github.com/appcelerator/titanium_verify/pull/24\r\nPR (titanium_mobile/master): https://github.com/appcelerator/titanium_mobile/pull/9106\r\n\r\nTest-Case:\r\n{code:js}\r\nvar win = Ti.UI.createWindow({\r\n backgroundColor: '#fff'\r\n});\r\n\r\nvar btn = Ti.UI.createButton({\r\n title: 'Trigger'\r\n});\r\n\r\nbtn.addEventListener('click', function() {\r\n Ti.App.fireEvent(\"test\", { hello: 'world' }); \r\n});\r\n\r\n/**\r\n * Test-case 1: Event-unboxing (AppModule.m)\r\n */\r\nTi.App.addEventListener(\"test\", function(e) {\r\n Ti.API.info('Hello ' + e.hello)\r\n \r\n /**\r\n * Test-case 2: Geolocation (GeolocationModule.m)\r\n */\r\n Ti.Geolocation.reverseGeocoder(40.75773, -73.985708, function(e) {\r\n \r\n /**\r\n * Test-case 3: Analytics (AnalyticsModule.m)\r\n */\r\n var args = { \r\n success: e.success,\r\n places: e.places || []\r\n };\r\n \r\n Ti.Analytics.featureEvent('geo_update', args);\r\n Ti.API.info('Location: ', args);\r\n });\r\n});\r\n\r\nwin.add(btn);\r\nwin.open();\r\n{code}", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-06-04T19:07:26.000+0000", "updated": "2017-06-04T19:24:36.000+0000" }, { "id": "423134", "author": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "body": "Verified as fixed, using the provided test case, did not experience any errors during compile and run time, information returned to the console log was also verified to be working as intended.\r\n\r\nTested On:\r\n\r\niPhone 7 10.3.2 Device & Simulator\r\nMac OS Sierra (10.12.5)\r\nTi SDK: 6.2.0.v20170628154113\r\nAppc NPM: 4.2.9\r\nApp CLI: 6.2.2\r\nXcode 8.3.3\r\nNode v4.6.0\r\n\r\n*Closing ticket.*", "updateAuthor": { "name": "htbryant", "key": "htbryant", "displayName": "Harry Bryant", "active": true, "timeZone": "Europe/London" }, "created": "2017-06-29T12:05:18.000+0000", "updated": "2017-06-29T12:05:18.000+0000" } ], "maxResults": 2, "total": 2, "startAt": 0 } } }