{ "id": "168373", "key": "TIMOB-24816", "fields": { "issuetype": { "id": "6", "description": "gh.issue.epic.desc", "name": "Epic", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": { "id": "10000", "description": "", "name": "Done" }, "resolutiondate": "2017-11-30T15:00:49.000+0000", "created": "2017-06-13T16:48:42.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [], "issuelinks": [], "assignee": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "updated": "2017-11-30T15:00:49.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [], "description": "h5.Description\r\n\r\nCurrently there are two mocha suites in existence:\r\n\r\n* [titanium-mobile-mocha-suite|https://github.com/appcelerator/titanium-mobile-mocha-suite]\r\n ** This is used in the titanium_mobile repo and is pulled down on each build\r\n\r\n* [NMocha|https://github.com/appcelerator/titanium_mobile_windows/tree/master/Examples/NMocha]\r\n ** This is specific to Windows, it lives in the Windows repo and is used for unit tests in the Windows SDK build process\r\n\r\nThese have diverged over time and there are differences between the two, it has been attempted to merge them previously https://github.com/appcelerator/titanium_mobile_windows/pull/733\r\n\r\nIt would be ideal to restart this effort of merging together with the eventual goal of updating the Windows SDK build process to pull the git repository like titanium_mobile\r\n\r\nAfter discussions these are the steps to be taken for this\r\n\r\n# Work through the test files in comparing them against and updating titanium-mobile-mocha-suite\r\n# Merge the results of the above into titanium-mobile-mocha-suite, ensuring we do not cause failures on other platforms\r\n# Take the resulting suite from the merge, update NMocha with this for the short term\r\n# Investigate how we can use the titanium-mobile-mocha-suite repo in titanium_mobile_windows, initially we should look to use this in the build process, then we should look at how to update NMocha to pull this suite rather than checking the files in\r\n\r\nAlong the way the following should also be done\r\n\r\n* File tickets for FIXME/TODO comments where appropriate, linking them in the mocha suite\r\n", "attachment": [], "flagged": false, "summary": "Update the mocha suite in titanium_mobile_windows", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [ { "id": "169031", "key": "TIMOB-24986", "fields": { "summary": "Investigate the skipped tests on Windows", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "5", "description": "The sub-task of the issue", "name": "Sub-task", "subtask": true } } }, { "id": "169094", "key": "TIMOB-25018", "fields": { "summary": "Add Windows support to the test script", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "8", "description": "A technical task.", "name": "Technical task", "subtask": true } } }, { "id": "169095", "key": "TIMOB-25019", "fields": { "summary": "Add titanium-mobile-mocha-suite into the titanium_mobile_windows build process", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "8", "description": "A technical task.", "name": "Technical task", "subtask": true } } } ], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": null, "closedSprints": [ { "id": 925, "state": "closed", "name": "2017 Sprint 15 SDK", "startDate": "2017-07-16T14:40:47.191Z", "endDate": "2017-07-30T14:40:00.000Z", "completeDate": "2017-07-31T16:15:09.335Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "421873", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "A naively generated patch file of a diff between all .js files in Resources/ and Assets/ https://gist.github.com/ewanharris/dad0ba4c37104257335a5d48272fb252", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-06-13T17:15:58.000+0000", "updated": "2017-06-13T17:15:58.000+0000" }, { "id": "422175", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "https://github.com/appcelerator/titanium-mobile-mocha-suite/pull/17", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-06-16T18:36:59.000+0000", "updated": "2017-06-16T18:36:59.000+0000" }, { "id": "424575", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Some thoughts I have\r\n\r\n- Don't use ti.facebook for the test, (or implement it for Windows), we probably want a dummy module of some sort\r\n- Should we move ti.map tests out (we still need to split it out of Windows core)\r\n- Should we move out tests like geolocation and contacts that seem to prompt and break things. They would be a perfect use for Appium!\r\n- Could we try and make HTTPClient less flaky? Avoid external network connections etc. or just skip in general in CI\r\n- Could we try and have some sort of percentage hit for total tests ran? Will help prevent the skipping of tests", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-07-24T12:29:25.000+0000", "updated": "2017-07-24T12:30:05.000+0000" }, { "id": "427480", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-09-01T09:06:18.000+0000", "updated": "2017-09-01T09:06:18.000+0000" }, { "id": "431531", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Closing as done as titanium_mobile_windows has been using the mocha-suite for a while now, kudos to [~kiguchi] and [~cwilliams] for carrying the effort over the line :D", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-11-30T15:00:49.000+0000", "updated": "2017-11-30T15:00:49.000+0000" } ], "maxResults": 5, "total": 5, "startAt": 0 } } }