{ "id": "168739", "key": "TIMOB-24923", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-08-21T09:53:34.000+0000", "created": "2017-07-03T13:56:17.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [], "versions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" } ], "issuelinks": [ { "id": "55724", "type": { "id": "10011", "name": "Includes", "inward": "is included by", "outward": "includes" }, "inwardIssue": { "id": "164806", "key": "TIMOB-24189", "fields": { "summary": "Windows: Add support for Visual Studio 2017", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } }, { "id": "55733", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "164806", "key": "TIMOB-24189", "fields": { "summary": "Windows: Add support for Visual Studio 2017", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } }, { "id": "55725", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "169427", "key": "TIMOB-25077", "fields": { "summary": "Windows: Unable to build Hyperloop module zip with VS2017", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "7", "description": "gh.issue.story.desc", "name": "Story", "subtask": false } } } } ], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2017-08-22T09:30:00.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10207", "name": "Tooling" }, { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "h5.Description\r\n\r\nWhen creating a module with VS 2017 installed, it will throw the warning below and never create the cmake projects \r\n\r\nNote: ti cli does not throw an error, but appc cli does\r\n\r\n{code}\r\nAppcelerator Command-Line Interface, version 6.2.2\r\nCopyright (c) 2014-2017, Appcelerator, Inc. All Rights Reserved.\r\n\r\nMobileWeb platform has been deprecated in 5.4.0 and will be removed in 7.0.0.\r\nCMake Error: Could not create named generator undefined\r\nGenerators\r\n Visual Studio 15 2017 [arch] = Generates Visual Studio 2017 project files.\r\n Optional [arch] can be \"Win64\" or \"ARM\".\r\n Visual Studio 14 2015 [arch] = Generates Visual Studio 2015 project files.\r\n Optional [arch] can be \"Win64\" or \"ARM\".\r\n Visual Studio 12 2013 [arch] = Generates Visual Studio 2013 project files.\r\n Optional [arch] can be \"Win64\" or \"ARM\".\r\n Visual Studio 11 2012 [arch] = Generates Visual Studio 2012 project files.\r\n Optional [arch] can be \"Win64\" or \"ARM\".\r\n Visual Studio 10 2010 [arch] = Generates Visual Studio 2010 project files.\r\n Optional [arch] can be \"Win64\" or \"IA64\".\r\n Visual Studio 9 2008 [arch] = Generates Visual Studio 2008\r\nproject files.\r\n Optional [arch] can be \"Win64\" or \"IA64\".\r\n Visual Studio 8 2005 [arch] = Generates Visual Studio 2005 project files.\r\n Optional [arch] can be \"Win64\".\r\n Visual Studio 7 .NET 2003 = Deprecated. Generates Visual Studio .NET\r\n 2003 project files.\r\n Borland Makefiles = Generates Borland makefiles.\r\n NMake Makefiles = Generates NMake makefiles.\r\n NMake Makefiles JOM\r\n= Generates JOM makefiles.\r\n Green Hills MULTI = Generates Green Hills MULTI files\r\n (experimental, work-in-progress).\r\n MSYS Makefiles = Generates MSYS makefiles.\r\n MinGW Makefiles = Generates a make file for use with\r\n mingw32-make.\r\n Unix Makefiles = Generates standard UNIX makefiles.\r\n Ninja\r\n= Generates build.ninja files.\r\n Watcom WMake = Generates Watcom WMake makefiles.\r\n CodeBlocks - MinGW Makefiles = Generates CodeBlocks project files.\r\n CodeBlocks - NMake Makefiles = Generates CodeBlocks project files.\r\n CodeBlocks - NMake Makefiles JOM\r\n = Generates CodeBlocks project files.\r\n CodeBlocks - Ninja = Generates CodeBlocks project files.\r\n CodeBlocks - Unix Makefiles = Generates CodeBlocks project files.\r\n CodeLite - MinGW Makefiles = Generates CodeLite project files.\r\n CodeLite - NMake Makefiles = Generates CodeLite project files.\r\n CodeLite - Ninja = Generates CodeLite project files.\r\n CodeLite - Unix Makefiles =\r\nGenerates CodeLite project files.\r\n Sublime Text 2 - MinGW Makefiles\r\n = Generates Sublime Text 2 project files.\r\n Sublime Text 2 - NMake Makefiles\r\n = Generates Sublime Text 2 project files.\r\n Sublime Text 2 - Ninja = Generates Sublime Text 2 project files.\r\n Sublime Text 2 - Unix Makefiles\r\n = Generates Sublime Text 2 project files.\r\n Kate - MinGW Makefiles = Generates Kate project files.\r\n Kate - NMake Makefiles = Generates Kate project files.\r\n Kate - Ninja = Generates Kate\r\nproject files.\r\n Kate - Unix Makefiles = Generates Kate project files.\r\n Eclipse CDT4 - NMake Makefiles\r\n = Generates Eclipse CDT 4.0 project files.\r\n Eclipse CDT4 - MinGW Makefiles\r\n = Generates Eclipse CDT 4.0 project files.\r\n Eclipse CDT4 - Ninja = Generates Eclipse CDT 4.0 project files.\r\n Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.\r\n2017-07-03T13:52:37.845Z | ERROR | titanium exited with non-zero exit code (1)\r\n{code}\r\n\r\nh5.Steps to reproduce\r\n\r\n# appc new -t timodule --name myawesomemodule --id com.foo\r\n\r\nh5.Actual\r\n\r\nCLI will error with the above cmake projects not made\r\n\r\nh5.Expected\r\n\r\nCLI should not error, cmake project should be made", "attachment": [], "flagged": false, "summary": "Windows: Unable to create a module with VS2017", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "Windows 10 Pro\r\nVisual Studio 2017 \r\nTi SDK: 6.2.0.v20170630062735 (custom build with titanium_mobile_windows#959 vs 2017 support)", "closedSprints": [ { "id": 912, "state": "closed", "name": "2017 Sprint 13 Tooling", "startDate": "2017-06-18T16:15:17.914Z", "endDate": "2017-07-02T16:15:00.000Z", "completeDate": "2017-07-06T23:54:40.012Z", "originBoardId": 199 } ], "comment": { "comments": [ { "id": "423331", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Just need to add logic to [here|https://github.com/appcelerator/titanium_mobile_windows/blob/master/templates/module/default/hooks/windows-module.js#L29-L49] to handle the name mapping like we do in other places\r\n\r\n{code}\r\n//\r\n// Choose CMake generator based on selected Visual Studio\r\n//\r\nfunction chooseCMakeVSgenerator(logger, callback) {\r\n\tvar generators = {\r\n\t '12.0':'Visual Studio 12 2013',\r\n\t '14.0':'Visual Studio 14 2015',\r\n\t\t'15.0': 'Visual Studio 15 2017'\r\n\t};\r\n\r\n\twindowslib.detect(function (err, results) {\r\n\t\tif (err) {\r\n\t\t\tlogger.err(err);\r\n\t\t}\r\n\t\tvar generator = generators['12.0'],\r\n\t\t\tsdks = {\r\n\t\t\t\twindows: results.windows,\r\n\t\t\t\twindowsphone: results.windowsphone\r\n\t\t\t};\r\n\t\tconsole.log(results.selectedVisualStudio)\r\n\r\n\t\tif (results.selectedVisualStudio) {\r\n\t\t\tconsole.log('foo')\r\n\t\t\tif (/^Visual Studio \\w+ 2017/.test(results.selectedVisualStudio.version)) {\r\n\t\t\t\tgenerator = generators['15.0'];\r\n\t\t\t} else {\r\n\t\t\t\tgenerator = generators[results.selectedVisualStudio.version];\r\n\t\t\t}\r\n\t\t}\r\n\t\tcallback(generator, sdks);\r\n\t});\r\n}\r\n{code}", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-07-03T14:19:45.000+0000", "updated": "2017-07-03T14:20:20.000+0000" }, { "id": "423336", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~kiguchi] I have a fix for this above, which of the following would your prefer?\r\n\r\n- I pr it separately to https://github.com/appcelerator/titanium_mobile_windows/pull/959\r\n- I pr it into your branch for https://github.com/appcelerator/titanium_mobile_windows/pull/959\r\n\r\n(I don't mind if you just wanna commit it yourself too)", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-07-03T15:14:58.000+0000", "updated": "2017-07-03T15:14:58.000+0000" }, { "id": "423420", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~eharris] ok I see, I can handle that. (y)", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-07-03T23:49:14.000+0000", "updated": "2017-07-03T23:49:14.000+0000" }, { "id": "423423", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Merged: https://github.com/appcelerator/titanium_mobile_windows/pull/959/commits/2e7c51ea030c74e8c5e77773f07c7fbdfed7eff7", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-07-04T01:55:19.000+0000", "updated": "2017-07-04T01:55:19.000+0000" }, { "id": "427017", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Verified changes in 6.2.0.v20170821203442", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-08-22T09:30:00.000+0000", "updated": "2017-08-22T09:30:00.000+0000" } ], "maxResults": 5, "total": 5, "startAt": 0 } } }