{ "id": "168959", "key": "TIMOB-24959", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": { "id": "10000", "description": "", "name": "Done" }, "resolutiondate": "2019-06-04T23:55:45.000+0000", "created": "2017-07-14T12:48:59.000+0000", "priority": { "name": "High", "id": "2" }, "labels": [], "versions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" } ], "issuelinks": [], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2019-06-04T23:55:45.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10207", "name": "Tooling" }, { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "h5.Description\r\n\r\nCurrently when detecting Windows 10 SDKs we look for a registry key and then assign a generic '10.0' SDK with some [info|https://github.com/appcelerator/windowslib/blob/3cc8f1aa20c4ba6eb4c65ffca520e7cf4e7d4e55/lib/windowsphone.js#L138-L171]\r\n\r\nWe can improve the individual SDK detection by following a similar method to one of the utility scripts called by VsDevCmd, {{C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Common7\\Tools\\vsdevcmd\\core\\winsdk.bat}}\r\n\r\nThat files basic flow when searching for an SDK is\r\n\r\n is one of HKCU\\SOFTWARE\\Wow6432Node, HKLM\\SOFTWARE, or HKCU\\SOFTWARE\r\n\r\n# Get the installation folder using {{reg query \\Microsoft\\Microsoft SDKs\\Windows\\v10.0 /v \"InstallationFolder\"}\r\n# Set to WindowsSdkDir\r\n# For each directory in {{\\include\\}}\r\n - Look for {{\\include\\\\um\\Windows.h}}, if it exists it's a valid SDK\r\n\r\nI'm not sure what changes would be required to the SDK build process if we switched from using an generic 10.0 to individual SDKs", "attachment": [], "flagged": false, "summary": "Windows: Detect individual versions of Windows 10 SDKs", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": null, "comment": { "comments": [ { "id": "424141", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "We already do this [https://github.com/appcelerator/windowslib/blob/3cc8f1aa20c4ba6eb4c65ffca520e7cf4e7d4e55/lib/windowsphone.js#L173-L181] but due to TIMOB-24958 I think we might need to expand upon this more and split the SDKs an underlying info out a bit more", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-07-14T13:16:00.000+0000", "updated": "2017-07-14T13:16:00.000+0000" }, { "id": "429274", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Can we close this since we have resolved TIMOB-24958?\r\n", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-10-19T04:23:04.000+0000", "updated": "2017-10-19T04:23:04.000+0000" }, { "id": "448837", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "I think this can be closed for now because we already have this feature. Feel free to reopen if that's not the case.", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2019-06-04T23:55:45.000+0000", "updated": "2019-06-04T23:55:45.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }