{ "id": "169429", "key": "TIMOB-25078", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "18414", "description": "", "name": "Release 6.2.0", "archived": false, "released": true, "releaseDate": "2017-09-13" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-08-21T09:15:15.000+0000", "created": "2017-08-09T13:25:20.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [ { "id": "19870", "description": "", "name": "Release 6.1.2", "archived": false, "released": true, "releaseDate": "2017-08-03" } ], "issuelinks": [ { "id": "55729", "type": { "id": "10011", "name": "Includes", "inward": "is included by", "outward": "includes" }, "inwardIssue": { "id": "164806", "key": "TIMOB-24189", "fields": { "summary": "Windows: Add support for Visual Studio 2017", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "2", "description": "A new feature of the product, which has yet to be developed.", "name": "New Feature", "subtask": false } } } } ], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2017-08-22T09:30:10.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "h5.Description\r\n\r\nWhen using the {{--run-cmake}} flag with VS2017 the generator selected will always be {{Visual Studio 14 2015}} this is because the check [here|https://github.com/appcelerator/titanium_mobile_windows/blob/18d58eb3a3b123ac916017661b83635a28e8caec/templates/module/default/template/windows/plugins/hooks/windows.js#L41] needs to be data.windowsInfo.selectedVisualStudio\r\n\r\nBelow is the working code\r\n\r\n{code}\r\nfunction selectVisualStudio(data) {\r\n if (data.windowsInfo && data.windowsInfo.selectedVisualStudio) {\r\n var version = data.windowsInfo.selectedVisualStudio.version;\r\n if (version == '12.0') {\r\n return 'Visual Studio 12 2013';\r\n } else if (version == '14.0') {\r\n return 'Visual Studio 14 2015';\r\n } else if (/^Visual Studio \\w+ 2017/.test(version)) {\r\n return 'Visual Studio 15 2017';\r\n }\r\n }\r\n return 'Visual Studio 14 2015';\r\n}\r\n{code}\r\n\r\nh5.Steps to reproduce\r\n\r\nYou need VS2017 to test this\r\n1. Grab https://github.com/appcelerator-archive/ti.paint\r\n2. Overwrite ti.paint/windows/plugins/hooks/windows.js with the hook [here|https://github.com/appcelerator/titanium_mobile_windows/blob/18d58eb3a3b123ac916017661b83635a28e8caec/templates/module/default/template/windows/plugins/hooks/windows.js]\r\n3. Make sure the path at ti.paint/blob/master/windows/CMakeLists.txt#L24, matches your selected\r\n4. Build the module using {{appc run -p windows --build-only --run-cmake}}\r\n\r\nh5.Actual\r\n\r\nErrors out with \r\n\r\n{code}\r\n[DEBUG] Run CMake on C:\\Users\\ewan\\Documents\\git\\ti.paint\\windows\\Windows10.Win32\r\n[WARN] CMake Error at CMakeLists.txt:20 (project):\r\n A Windows Store component with CMake requires both the Windows Desktop SDK\r\n as well as the Windows Store '10.0' SDK. Please make sure that you have\r\n both installed\r\n[INFO] -- Configuring incomplete, errors occurred!\r\nSee also \"C:/Users/ewan/Documents/git/ti.paint/windows/Windows10.Win32/CMakeFiles/CMakeOutput.log\".\r\n{code}\r\n\r\nChecking ti.paint\\windows\\Windows10.Win32\\CMakeCache.txt shows CMAKE_GENERATOR:INTERNAL is Visual Studio 14 2015\r\n\r\nh5.Expected\r\n\r\nShould select VS2017 generator and build successfully (note that you might still see a failure due to it attempting to build 8.1)", "attachment": [], "flagged": false, "summary": "Windows: run cmake flag always defaults to Visual Studio 2015 generator", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "Windows 10 Pro\r\nTitanium SDK: 6.1.1.GA, 6.1.2.GA, 7.0.0.v20170808160733", "closedSprints": [ { "id": 939, "state": "closed", "name": "2017 Sprint 17 SDK", "startDate": "2017-08-13T23:08:29.095Z", "endDate": "2017-08-27T23:08:00.000Z", "completeDate": "2017-08-27T21:10:54.125Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "426324", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "FYI Hyperloop had similar issue (TIMOB-25077) and here's the fix: https://github.com/appcelerator/hyperloop.next/pull/200/files", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-08-09T13:50:34.000+0000", "updated": "2017-08-09T13:50:34.000+0000" }, { "id": "426436", "author": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "body": "This issue is addressed in the [PR for TIMOB-24189|https://github.com/appcelerator/titanium_mobile_windows/pull/959/commits/02e554618b29d2a88a44252a4ac5d6ce1a81d475]. ", "updateAuthor": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-08-10T02:40:59.000+0000", "updated": "2017-08-10T02:40:59.000+0000" }, { "id": "427019", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Verified changes in 6.2.0.v20170821203442", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-08-22T09:30:10.000+0000", "updated": "2017-08-22T09:30:10.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }