{ "id": "169669", "key": "TIMOB-25210", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19922", "description": "", "name": "Release 6.2.1", "archived": false, "released": true, "releaseDate": "2017-09-18" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-09-19T18:39:34.000+0000", "created": "2017-08-30T09:59:18.000+0000", "epic": { "id": 168100, "key": "TIMOB-24772", "name": "iOS: Support iOS 11 / Xcode 9", "summary": "iOS: Add support for iOS 11 and Xcode 9", "color": { "key": "color_1" }, "done": false }, "priority": { "name": "Critical", "id": "1" }, "labels": [ "appstore", "ios", "ios11" ], "versions": [ { "id": "19870", "description": "", "name": "Release 6.1.2", "archived": false, "released": true, "releaseDate": "2017-08-03" } ], "issuelinks": [], "assignee": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "updated": "2017-10-17T15:14:01.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "I just received feedback from Slack that you currently cannot submit any iOS 11 app due to the error \"Missing Marketing Icon - iOS Apps must include a 1024x1024px Marketing Icon in PNG format. Apps that do not include the Marketing Icon cannot be submitted for App Review or Beta App Review.\".\r\n\r\nThe issue simply occurs because Apple introduced a new Icon-type in the asset-catalog called \"iOS Marketing\", which represents a 1024x1024 PNG image. As we already have our DefaultIcon.png, the SDK change would simply grab it and reference the new key in the asset-catalog. Also, we should now enforce the users to specify a \"DefaultIcon.png\" for iOS 11 distributions and deprecate the manual appicon.png formats. \r\n\r\nAlso see [this Stackoverflow thread|https://stackoverflow.com/questions/44565883/missing-marketing-icon] for more context.\r\n\r\n*EDIT*: Required asset-catalog object to add:\r\n{code:json}\r\n {\r\n \"size\" : \"1024x1024\",\r\n \"idiom\" : \"ios-marketing\",\r\n \"filename\" : \"DefaultIcon.png\",\r\n \"scale\" : \"1x\"\r\n}\r\n{code}\r\n\r\n*EDIT 2*: The following change in our _build.js could allow the app-icon to be received via \"appicon-Marketing.png\":\r\n{code:js}\r\n'-Marketing': { height: 1024, width: 1024, scale: 1, idioms: [ 'ios-marketing' ], minXcodeVer: '9.0' }\r\n{code}\r\nThe same would probably need to be done for the DefaultIcon.png, so we won't need to deprecate anything, yet, just make sure it's supported for both DefaultIcon, non-DefaultIcon, asset-catalog and non-asset-catalog.\r\n\r\n*EDIT 3*: The above change seems to work (although some others are still missing, might be interesting to investigate later):\r\n !Bildschirmfoto 2017-08-30 um 12.19.41.png|thumbnail! \r\n\r\n", "attachment": [ { "id": "63153", "filename": "Bildschirmfoto 2017-08-30 um 12.19.41.png", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-08-30T10:21:45.000+0000", "size": 1113321, "mimeType": "image/png" } ], "flagged": false, "summary": "iOS: Cannot submit builds with iOS 11 / Xcode 9 due to missing \"Marketing Image\"", "creator": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "closedSprints": [ { "id": 945, "state": "closed", "name": "2017 Sprint 18 Tooling", "startDate": "2017-08-27T21:14:41.095Z", "endDate": "2017-09-10T21:14:00.000Z", "completeDate": "2017-09-10T21:23:47.718Z", "originBoardId": 219 }, { "id": 949, "state": "closed", "name": "2017 Sprint 19 Tooling", "startDate": "2017-09-10T21:25:25.151Z", "endDate": "2017-09-24T21:25:00.000Z", "completeDate": "2017-09-25T17:50:29.468Z", "originBoardId": 219 } ], "comment": { "comments": [ { "id": "427422", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "master PR: https://github.com/appcelerator/titanium_mobile/pull/9377\r\n6_2_X PR: https://github.com/appcelerator/titanium_mobile/pull/9378", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2017-08-30T15:30:02.000+0000", "updated": "2017-08-30T15:33:08.000+0000" }, { "id": "427432", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "FR Passed, using:\r\nMacOS 10.12.6 (16G24b)\r\nStudio 4.9.0.201705302345\r\nTi SDK 6.2.0.v20170825130234\r\nAppc NPM 4.2.9\r\nAppc CLI 6.2.3\r\nAlloy 1.9.13\r\nXcode 9.0 (9M202q)\r\n\r\nI no longer receive the warning about the ios-marketing app icon when submitting an iOS 11 app built with Xcode 9. There is also an appicon-Marketing.png image present in the build.", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-08-30T18:33:42.000+0000", "updated": "2017-08-30T18:33:54.000+0000" }, { "id": "427434", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified in SDK builds 6.2.0.v20170830115907 & 7.0.0.v20170830115844", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-08-30T19:56:38.000+0000", "updated": "2017-08-30T19:56:38.000+0000" }, { "id": "428101", "author": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "body": "Fixed bug when specifying a {{\\-\\-device\\-family}} of {{ipad}} or {{iphone}}.\r\n\r\nTi SDK master PR: https://github.com/appcelerator/titanium_mobile/pull/9449\r\nTi SDK 6_3_X PR: https://github.com/appcelerator/titanium_mobile/pull/9450\r\nTi SDK 6_2_X PR: https://github.com/appcelerator/titanium_mobile/pull/9451", "updateAuthor": { "name": "cbarber", "key": "cbarber", "displayName": "Chris Barber", "active": true, "timeZone": "America/Chicago" }, "created": "2017-09-19T17:53:58.000+0000", "updated": "2017-09-19T17:53:58.000+0000" }, { "id": "428108", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Bug fix verified in SDK builds 6.2.1.v20170919115451 & 6.3.0.v20170919115627 & 7.0.0.v20170919115520", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-09-19T20:57:49.000+0000", "updated": "2017-09-19T20:57:49.000+0000" }, { "id": "428112", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "[~ewieber] Should we change to 6.2.1?", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-09-19T21:08:03.000+0000", "updated": "2017-09-19T21:08:03.000+0000" }, { "id": "428113", "author": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~hknoechel] yes", "updateAuthor": { "name": "ewieber", "key": "ewieber", "displayName": "Eric Wieber", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2017-09-19T21:10:16.000+0000", "updated": "2017-09-19T21:10:16.000+0000" }, { "id": "429188", "author": { "name": "joshlewis", "key": "joshlewis", "displayName": "Josh Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Can this fix be added to the 5x sdk? It just started, and I can't re-write my app now that's due in a few days, many of the modules I'm using arent supported in the latest sdk.", "updateAuthor": { "name": "joshlewis", "key": "joshlewis", "displayName": "Josh Lewis", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-10-17T15:14:01.000+0000", "updated": "2017-10-17T15:14:01.000+0000" } ], "maxResults": 8, "total": 8, "startAt": 0 } } }