{ "id": "170103", "key": "TIMOB-25437", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19906", "description": "", "name": "Release 6.3.0", "archived": false, "released": true, "releaseDate": "2017-11-01" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-10-26T22:57:32.000+0000", "created": "2017-10-24T11:58:26.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [], "versions": [ { "id": "19906", "description": "", "name": "Release 6.3.0", "archived": false, "released": true, "releaseDate": "2017-11-01" } ], "issuelinks": [], "assignee": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "updated": "2017-10-30T21:25:31.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "h5.Description\r\n\r\nDebug log from slack https://gist.github.com/dave255/d1556df4bd58b49d23210cf586b20c7f\r\n\r\nWhen {{enable-launch-screen-storyboard}} is set to true in the tiapp, and a custom LaunchLogo is defined for a device group e.g. LaunchLogo~iphone.png, the build will error with the above log\r\n\r\n\r\nSteps to reproduce\r\n\r\n1. Download https://github.com/ewanharris/TIMOB-25437 and build it\r\n\r\nh5.Actual\r\n\r\nError above\r\n\r\nh5.Expected\r\n\r\nNo error\r\n\r\nAddendum \r\n\r\nIn https://github.com/appcelerator/titanium_mobile/pull/9535 I added use strict to _build.js to get around some const/let errors in some places. This however has exposed a bug in the JS code where dest is not defined here https://github.com/appcelerator/titanium_mobile/blob/6_3_X/iphone/cli/commands/_build.js#L5284, this is now an error because we're in strict mode and this is a no-no, there's probably quite a bit of this in the file\r\n\r\nThere's two options\r\n\r\n# Remove the 'use strict' fix the usage of const and let\r\n# Figure out some way of running eslint on the file to tease out all the errors in strict mode\r\n\r\nI vote #1", "attachment": [], "flagged": false, "summary": "iOS: dest is undefined error when using LaunchLogos", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "SDK: 6.3.0.v20171018084007", "comment": { "comments": [ { "id": "429498", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~hknoechel] [~emerriman] fyi", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-10-24T11:58:44.000+0000", "updated": "2017-10-24T11:58:44.000+0000" }, { "id": "429511", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "PR here https://github.com/appcelerator/titanium_mobile/pull/9549\r\n\r\nTest case demo here https://github.com/ewanharris/TIMOB-25437\r\n\r\nUpdating description to reflect demo", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2017-10-24T18:08:23.000+0000", "updated": "2017-10-24T18:08:23.000+0000" }, { "id": "429714", "author": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Passed FR. PR merged. Changes are seen in 6.3.0.v20171030133255", "updateAuthor": { "name": "amukherjee", "key": "amukherjee", "displayName": "Abir Mukherjee", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-10-26T22:57:32.000+0000", "updated": "2017-10-30T21:25:24.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }