{ "id": "170463", "key": "TIMOB-25562", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "17609", "description": "", "name": "Release 7.0.0", "archived": false, "released": true, "releaseDate": "2017-12-07" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2017-11-28T21:09:44.000+0000", "created": "2017-11-27T11:20:52.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android", "migration", "module" ], "versions": [ { "id": "17609", "description": "", "name": "Release 7.0.0", "archived": false, "released": true, "releaseDate": "2017-12-07" } ], "issuelinks": [], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2017-12-09T10:37:52.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "The V8 update forces module developers to recompile their modules, which can be quite a pain when having many modules to maintain. I would propose a small module-build hook inside the {{_buildModule.js}} that takes care of this by detecting the currently selected SDK and then migrates the module automatically, by:\r\n\r\n- bumping the {{apiversion}} to {{4}}\r\n- setting the minimum-sdk to {{7.0.0}}\r\n- adding the {{arm64-v8a}} architecture\r\n- optionally (recommended): bumping the version to the next major to indicate a new major version\r\n\r\nWe may want to ask the developer to confirm the changes, e.g. by printing the new file. It would greatly improve the dev-experience during module recompiling and could be the subject of our planned post about migrating to SDK 7.", "attachment": [], "flagged": false, "summary": "CLI: Automatically migrate native Android modules to SDK 7 during module-build", "creator": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "comment": { "comments": [ { "id": "431378", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR (including some open discussions): https://github.com/appcelerator/titanium_mobile/pull/9631", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-11-28T11:41:48.000+0000", "updated": "2017-11-28T11:41:48.000+0000" }, { "id": "431504", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix with SDK 7.0.0.v20171129100330.\r\nClosing.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-11-30T00:32:17.000+0000", "updated": "2017-11-30T00:32:17.000+0000" }, { "id": "431892", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Little bug: {{description}} field will be the module {{name}} after an auto update. It is still in the .bak file so you can copy it over again", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-12-09T10:26:19.000+0000", "updated": "2017-12-09T10:26:19.000+0000" }, { "id": "431893", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "This is because the module template sets the {{description}} key to the module name by default: {{description: <%- moduleName %>}}. But I fixed it as part of TIMOB-25592, thanks!", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2017-12-09T10:37:52.000+0000", "updated": "2017-12-09T10:37:52.000+0000" } ], "maxResults": 4, "total": 4, "startAt": 0 } } }