{ "id": "170586", "key": "TIMOB-25600", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "19957", "description": "", "name": "Release 7.1.0", "archived": false, "released": true, "releaseDate": "2018-03-14" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-03-01T00:24:58.000+0000", "created": "2017-12-11T15:05:31.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [], "versions": [], "issuelinks": [ { "id": "56250", "type": { "id": "10002", "name": "Duplicate", "inward": "is duplicated by", "outward": "duplicates" }, "outwardIssue": { "id": "170756", "key": "TIMOB-25656", "fields": { "summary": "Android. TiViewProxy.getOrCreateView returns null on Titanium 7.0.0+", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "updated": "2018-03-06T23:16:54.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "When using custom theme to change the *touch-ripple* colour on *tableview rows*, *touch-ripple* colour is not applied using *SDK 7.0.0.GA*, however it works as expected while using *5.5.1.GA* or below.\r\n\r\nIt makes impossible to change the ripple-effect colour using *7.0.0.GA* & even it's behaving odd if I use *touchFeedbackColor* on tableview rows.\r\n\r\nHere's a sample code to test this:\r\n\r\n\r\n{code:java}\r\nvar win = Ti.UI.createWindow({\r\n\tbackgroundColor : 'black',\r\n\ttheme : 'GalleryTheme'\r\n});\r\n\r\nvar table = Ti.UI.createTableView({\r\n\twidth : Ti.UI.FILL,\r\n\theight : Ti.UI.FILL\r\n});\r\n\r\ntable.appendRow(createRow(\"Camera Test\"));\r\ntable.appendRow(createRow(\"Multi Image Picker\"));\r\ntable.appendRow(createRow(\"Image Compression Test\"));\r\ntable.appendRow(createRow(\"Get Current Location\"));\r\n\r\nwin.add(table);\r\n\r\nwin.open();\r\n\r\nfunction createRow(_text) {\r\n\tvar label = Ti.UI.createLabel({\r\n\t\tcolor: 'white',\r\n\t\ttext: _text,\r\n\t\tleft : 20,\r\n\t\twidth: Ti.UI.SIZE, height: Ti.UI.SIZE\r\n\t});\r\n\r\n\tvar row = Ti.UI.createTableViewRow({\r\n\t\theight: 50,\r\n\t width: Ti.UI.FILL\r\n\t});\r\n\r\n\trow.add(label);\r\n\treturn row;\r\n}\r\n\r\n// theme used in this sample to change ripple effect\r\n\r\n{code}\r\n\r\nAs expected, *`colorControlHighlight`* colour should be used to show ripple-colour effect. \r\n\r\nAlso find attached screenshot for both SDKs.\r\n", "attachment": [ { "id": "63756", "filename": "sdk6_3_0.png", "author": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-12-11T15:03:50.000+0000", "size": 76491, "mimeType": "image/png" }, { "id": "63757", "filename": "sdk7_0_0.png", "author": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-12-11T15:03:50.000+0000", "size": 71646, "mimeType": "image/png" } ], "flagged": false, "summary": "Android : SDK 7.0.0.GA not applying custom theme attributes properly on TableViewRow, but SDK 5.5.1 or below works properly", "creator": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "environment": "Tested on below environments:\r\n\r\n* Titanium SDK 7.0.0.GA & 5.5.1.GA\r\n* Android OS 7.1.1 (Nokia 5 & Nexus 9)\r\n* Android OS 6.0.1 (Moto G4 Play & Samsung On5)", "closedSprints": [ { "id": 1000, "state": "closed", "name": "2018 Sprint 04 SDK", "startDate": "2018-02-12T04:23:01.913Z", "endDate": "2018-02-26T04:23:00.000Z", "completeDate": "2018-02-26T19:36:01.769Z", "originBoardId": 114 }, { "id": 126, "state": "closed", "name": "2018 Sprint 05 SDK", "startDate": "2018-02-25T19:38:08.926Z", "endDate": "2018-03-11T18:38:00.000Z", "completeDate": "2018-03-11T22:06:01.520Z", "originBoardId": 100 } ], "comment": { "comments": [ { "id": "431982", "author": { "name": "sdarda", "key": "sdarda", "displayName": "Sharif AbuDarda", "active": false, "timeZone": "Asia/Dhaka" }, "body": "Hello, I tried to test the issue. But not quiet able to reproduce it. I hve created a sample app with custom theme.xml in platform/android/res/values/ and I used your theme code section above. Now I define the theme in tiapp.xml. also, use theme property in the window as your code. I see the orange action bar but The row selection color is not changing now even for 6.3.0.GA as you mentioned. So, there might be a problem. Can you compile a sample app for us and send it here. so we can testit. Are you testing on device? ", "updateAuthor": { "name": "sdarda", "key": "sdarda", "displayName": "Sharif AbuDarda", "active": false, "timeZone": "Asia/Dhaka" }, "created": "2017-12-11T21:06:10.000+0000", "updated": "2017-12-11T21:06:10.000+0000" }, { "id": "431997", "author": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Hi Sharif, I just re-checked my SDK & it was 5.5.1 on which it's working fine. I had deleted 6.3.0 this Saturday when I installed 7.0.0. But I am sure that I was able to see that green ripple color earlier when I was using 6.3.0. \r\n\r\nYes, I tested it on 4 different devices as I mentioned in Environments.\r\n\r\nCould you please recheck it with SDK 5.5.1 because I can clearly see green-ripple colour in 5.5.1 but not in 7.0.0?", "updateAuthor": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-12-12T03:45:54.000+0000", "updated": "2017-12-12T03:45:54.000+0000" }, { "id": "432449", "author": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Hi Sharif, few more important things I found today about this bug are:\r\n# Theme is not getting applied to very first window of the app, i.e., *index.xml*\r\n# If we the same TableView in another window, theme works properly.\r\n# Adding to above point, if we open another window right after index.xml window, it doesn't work.\r\n# If we delay opening the another window with same TableView, theme works properly.\r\n# In any case, theme is not applying only on TableView, however I can see it applied properly on Button.\r\n\r\nSo from above points, it looks like that theme is somehow getting delayed in being applied to TableView only on first window.", "updateAuthor": { "name": "prashant_saini", "key": "prashant_saini", "displayName": "Prashant Saini", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2017-12-20T18:20:25.000+0000", "updated": "2017-12-20T18:20:25.000+0000" }, { "id": "432845", "author": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/9701\r\n7_1_X: https://github.com/appcelerator/titanium_mobile/pull/9874", "updateAuthor": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "created": "2018-01-08T15:38:35.000+0000", "updated": "2018-02-22T14:48:56.000+0000" }, { "id": "434849", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed for master & backport.\r\nWaiting for CR to merge.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-02-23T22:43:14.000+0000", "updated": "2018-02-23T22:43:14.000+0000" }, { "id": "435013", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Backport PR merged.\r\nWaiting for master merge to get enabled.\r\n", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-02-28T17:20:39.000+0000", "updated": "2018-02-28T17:20:39.000+0000" }, { "id": "435041", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Master PR merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-01T00:24:50.000+0000", "updated": "2018-03-01T00:24:50.000+0000" }, { "id": "435274", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix in SDK 7.2.0.v20180305152636 & 7.1.0.v20180306061214.\r\n\r\nClosing.\r\n\r\nStudio Ver: 5.0.0.201712081732\r\nOS Ver: 10.13.2\r\nXcode Ver: Xcode 9.2\r\nAppc NPM: 4.2.12\r\nAppc CLI: 7.0.2\r\nDaemon Ver: 1.0.1\r\nTi CLI Ver: 5.0.14\r\nAlloy Ver: 1.11.0\r\nNode Ver: 8.9.1\r\nNPM Ver: 5.5.1\r\nJava Ver: 1.8.0_101\r\nDevices: ⇨ google Nexus 5 — Android 6.0.1\r\n⇨ google Nexus 6P — Android 8.0.0", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-06T23:16:50.000+0000", "updated": "2018-03-06T23:16:50.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }