{ "id": "171154", "key": "TIMOB-25810", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-10-25T14:06:14.000+0000", "created": "2018-02-22T10:17:47.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "ActionBar", "actionbar", "android", "bug", "orientation" ], "versions": [], "issuelinks": [ { "id": "56918", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "172454", "key": "TIMOB-26460", "fields": { "summary": "Android: Toolbar height set to Ti.UI.SIZE won't resize when changing orientation", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-10-25T17:37:58.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nThe ActionBar on Android won't resize when the device rotates. \r\n\r\n[As seen in Material Design guidelines|https://material.io/guidelines/layout/structure.html#structure-app-bar], when a mobile is on landscape, ActionBar's height is 48dp, while on portrait it's 56dp.\r\n\r\nAttached is a video demonstrating the issue.\r\n\r\n*Steps to reproduce:*\r\n# Position an Android device in portrait.\r\n# Build and run a default Classic app project on that Android device.\r\n# Note the height of the top titlebar.\r\n# Rotate the device to landscape.\r\n# Notice the titlebar height does not shrink. _(This is the bug.)_\r\n# Keep holding the device at landscape and back out of the app.\r\n# Launch the app in landscape form.\r\n# Notice that the titlebar height is smaller upon launch.\r\n# Rotate the device to portrait.\r\n# Notice that the titlebar height has not increased. _(This is the bug.)_\r\n", "attachment": [ { "id": "64885", "filename": "bug_height_actionbar_orientation.mov", "author": { "name": "gfigueras", "key": "gfigueras", "displayName": "Guillermo Figueras", "active": true, "timeZone": "Europe/Madrid" }, "created": "2018-02-22T09:58:23.000+0000", "size": 9355377, "mimeType": "video/quicktime" }, { "id": "64884", "filename": "BugHeightActionbar.zip", "author": { "name": "gfigueras", "key": "gfigueras", "displayName": "Guillermo Figueras", "active": true, "timeZone": "Europe/Madrid" }, "created": "2018-02-22T10:17:17.000+0000", "size": 3743835, "mimeType": "application/zip" } ], "flagged": false, "summary": "Android: ActionBar height won't resize on screen rotation", "creator": { "name": "gfigueras", "key": "gfigueras", "displayName": "Guillermo Figueras", "active": true, "timeZone": "Europe/Madrid" }, "subtasks": [], "reporter": { "name": "gfigueras", "key": "gfigueras", "displayName": "Guillermo Figueras", "active": true, "timeZone": "Europe/Madrid" }, "environment": "Titanium SDK 7.0.1 and 7.0.2\r\n\r\nTested on:\r\n* Nexus 5X, Android 7.1.0 (emulator)\r\n* Xiaomi Redmi Note 4, Android 7.0 (device)", "closedSprints": [ { "id": 1084, "state": "closed", "name": "2018 Sprint 21", "startDate": "2018-10-07T23:32:40.560Z", "endDate": "2018-10-21T23:32:00.000Z", "completeDate": "2018-10-21T23:19:05.460Z", "originBoardId": 114 }, { "id": 1088, "state": "closed", "name": "2018 Sprint 22", "startDate": "2018-10-21T23:20:52.653Z", "endDate": "2018-11-04T23:20:00.000Z", "completeDate": "2018-11-04T23:29:59.423Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "435635", "author": { "name": "gfigueras", "key": "gfigueras", "displayName": "Guillermo Figueras", "active": true, "timeZone": "Europe/Madrid" }, "body": "By the way, I've noticed this also happens if you use a Toolbar.", "updateAuthor": { "name": "gfigueras", "key": "gfigueras", "displayName": "Guillermo Figueras", "active": true, "timeZone": "Europe/Madrid" }, "created": "2018-03-15T08:59:18.000+0000", "updated": "2018-03-15T08:59:18.000+0000" }, { "id": "435918", "author": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "body": "[~gfigueras] This is happening because of the way Titanium is dealing with applications' configuration changes after switching orientation. \r\n\r\nI have some concerns that addressing this may introduce major problems. I will be back at it with update/information once I discuss the matter with the team. ", "updateAuthor": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "created": "2018-03-26T13:22:40.000+0000", "updated": "2018-03-26T13:22:40.000+0000" }, { "id": "442731", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "A fix for this is needed to calculate the {{safeAreaPadding}} (see [TIMOB-26427]).\r\nEspecially for Android P notch support (see [TIMOB-26246]).\r\n\r\nThe reason is because Google's AppCompat support library incorrectly hardcodes the *inset* height of the top {{ActionBar}} to what is defined in their XML instead of reading the actual {{ActionBar}} pixel height. This can cause issues with any native Android views which calls the Java [View.setFitsSystemWindows(boolean)|https://developer.android.com/reference/android/view/View.html#setFitsSystemWindows(boolean)] set to {{false}} because such views will be positioned wrong. This can happen with Titanium's DrawerLayouts which use a {{Toolbar}} with \"extendBackground\" set to {{true}}.", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-10-18T01:36:55.000+0000", "updated": "2018-10-18T01:36:55.000+0000" }, { "id": "442737", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR (master): https://github.com/appcelerator/titanium_mobile/pull/10383", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-10-18T03:31:45.000+0000", "updated": "2018-10-18T03:31:45.000+0000" }, { "id": "442943", "author": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "body": "*FR Passed*\r\n\r\nWaiting on Jenkins to merge", "updateAuthor": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "created": "2018-10-25T14:06:04.000+0000", "updated": "2018-10-25T14:06:04.000+0000" }, { "id": "442954", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix on SDK 7.5.0.v20181025085349. Actionbar works as expected. Closing\r\n{code}\r\nOperating System\r\n Name = Mac OS X\r\n Version = 10.13.6\r\n Architecture = 64bit\r\nNode.js\r\n Node.js Version = 8.12.0\r\n npm Version = 6.4.1\r\nTitanium CLI\r\n CLI Version = 5.1.1\r\nStudio\t\t\t =5.1.2.201810080801\r\nTitanium SDK\r\n SDK Version = 7.5.0.v20181025085349\r\nDevice =Samsung s5 Android 6,pixel android 9 \r\nEmulator\t\t\t = Samsung galaxy s6 android 6\r\n{code}", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2018-10-25T17:37:52.000+0000", "updated": "2018-10-25T17:37:52.000+0000" } ], "maxResults": 11, "total": 11, "startAt": 0 } } }