{ "id": "171312", "key": "TIMOB-25865", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20115", "name": "Release 7.3.0", "archived": false, "released": true, "releaseDate": "2018-08-17" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-06-07T02:40:15.000+0000", "created": "2018-03-14T02:43:13.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android", "build", "build-tools" ], "versions": [], "issuelinks": [ { "id": "56383", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "171284", "key": "TIMOB-25852", "fields": { "summary": "Android: Target API Level 26/27 by default", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } }, { "id": "56384", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "inwardIssue": { "id": "171304", "key": "TIMOB-25860", "fields": { "summary": "Update Android Support libraries to 27.1.1", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-06-22T17:56:22.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nIn the Android SDK, if you install build-tools version 27.0.0 or higher and then do an Android build via Titanium, then the following warning message will be logged...\r\n\r\n{code}\r\n[WARN] : Android Build Tools 27.0.3 are too new and may or may not work with Titanium.\r\n[WARN] : If you encounter problems, select a supported version with:\r\n[WARN] : appc ti config android.buildTools.selectedVersion ##.##.##\r\n[WARN] : where ##.##.## is a version in /Users/user/Library/Android/sdk/build-tools that is 26.x\r\n{code}\r\n\r\nAndroid build-tools 27.x.x so far appears to work fine with Titanium builds. So, this warning is harmless for now. But in the future, Google could make breaking changes to their build-tools and we need to protect against this to help future proof our build system.\r\n\r\n*Test:*\r\n# Open Google's \"Android SDK Manager\".\r\n# Make sure the newest 26.x.x build-tools version is installed.\r\n# Make sure the newest 27.x.x build-tools version is installed.\r\n# Do a Titanium Android build.\r\n# Observe the log for the above mentioned warning.\r\n\r\n*Cause:*\r\nTitanium currently only supports build-tools version 26.x.x as defined by our \"package.json\" here...\r\nhttps://github.com/appcelerator/titanium_mobile/blob/master/android/package.json#L25\r\n\r\nBut the CLI ignores this setting and always uses the newest build-tools version available in the Android SDK instead of using the preferred version defined by our \"package.json\". This is because the linked code below will return a {{\"maybe\"}} string instead of {{true}} for a version higher than supported version, but it still evaluates as a positive in the {{if}} condition...\r\nhttps://github.com/appcelerator/node-titanium-sdk/blob/master/lib/android.js#L768\r\n\r\n*Recommended Solution:*\r\nCLI should be changed to favor the build-tools version defined in the \"package.json\". A newer version outside of this range should only be selected if no preferred version is installed, in which case, the build-tools warning is desired.\r\n\r\nWe should not make this change until after updating Titanium's \"package.json\" to support build-tools 27.x.x. This is to avoid a possible breaking change with developers who only have 27.x.x installed. _(Shouldn't cause an issue, but better safe than sorry.)_\r\n", "attachment": [], "flagged": false, "summary": "Android: Build warning appears when Android build-tools v27 or higher is installed", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1034, "state": "closed", "name": "2018 Sprint 10 SDK", "startDate": "2018-05-07T00:03:21.636Z", "endDate": "2018-05-21T00:03:00.000Z", "completeDate": "2018-05-20T20:54:58.928Z", "originBoardId": 114 }, { "id": 1035, "state": "closed", "name": "2018 Sprint 11 SDK", "startDate": "2018-05-20T20:57:43.542Z", "endDate": "2018-06-03T20:57:00.000Z", "completeDate": "2018-06-04T15:13:14.425Z", "originBoardId": 114 }, { "id": 1039, "state": "closed", "name": "2018 Sprint 12 SDK", "startDate": "2018-06-03T15:22:23.401Z", "endDate": "2018-06-17T15:22:00.000Z", "completeDate": "2018-06-18T20:45:36.363Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "437446", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR: https://github.com/appcelerator/node-titanium-sdk/pull/28", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-05-07T23:21:43.000+0000", "updated": "2018-05-07T23:21:43.000+0000" }, { "id": "437570", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.\r\nWaiting for CR & merge to get enabled.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-05-10T21:01:24.000+0000", "updated": "2018-05-10T21:01:24.000+0000" }, { "id": "438133", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~jquick], We will have to make a PR for updating the package.json.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-05T17:51:44.000+0000", "updated": "2018-06-05T23:38:22.000+0000" }, { "id": "438157", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ticket [TIMOB-25867], which has already been merged in, has a regression. We should either revert it or use my proposed fix for [TIMOB-26099] in 7.3.0. We need to decide before updating the \"package.json\".", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-06T00:09:34.000+0000", "updated": "2018-06-06T00:09:34.000+0000" }, { "id": "438643", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix in SDK 7.3.0.v20180618182516.\r\nClosing.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-22T17:56:15.000+0000", "updated": "2018-06-22T17:56:15.000+0000" } ], "maxResults": 6, "total": 6, "startAt": 0 } } }