{ "id": "171351", "key": "TIMOB-25884", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": { "id": "7", "description": "", "name": "Invalid" }, "resolutiondate": "2018-03-19T22:42:22.000+0000", "created": "2018-03-19T21:05:36.000+0000", "priority": { "name": "Low", "id": "4" }, "labels": [ "architecture", "windows" ], "versions": [], "issuelinks": [], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2018-03-19T22:42:22.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "*Summary:*\r\nOn Windows, the {{Ti.Platform.architecture}} property returns an empty string.\r\n[PlatformModule.cpp#L30|https://github.com/appcelerator/titanium_mobile_windows/blob/7b0db6e247c1662c535b2e4bd3f0c141ae95a5a0/Source/TitaniumKit/src/PlatformModule.cpp#L30]\r\n\r\nIt should return the same CPU architecture strings that our APS library uses when collection analytics. Either call the APS library's method or copy and paste the code into the Windows Titanium code.\r\n[Analytics.cs#L174|https://github.com/appcelerator/aps_sdk/blob/195633dd10a37d96ecf52be35c0c712dff5ef331/windows/Analytics.cs#L174]\r\n\r\n*Note:*\r\nIdeally, we should return a more descriptive string when running on an ARM processor. On iOS, we return the following architecture strings:\r\n* arm\r\n* armv6\r\n* armv7\r\n* armv7s\r\n* arm64\r\n* x86_64\r\n* i386\r\n\r\nOdds are the \"arm\" string will never be returned on iOS and will tend to return \"armv7\", \"armv7s\", or \"arm64\".\r\n[APSUtility.m#L24|https://github.com/appcelerator/aps_sdk/blob/195633dd10a37d96ecf52be35c0c712dff5ef331/ios/support/analytics/APSAnalytics/APSUtility.m#L24]\r\n", "attachment": [], "flagged": false, "summary": "Windows: Add \"Ti.Platform.architecture\" support", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "435734", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~jquick] Windows does implement this, see https://github.com/appcelerator/titanium_mobile_windows/blob/7b0db6e247c1662c535b2e4bd3f0c141ae95a5a0/Source/Ti/src/Platform.cpp#L71-L89\r\n\r\nThe Windows architecture is different to the rest, TitaniumKit is intended to be a common cross-platform C++ layer that stubs all APIs and implements those that can be done in a cross platform way. So your link points to the stub, and the link I've provided implements the Windows specific APIs to determine this (I'm sure Kota can explain this 100x better than I can :) )", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2018-03-19T22:25:34.000+0000", "updated": "2018-03-19T22:25:34.000+0000" }, { "id": "435737", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Oh shoot. Well if this is the case, then we can close this ticket out.", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-19T22:41:41.000+0000", "updated": "2018-03-19T22:41:41.000+0000" }, { "id": "435739", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Already implemented.", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-19T22:42:22.000+0000", "updated": "2018-03-19T22:42:22.000+0000" } ], "maxResults": 3, "total": 3, "startAt": 0 } } }