{ "id": "171352", "key": "TIMOB-25885", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": { "id": "7", "description": "", "name": "Invalid" }, "resolutiondate": "2018-03-19T22:42:09.000+0000", "created": "2018-03-19T21:14:39.000+0000", "priority": { "name": "Low", "id": "4" }, "labels": [ "architecture", "windows" ], "versions": [], "issuelinks": [], "assignee": { "name": "kiguchi", "key": "kota", "displayName": "Kota Iguchi", "active": false, "timeZone": "America/Los_Angeles" }, "updated": "2018-03-19T22:42:09.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "12642", "name": "Windows", "description": "Windows authoring support" } ], "description": "*Summary:*\r\nOn Windows, the {{Ti.Platform.ostype}} property returns an empty string.\r\n[PlatformModule.cpp#L100|https://github.com/appcelerator/titanium_mobile_windows/blob/7b0db6e247c1662c535b2e4bd3f0c141ae95a5a0/Source/TitaniumKit/src/PlatformModule.cpp#L100]\r\n\r\nIt should return one of the following to match Android and iOS' behavior:\r\n* \"32bit\"\r\n* \"64bit\"\r\n\r\nIt's okay to make the 32-bit or 64-bit determination based on the app you're running instead of the architecture of the OS. This is how it's done on iOS.\r\n[APSUtility.m#L15|https://github.com/appcelerator/aps_sdk/blob/195633dd10a37d96ecf52be35c0c712dff5ef331/ios/support/analytics/APSAnalytics/APSUtility.m#L15]\r\n\r\n*Note:*\r\nThe APS library provides CPU architecture (ex: \"arm\", \"x86\", etc.) for \"ostype\" when recording analytics. This does not match Android and iOS' behavior. We should not duplicate this issue on the Titanium side.\r\n", "attachment": [], "flagged": false, "summary": "Windows: Add \"Ti.Platform.ostype\" support", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "comment": { "comments": [ { "id": "435733", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Also note that I'm bringing this up because Android is currently/wrongly hard-coded to return \"32bit\" and we have a customer who wants to correctly identify the platform as shown here: [TIMOB-25877]", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-19T21:16:43.000+0000", "updated": "2018-03-19T21:16:43.000+0000" }, { "id": "435735", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "Same as TIMOB-25884, the Windows implementation is here https://github.com/appcelerator/titanium_mobile_windows/blob/7b0db6e247c1662c535b2e4bd3f0c141ae95a5a0/Source/Ti/src/Platform.cpp#L292-L304", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2018-03-19T22:26:11.000+0000", "updated": "2018-03-19T22:26:11.000+0000" }, { "id": "435736", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Oh shoot. Well if this is the case, then we can close this ticket out.", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-19T22:41:29.000+0000", "updated": "2018-03-19T22:41:29.000+0000" }, { "id": "435738", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Already implemented.", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-03-19T22:42:09.000+0000", "updated": "2018-03-19T22:42:09.000+0000" } ], "maxResults": 4, "total": 4, "startAt": 0 } } }