{ "id": "171487", "key": "TIMOB-25950", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20115", "name": "Release 7.3.0", "archived": false, "released": true, "releaseDate": "2018-08-17" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-04-10T11:11:16.000+0000", "created": "2018-04-10T08:03:15.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [ "ios", "ios10", "tabgroup" ], "versions": [ { "id": "19906", "description": "", "name": "Release 6.3.0", "archived": false, "released": true, "releaseDate": "2017-11-01" }, { "id": "19957", "description": "", "name": "Release 7.1.0", "archived": false, "released": true, "releaseDate": "2018-03-14" } ], "issuelinks": [], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2018-06-25T21:49:17.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "The Ti.UI.TabGroup property \"unselectedItemTintColor\" is only available on iOS 10+ and should be guarded.\r\n\r\nPR: https://github.com/appcelerator/titanium_mobile/pull/9991", "attachment": [], "flagged": false, "summary": "iOS: setUnselectedItemTintColor is unrecognized in iOS9", "creator": { "name": "dbankier", "key": "dbankier", "displayName": "David Bankier", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "dbankier", "key": "dbankier", "displayName": "David Bankier", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1021, "state": "closed", "name": "2018 Sprint 08 SDK", "startDate": "2018-04-08T17:57:36.122Z", "endDate": "2018-04-22T17:57:00.000Z", "completeDate": "2018-04-22T22:51:19.120Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "436691", "author": { "name": "mrahman", "key": "mrahman", "displayName": "Mostafizur Rahman", "active": true, "timeZone": "Asia/Dhaka" }, "body": "Hello [~dbankier], \r\n\r\nThanks for sharing with us. Please provide a full sample test code that regenerates the issue. Better to provide a sample app as an attachment here. We will test the issue in our environment. Also, provide the SDK and CLI version you are testing on. ", "updateAuthor": { "name": "mrahman", "key": "mrahman", "displayName": "Mostafizur Rahman", "active": true, "timeZone": "Asia/Dhaka" }, "created": "2018-04-10T08:27:20.000+0000", "updated": "2018-04-10T08:27:20.000+0000" }, { "id": "436696", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Hey there [~dbankier]! The PR looks fine. But I'm having a small issue merging it, because it's an API that is made for iOS 10+ only, so using it on lower SDK versions should error out instead of silently be ignored. From a clean code perspective, it's less hacky to just have one parameter object, but technically, it's incorrect. We can accept your PR, but just this as a side note.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-04-10T09:16:44.000+0000", "updated": "2018-04-10T09:16:44.000+0000" }, { "id": "436697", "author": { "name": "dbankier", "key": "dbankier", "displayName": "David Bankier", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Basically, just an `else` with an error log that it isn't support?", "updateAuthor": { "name": "dbankier", "key": "dbankier", "displayName": "David Bankier", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-04-10T09:20:23.000+0000", "updated": "2018-04-10T09:20:23.000+0000" }, { "id": "436698", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "Yep, thats usually how it's done. Like for the [Autofill Feature|https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/TiUITextWidget.m#L159-L169].", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-04-10T09:23:05.000+0000", "updated": "2018-04-10T09:23:05.000+0000" }, { "id": "436705", "author": { "name": "dbankier", "key": "dbankier", "displayName": "David Bankier", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ok. Rewritten.", "updateAuthor": { "name": "dbankier", "key": "dbankier", "displayName": "David Bankier", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-04-10T10:23:31.000+0000", "updated": "2018-04-10T10:23:31.000+0000" }, { "id": "438686", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "*Closing ticket.* Improvement can be seen in SDK Version: {{7.3.0.v20180618182516}}\r\n\r\n*FR (Passed) Test Steps:*\r\n\r\n# Created an application with the following code:\r\n{code:java}\r\nvar tabGroup = Ti.UI.createTabGroup({\r\n unselectedItemTintColor: \"red\",\r\n tabs: [createTab(\"Tab 1\"), createTab(\"Tab 2\"), createTab(\"Tab 3\"), createTab(\"Tab 4\")]\r\n});\r\n \r\n// Sets the badge after 3 seconds\r\nsetTimeout(function() {\r\n tabGroup.tabs[1].badge = 3;\r\n tabGroup.tabs[1].badgeColor = \"gray\";\r\n},3000);\r\n \r\ntabGroup.open();\r\n \r\nfunction createTab(title) {\r\n return Ti.UI.createTab({\r\n title: title,\r\n icon: \"chat.png\",\r\n window: Ti.UI.createWindow({\r\n title: title\r\n })\r\n })\r\n}\r\n{code}\r\n# Ran the program\r\n# Program launched and console displayed the following message\r\n{code:java}\r\n[ERROR] : The 'unselectedItemTintColor' property is only available on iOS 10 and later.\r\n{code}\r\n\r\n\r\n\r\n*Test Environment*\r\n{code:java}\r\nAPPC Studio: 5.0.0.201712081732\r\nAPPC CLI: 7.0.4\r\niphone 6s (10.2)\r\nOperating System Name: Mac OS High Sierra\r\nOperating System Version: 10.13\r\nNode.js Version: 8.9.1\r\nXcode 9.2\r\n{code}\r\n", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-25T21:42:14.000+0000", "updated": "2018-06-25T21:42:14.000+0000" }, { "id": "438688", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Test Environment missing^\r\n{code:java}\r\niphone 6 (9.3) Emulator \r\n{code}\r\n", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-25T21:49:17.000+0000", "updated": "2018-06-25T21:49:17.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }