{ "id": "171707", "key": "TIMOB-26071", "fields": { "issuetype": { "id": "7", "description": "gh.issue.story.desc", "name": "Story", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-06-07T18:51:31.000+0000", "created": "2018-05-28T07:40:34.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [], "issuelinks": [], "assignee": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "updated": "2018-10-15T15:27:41.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" }, { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "We have [ti.safaridialog|https://github.com/appcelerator-modules/ti.safaridialog] since 5.0.0 to show an embedded web-view natively. Since a while, Android offers the same, so the [ti.webdialog|https://github.com/appcelerator-modules/titanium-web-dialog] was born. \r\n\r\nTo signalize parity and have all latest features, especially with iOS 12 and Android P coming, we should move ti.webdialog to the SDK and deprecate ti.safaridialog.", "attachment": [], "flagged": false, "summary": "Deprecate Ti.SafariDialog, move Ti.WebDialog into the core-modules", "creator": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "comment": { "comments": [ { "id": "437975", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "PR (ti.safaridialog/master): https://github.com/appcelerator-modules/ti.safaridialog/pull/13\r\nPR (titanium_mobile/master): https://github.com/appcelerator/titanium_mobile/pull/10078\r\n\r\nNote: Both Ti.SafariDialog and Ti.TouchID are deprecated. We should remove them from the docs and modules.json in 8.0.0\r\n\r\n[~bimmel] The docs for ti.webdialog need to show up in the web-docs as well, similar like we did with ti.identity last year. Can you add it to your repos that are fetched during docs publish? Also, ti.safaridialog docs need to be updated to reflect the deprecation.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-05-28T08:09:53.000+0000", "updated": "2018-05-28T08:39:52.000+0000" }, { "id": "437983", "author": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "body": "[~hknoechel], is this scheduled with the 8.0.0 release?", "updateAuthor": { "name": "bimmel-defective", "key": "bimmel", "displayName": "(deactived) Brian Immel", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2018-05-29T15:25:00.000+0000", "updated": "2018-05-29T15:25:00.000+0000" }, { "id": "437985", "author": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "body": "I am awaiting feedback from Chris, hopefully yes. I'd do the deprecation asap and remove it in 8.0.0.", "updateAuthor": { "name": "hknoechel", "key": "hansknoechel", "displayName": "Hans Knöchel", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-05-29T15:28:36.000+0000", "updated": "2018-05-29T15:28:59.000+0000" }, { "id": "438044", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "The deprecations should be done ASAP, so I've merged that PR adding the notice.\r\n\r\nI'm not sure we have anything like this, but a forward looking document that we can continuously update regarding upcoming deprecations/removals in the next major release would be very helpful for people to see and anticipate changes like this one.\r\n\r\nFor example, we're adding a deprecation notice to the module README on github, but otherwise I'm not sure how people would be notified that this will be happening.\r\n", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2018-05-31T20:17:49.000+0000", "updated": "2018-05-31T20:17:49.000+0000" }, { "id": "438225", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "I've merged the addition of ti.webdialog into the core modules packaged with SDK on master (7.4.0). ti.safaridialog is still included as well.", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2018-06-07T18:51:25.000+0000", "updated": "2018-06-07T18:51:25.000+0000" }, { "id": "442617", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Closing ticket. ti.webdialog can be seen added into the core modules on Master while still ti.safaridialog.", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-10-15T15:27:08.000+0000", "updated": "2018-10-15T15:27:08.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }