{ "id": "171718", "key": "TIMOB-26081", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-06-12T14:35:13.000+0000", "created": "2018-05-31T09:56:36.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [ { "id": "20102", "name": "Release 7.1.1", "archived": false, "released": true, "releaseDate": "2018-05-02" }, { "id": "20115", "name": "Release 7.3.0", "archived": false, "released": true, "releaseDate": "2018-08-17" }, { "id": "20099", "name": "Release 7.2.0", "archived": false, "released": true, "releaseDate": "2018-06-14" } ], "issuelinks": [], "assignee": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "updated": "2018-10-18T21:26:18.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "13103", "name": "CLI", "description": "Node-based command line interface" } ], "description": "h5.Description\r\n\r\nNode 10 produces a deprecation warning when the {{new Buffer}} constructor is used. See https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/ if you're curious\r\n\r\nIn most cases I believe the most appropriate swap for us to do is turn {{new Buffer}} into {{Buffer.from}}\r\n\r\nIn titanium_mobile there are two instances https://github.com/appcelerator/titanium_mobile/search?l=JavaScript&q=%22new+Buffer%22\r\n, however checking all modules (*lib, node-appc, node-titanium-sdk etc.) would also be good as there deprecation warning will not be shown for code that resides under {{node_modules}} I believe.\r\n\r\nWe might also wish to update eslint-config-axway to include the {{no-buffer-constructor}} rule\r\n\r\nSteps to reproduce to be added as replacement happens", "attachment": [], "flagged": false, "summary": "CLI: Fix new Buffer deprecation warnings in build scripts", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "Ti SDK: 7.1.1.GA, 7.2.0.v20180528150435, 7.3.0.v20180530072516\r\nNode 10.3.0", "closedSprints": [ { "id": 1039, "state": "closed", "name": "2018 Sprint 12 SDK", "startDate": "2018-06-03T15:22:23.401Z", "endDate": "2018-06-17T15:22:00.000Z", "completeDate": "2018-06-18T20:45:36.363Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "438146", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~hknoechel] [~cwilliams] I've assigned you as reviewers, mainly due to the dropping of Node 4 here.\r\n\r\ncc [~emerriman] [~amukherjee], could you review my (lengthy) comment around dropping Node 4 in the PR, as I understand our [deprecation policy|https://docs.appcelerator.com/platform/latest/#!/guide/Axway_Appcelerator_Deprecation_Policy] I believe this is within our policies as Node 4 is now EOL\r\n\r\nPR: https://github.com/appcelerator/titanium_mobile/pull/10090", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2018-06-05T21:54:09.000+0000", "updated": "2018-06-05T21:54:09.000+0000" }, { "id": "442774", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix on SDK 7.5.0.v20181018071438 . don't see ERR_INVALID_CALLBACK error when building with node 10, able to built app successfully and don't see deprecation warnings from new Buffer usage.works fine. Closing.\r\n{code}\r\nOperating System\r\n Name = Mac OS X\r\n Version = 10.13.6\r\n Architecture = 64bit\r\nNode.js\r\n Node.js Version = 10.12.0\r\n npm Version = 6.4.1\r\nTitanium CLI\r\n CLI Version = 5.1.1\r\nTitanium SDK\r\n SDK Version =7.5.0.v20181018071438\r\nDevice =iPhone 6s iOS 12 ,Samsung s5 android 6.\r\n{code}", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2018-10-18T21:26:09.000+0000", "updated": "2018-10-18T21:26:09.000+0000" } ], "maxResults": 2, "total": 2, "startAt": 0 } } }