{ "id": "171748", "key": "TIMOB-26102", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20115", "name": "Release 7.3.0", "archived": false, "released": true, "releaseDate": "2018-08-17" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-06-07T00:51:46.000+0000", "created": "2018-06-06T01:42:36.000+0000", "epic": { "id": 168063, "key": "TIMOB-24764", "name": "Android O: Implement support", "summary": "Android O: Implement support", "color": { "key": "color_8" }, "done": false }, "priority": { "name": "High", "id": "2" }, "labels": [ "android", "notification", "pushnotification" ], "versions": [], "issuelinks": [ { "id": "56581", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "171309", "key": "TIMOB-25864", "fields": { "summary": "Android: Notifications should use default channel on Android 8 if not assigned", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "High", "id": "2" }, "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false } } } } ], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-06-19T17:54:03.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "*Summary:*\r\nOur APS library (which implements Android push notifications) correctly uses Google's {{DEFAULT_CHANNEL_ID}} on Android 8 when targeting API Level 25 or lower.\r\n[APSCloudPush.java#L409|https://github.com/appcelerator/aps_sdk/blob/897b735961c10ce1b6e74f9fd48b48edb4eec83e/android/cloudpush/APSCloudPush/src/main/java/com/appcelerator/aps/APSCloudPush.java#L409]\r\n\r\nHowever, when targeting API Level 26 or higher, you cannot use Google's {{DEFAULT_CHANNEL_ID}} which means notifications will fail to be posted to the status bar. So, the APS library must be changed to create its own default notification channel if one was not supplied from the payload... and it should only do so when targeting API Level 26 or higher.\r\n\r\n*Recommended Solution:*\r\nWe should use a similar solution used by Titanium's local notifications as shown here...\r\nhttps://github.com/appcelerator/titanium_mobile/pull/9945\r\n\r\nIt probably should use a separate notification channel name than what Titanium uses. This may be needed to avoid collision with how Titanium configures its channel.\r\n", "attachment": [], "flagged": false, "summary": "Android: Push notifications should create default channel if not assigned when targeting Android 8", "creator": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1039, "state": "closed", "name": "2018 Sprint 12 SDK", "startDate": "2018-06-03T15:22:23.401Z", "endDate": "2018-06-17T15:22:00.000Z", "completeDate": "2018-06-18T20:45:36.363Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "438176", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "aps_cloudpush: https://github.com/appcelerator/aps_sdk/pull/321\r\ncloudpush: https://github.com/appcelerator-modules/cloudpush/pull/41\r\n\r\nti.cloudpush: https://github.com/appcelerator-modules/cloudpush/releases/tag/android-5.1.2", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-06T18:47:43.000+0000", "updated": "2018-06-06T18:47:43.000+0000" }, { "id": "438180", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.\r\nPR Merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-07T00:51:37.000+0000", "updated": "2018-06-07T00:51:37.000+0000" }, { "id": "438490", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~gmathews], we would need to update the cloud push module version in the SDK so that 5.1.2 cloud push module can be included with the SDK 7.3.0 & master.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-18T21:53:32.000+0000", "updated": "2018-06-18T21:53:32.000+0000" }, { "id": "438493", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "titanium_mobile-7_3_X: https://github.com/appcelerator/titanium_mobile/pull/10119", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-18T22:44:29.000+0000", "updated": "2018-06-18T22:44:29.000+0000" }, { "id": "438526", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Verified with SDK 7.3.0.v20180618182516. \r\nCloudpush 5.1.2 is included with the SDK.\r\n\r\nClosing.\r\n\r\n", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-06-19T16:28:46.000+0000", "updated": "2018-06-19T16:28:46.000+0000" } ], "maxResults": 5, "total": 5, "startAt": 0 } } }