{ "id": "171877", "key": "TIMOB-26180", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2018-07-28T16:24:32.000+0000", "created": "2018-07-03T14:58:08.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [ "ux" ], "versions": [ { "id": "20102", "name": "Release 7.1.1", "archived": false, "released": true, "releaseDate": "2018-05-02" }, { "id": "20099", "name": "Release 7.2.0", "archived": false, "released": true, "releaseDate": "2018-06-14" } ], "issuelinks": [ { "id": "56757", "type": { "id": "10002", "name": "Duplicate", "inward": "is duplicated by", "outward": "duplicates" }, "inwardIssue": { "id": "168115", "key": "TIMOB-24779", "fields": { "summary": "CLI: Error message for too old build-tools is confusing", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "None", "id": "6" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "updated": "2018-09-05T14:57:04.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" }, { "id": "13103", "name": "CLI", "description": "Node-based command line interface" } ], "description": "h5.Description\r\n\r\nIn AC-5789, the {{android.buildTools.selectedVersion}} config setting was set to a version that was not installed, this then led to the CLI outputting a confusing error that the version was unsupported/missing required tools. This error could be improved to push an issue stating that the version set in the config is not installed, which can then be asserted in the build process.\r\n\r\nh5.Steps to reproduce\r\n\r\n# Run {{appc ti config android.buildTools.selectedVersion 22.0.1}}\r\n# Run {{appc ti info}}\r\n\r\nh5.Actual\r\n\r\nEverything looks like that version is installed\r\n\r\nh5.Expected\r\n\r\nIf a selected version is not installed, then we should make it move obvious", "attachment": [], "flagged": false, "summary": "Android: CLI does not provide useful information when a selected buildTools version is not installed", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": "SDK: 7.1.1.GA, 7.2.0.GA", "closedSprints": [ { "id": 1050, "state": "closed", "name": "2018 Sprint 14 SDK", "startDate": "2018-07-01T18:40:57.193Z", "endDate": "2018-07-15T18:40:00.000Z", "completeDate": "2018-07-16T03:27:08.720Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "438983", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~eharris],\r\n\r\nFor your info, 7.3.0 will log the supported versions in parenthesis if a tool is missing or too old. Have a look at step 12 in the link below...\r\nhttps://github.com/appcelerator/node-titanium-sdk/pull/28\r\n\r\nAlthough I'm sure there are other areas that can be improved as well.", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-07-03T18:08:15.000+0000", "updated": "2018-07-03T18:08:15.000+0000" }, { "id": "438987", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "[~jquick] Yeah I'd seen that while tracking down the users issue, it's much more valuable than the output pre-7.3.0 :)\r\n\r\nI'm thinking here to split apart the existing code into 3 sections, and adding two new error codes, to provide more detailed output about what the problem is to the user, and possible solutions (if any)\r\n\r\n- Split the buildTools.supported check from [here|https://github.com/appcelerator/node-titanium-sdk/blob/bb0a93a33fd2999a65950a1fce8955e3b3103c1f/lib/android.js#L465] into a separate check that adds a \"Unsupported version\" (intentionally avoiding too old)\r\n- Edit the missing tools check changing to {{if (missing.length && results.sdk.buildTools.supported)}}, only listing that we're missing tools if we support the build tools\r\n- Rework [this code|https://github.com/appcelerator/node-titanium-sdk/blob/bb0a93a33fd2999a65950a1fce8955e3b3103c1f/lib/android.js#L830-L834] to add a way to determine if a user has told us to use something they've not installed, and then bubble this up through issues as a \"selected version not installed\" error, with some possible solutions (just install it, how to remove the setting etc.), again this would cause the build to error\r\n\r\n\r\nI'm thinking all of these should cause build failures, but 1 & 3 will need the build process updating to do so. \r\n\r\nI'll be sure to assign you as reviewer on this when I make the PR so the above might make more sense :)", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2018-07-03T19:52:19.000+0000", "updated": "2018-07-03T19:52:19.000+0000" }, { "id": "438988", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Sounds good. Looking forward to what you come up with. :)", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-07-03T20:00:33.000+0000", "updated": "2018-07-03T20:00:33.000+0000" }, { "id": "439008", "author": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "body": "node-titanium-sdk: https://github.com/appcelerator/node-titanium-sdk/pull/39\r\ntitanium_mobile: https://github.com/appcelerator/titanium_mobile/pull/10154", "updateAuthor": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "created": "2018-07-04T16:36:03.000+0000", "updated": "2018-07-04T16:36:03.000+0000" }, { "id": "441342", "author": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "body": "*Closing ticket.*\r\n\r\nTested using steps provided in the PR [here|https://github.com/appcelerator/node-titanium-sdk/pull/39]\r\nThe messages are displayed giving more information when build tools are not installed or supported.\r\n\r\nThe fix is present in SDK:\r\n\r\n{noformat}\r\n7.5.0.v20180904155047\r\n{noformat}\r\n\r\n*ENV*\r\n\r\n{noformat}\r\nAppc NPM: 4.2.13\r\nAppc CLI: 7.0.6\r\nTi CLI: 5.1.1\r\nNode: 8.9.4\r\nNPM: 6.3.0\r\n{noformat}\r\n", "updateAuthor": { "name": "jlongton", "key": "jlongton", "displayName": "Josh Longton", "active": true, "timeZone": "Europe/London" }, "created": "2018-09-05T14:56:44.000+0000", "updated": "2018-09-05T14:56:44.000+0000" } ], "maxResults": 5, "total": 5, "startAt": 0 } } }