{ "id": "172077", "key": "TIMOB-26314", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20238", "description": "", "name": "Release 7.5.0", "archived": false, "released": true, "releaseDate": "2018-11-15" } ], "resolution": { "id": "10000", "description": "", "name": "Done" }, "resolutiondate": "2018-10-29T23:17:23.000+0000", "created": "2018-08-16T20:06:30.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "android", "tiapp" ], "versions": [], "issuelinks": [], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2018-10-29T23:17:26.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "Currently the default tiapp.xml doesn't include the versionName or versionCode in the manifest. It will always use versionNumber 1 and versionCode 1 in the AndroidManifest. This will lead to an error when a user uploads an update to the playstore and has to search the documentation or internet to find out where to make these settings.\r\n\r\nAdding the versionNumber to the tiapp.xml will give the user a place to start. And by using the number inside the versionName it will automatically stay in sync with the iOS version. Advanced users can still overwrite the versionName with a custom name like before by adding the parameter to tiapp.xml\r\n\r\nScenario:\r\n* android:versionCode is exposed in the block\r\n* user creates an update and can increase the version code\r\n* AndroidManifest will use the versionCode from the block and the \r\n* if a user wants to have a different version number he can add android:versionName to the tiapp.xml (like he would do it today or already has) and it will overwrite the string inside the AndroidManifest\r\n\r\nExisting apps with a custom android:versionCode and android:versionName would still use those values.\r\nNew apps will use the new android:versionCode from and the normal number as android:versionName", "attachment": [], "flagged": false, "summary": "Android: Add \"versionCode\" to tiapp.xml template", "creator": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "subtasks": [], "reporter": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "environment": null, "closedSprints": [ { "id": 1088, "state": "closed", "name": "2018 Sprint 22", "startDate": "2018-10-21T23:20:52.653Z", "endDate": "2018-11-04T23:20:00.000Z", "completeDate": "2018-11-04T23:29:59.423Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "440839", "author": { "name": "sdarda", "key": "sdarda", "displayName": "Sharif AbuDarda", "active": false, "timeZone": "Asia/Dhaka" }, "body": "Hello, There is no PR attached. Can you attach here? Thanks.", "updateAuthor": { "name": "sdarda", "key": "sdarda", "displayName": "Sharif AbuDarda", "active": false, "timeZone": "Asia/Dhaka" }, "created": "2018-08-16T20:42:31.000+0000", "updated": "2018-08-16T20:42:31.000+0000" }, { "id": "440840", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "Sorry, pasted the wrong link. It is: https://github.com/appcelerator/titanium_mobile/pull/10264", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-08-16T20:49:47.000+0000", "updated": "2018-08-16T20:49:47.000+0000" }, { "id": "440860", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "removed the versionName part since it is already set in _build", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-08-17T21:20:36.000+0000", "updated": "2018-08-17T21:20:36.000+0000" }, { "id": "441463", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed.\r\nWaiting for merge to be enabled.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-09-10T21:49:54.000+0000", "updated": "2018-09-10T21:49:54.000+0000" }, { "id": "442076", "author": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "body": "PR Merged.", "updateAuthor": { "name": "lchoudhary", "key": "lchoudhary", "displayName": "Lokesh Choudhary", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-09-26T17:46:45.000+0000", "updated": "2018-09-26T17:46:45.000+0000" }, { "id": "442310", "author": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "body": "Verified the fix on SDK 7.5.0.v20181004095510. Version code displayed correctly. Closing\r\n{code}\r\nOperating System\r\n Name = Mac OS X\r\n Version = 10.13.6\r\n Architecture = 64bit\r\nNode.js\r\n Node.js Version = 8.9.1\r\n npm Version = 5.5.1\r\nTitanium CLI\r\n CLI Version = 5.1.1\r\nTitanium SDK\r\n SDK Version =7.5.0.v20181004095510\r\nDevice =Samsung s5 android 6, \r\n Pixel 2 XL android 8 emulator.\r\n{code}\r\n", "updateAuthor": { "name": "kmahalingam", "key": "kmahalingam", "displayName": "Keerthi Mahalingam", "active": false, "timeZone": "America/Los_Angeles" }, "created": "2018-10-04T21:00:18.000+0000", "updated": "2018-10-04T21:00:31.000+0000" }, { "id": "442550", "author": { "name": "dieskim", "key": "dieskim", "displayName": "David van de Meer", "active": true, "timeZone": "America/Los_Angeles" }, "updateAuthor": { "name": "dieskim", "key": "dieskim", "displayName": "David van de Meer", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-10-12T02:55:42.000+0000", "updated": "2018-10-12T02:55:42.000+0000" }, { "id": "442552", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "body": "that one was about the GUI in Appcelerator Studio (so you don't even need to edit it by hand). ", "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2018-10-12T08:14:39.000+0000", "updated": "2018-10-12T08:14:39.000+0000" }, { "id": "442553", "author": { "name": "dieskim", "key": "dieskim", "displayName": "David van de Meer", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Ok, yes sorry", "updateAuthor": { "name": "dieskim", "key": "dieskim", "displayName": "David van de Meer", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2018-10-12T08:16:03.000+0000", "updated": "2018-10-12T08:16:03.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }