{ "id": "172758", "key": "TIMOB-26662", "fields": { "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "20033", "name": "Release 9.0.0", "archived": false, "released": true, "releaseDate": "2020-03-18" } ], "resolution": { "id": "1", "description": "A fix for this issue is checked into the tree and tested.", "name": "Fixed" }, "resolutiondate": "2020-02-12T10:37:32.000+0000", "created": "2018-12-17T11:13:52.000+0000", "priority": { "name": "Critical", "id": "1" }, "labels": [ "android", "engSchedule", "tableViewRow" ], "versions": [], "issuelinks": [], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2020-02-12T10:37:32.000+0000", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "Currently on Android TableViewRow:\r\n# always returns zeroes for {{getRect}} method (and rect {{property}})\r\n# does not grow in height beyond original size (but can shrink)\r\n\r\n{code:javascript}\r\nwin = Ti.UI.createWindow({\r\n backgroundColor: '#AAAAFF',\r\n layout: 'vertical'\r\n});\r\n\r\nvar top = Ti.UI.createView({\r\n backgroundColor: '#FFAAAA',\r\n layout: 'horizontal',\r\n height: Ti.UI.SIZE,\r\n width: Ti.UI.FILL\r\n});\r\n\r\nvar btnPlus = Ti.UI.createButton({title: '+'});\r\nbtnPlus.addEventListener('click', function() {\r\n console.log('plus click');\r\n view.height += 50;\r\n});\r\n\r\nvar btnMinus = Ti.UI.createButton({title: '-'});\r\nbtnMinus.addEventListener('click', function() {\r\n console.log('minus click');\r\n view.height -= 50;\r\n});\r\n\r\nvar label = Ti.UI.createLabel();\r\n\r\nvar tableView = Ti.UI.createTableView();\r\n\r\nvar row = Ti.UI.createTableViewRow({\r\n height: Ti.UI.SIZE,\r\n width: Ti.UI.FILL\r\n});\r\n\r\nvar view = Ti.UI.createView({\r\n height: 150,\r\n backgroundColor: 'blue'\r\n});\r\n\r\nrow.add(view);\r\ntableView.setData([ row ]);\r\ntableView.addEventListener('postlayout', function onPostLayout() {\r\n console.log('postlayout', row.rect.height, view.rect.height);\r\n label.text = [row.rect.height, view.rect.height].join(' | ');\r\n});\r\n\r\ntop.add(btnPlus);\r\ntop.add(btnMinus);\r\ntop.add(label);\r\n\r\nwin.add(top);\r\nwin.add(tableView);\r\nwin.open();\r\n{code}\r\n", "attachment": [], "flagged": false, "summary": "Android. TableViewRow bugs", "creator": { "name": "s.volkov", "key": "s.volkov", "displayName": "Sergey Volkov", "active": true, "timeZone": "Europe/Moscow" }, "subtasks": [], "reporter": { "name": "s.volkov", "key": "s.volkov", "displayName": "Sergey Volkov", "active": true, "timeZone": "Europe/Moscow" }, "environment": null, "closedSprints": [ { "id": 1169, "state": "closed", "name": "2019 Sprint 22", "startDate": "2019-10-21T15:38:21.747Z", "endDate": "2019-11-03T15:38:00.000Z", "completeDate": "2019-11-04T18:36:57.022Z", "originBoardId": 114 }, { "id": 1170, "state": "closed", "name": "2019 Sprint 23", "startDate": "2019-11-04T18:38:14.526Z", "endDate": "2019-11-17T18:38:00.000Z", "completeDate": "2019-11-18T16:38:18.423Z", "originBoardId": 114 }, { "id": 1171, "state": "closed", "name": "2019 Sprint 24", "startDate": "2019-11-18T16:40:09.114Z", "endDate": "2019-12-01T16:40:00.000Z", "completeDate": "2019-12-02T23:06:24.654Z", "originBoardId": 114 }, { "id": 1161, "state": "closed", "name": "2019 Sprint 18", "startDate": "2019-08-26T21:46:26.269Z", "endDate": "2019-09-08T21:46:00.000Z", "completeDate": "2019-09-09T20:39:58.761Z", "originBoardId": 114 }, { "id": 1163, "state": "closed", "name": "2019 Sprint 19", "startDate": "2019-09-09T20:43:13.091Z", "endDate": "2019-09-22T20:43:00.000Z", "completeDate": "2019-09-23T15:37:35.874Z", "originBoardId": 114 }, { "id": 1179, "state": "closed", "name": "2020 Sprint 3", "startDate": "2020-02-03T16:58:00.000Z", "endDate": "2020-02-14T16:58:00.000Z", "completeDate": "2020-02-17T09:45:06.128Z", "originBoardId": 114 }, { "id": 1165, "state": "closed", "name": "2019 Sprint 20", "startDate": "2019-09-23T15:38:43.949Z", "endDate": "2019-10-06T15:38:00.000Z", "completeDate": "2019-10-07T18:33:11.953Z", "originBoardId": 114 }, { "id": 1168, "state": "closed", "name": "2019 Sprint 21", "startDate": "2019-10-07T18:35:57.052Z", "endDate": "2019-10-20T18:35:00.000Z", "completeDate": "2019-10-21T15:38:00.182Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "444642", "author": { "name": "s.volkov", "key": "s.volkov", "displayName": "Sergey Volkov", "active": true, "timeZone": "Europe/Moscow" }, "body": "https://github.com/appcelerator/titanium_mobile/pull/10542", "updateAuthor": { "name": "s.volkov", "key": "s.volkov", "displayName": "Sergey Volkov", "active": true, "timeZone": "Europe/Moscow" }, "created": "2018-12-17T11:16:00.000+0000", "updated": "2018-12-17T12:43:04.000+0000" }, { "id": "444657", "author": { "name": "sdarda", "key": "sdarda", "displayName": "Sharif AbuDarda", "active": false, "timeZone": "Asia/Dhaka" }, "body": "Hello, Thanks for the PR. Our engineers will look into it. Moving to TIMOB. ", "updateAuthor": { "name": "sdarda", "key": "sdarda", "displayName": "Sharif AbuDarda", "active": false, "timeZone": "Asia/Dhaka" }, "created": "2018-12-17T21:16:59.000+0000", "updated": "2018-12-17T21:16:59.000+0000" }, { "id": "450939", "author": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "body": "PR: https://github.com/appcelerator/titanium_mobile/pull/11187", "updateAuthor": { "name": "ybanev", "key": "ybanev", "displayName": "Yordan Banev", "active": true, "timeZone": "Europe/Athens" }, "created": "2019-08-29T14:30:10.000+0000", "updated": "2019-08-29T14:30:10.000+0000" }, { "id": "452323", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~s.volkov], while I'm fine with your PR's crash fix and getRect() change, I'm concerned that deleting the following code will bring back the bug mentioned in [TIMOB-16048].\r\n{code:javascript}\r\n// Make sure the height is greater than 1 (not 0 since image views default to 1)\r\nif (hasChildView && h > 1) {\r\n\tcontent.getLayoutParams().height = h;\r\n}\r\n{code}\r\n\r\nI'm guessing that the fix for [TIMOB-16048] should have been made in our {{ImageView}} code instead. Regardless, it'll need to be re-tested and that's the only thing blocking this PR.\r\n(It may be better to split this issue into separate tickets/PRs anyways.)\r\n", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-10-28T23:05:24.000+0000", "updated": "2019-10-28T23:05:24.000+0000" }, { "id": "453205", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "master: https://github.com/appcelerator/titanium_mobile/pull/10542", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2019-12-16T21:30:13.000+0000", "updated": "2019-12-16T21:30:13.000+0000" }, { "id": "454196", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "*Closing ticket*, fix verified in SDK version {{9.0.0.v20200211122336}}.\r\n\r\nTest and other information can be found at: \r\nhttps://github.com/appcelerator/titanium_mobile/pull/10542", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-02-12T10:37:25.000+0000", "updated": "2020-02-12T10:37:25.000+0000" } ], "maxResults": 7, "total": 7, "startAt": 0 } } }