{ "id": "174908", "key": "TIMOB-27847", "fields": { "issuetype": { "id": "4", "description": "An improvement or enhancement to an existing feature or task.", "name": "Improvement", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [ { "id": "21039", "name": "Release 9.0.3", "archived": false, "released": true, "releaseDate": "2020-06-10" } ], "resolution": null, "resolutiondate": null, "created": "2020-04-13T21:56:43.000+0000", "priority": { "name": "Medium", "id": "3" }, "labels": [ "deprecation", "parity" ], "versions": [], "issuelinks": [ { "id": "58314", "type": { "id": "10001", "name": "Cloners", "inward": "is cloned into", "outward": "is cloned from" }, "outwardIssue": { "id": "174880", "key": "TIMOB-27831", "fields": { "summary": "Android: Implement TabGroup.tintColor", "status": { "description": "The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.", "name": "Closed", "id": "6", "statusCategory": { "id": 3, "key": "done", "colorName": "green", "name": "Done" } }, "priority": { "name": "Medium", "id": "3" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } }, { "id": "58799", "type": { "id": "10003", "name": "Relates", "inward": "relates to", "outward": "relates to" }, "outwardIssue": { "id": "175508", "key": "TIMOB-28136", "fields": { "summary": "iOS: tintColor in tabGroup does not work", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "priority": { "name": "Critical", "id": "1" }, "issuetype": { "id": "1", "description": "A problem which impairs or prevents the functions of the product.", "name": "Bug", "subtask": false } } } } ], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2020-10-09T21:31:42.000+0000", "status": { "description": "This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.", "name": "Reopened", "id": "4", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "components": [ { "id": "10206", "name": "iOS", "description": "iOS Platform" } ], "description": "Implement ability to specify a {{tintColor}} or {{activeTintColor}} for tab icons.\r\n\r\nCurrently, iOS has a number of properties that can be used to specify icon color.\r\n\r\n*TabGroup*\r\n- activeTabIconTint\r\n- tabsTintColor\r\n- tintColor\r\n- unselectedItemTintColor\r\n\r\n*Tab*\r\n- tintColor\r\n\r\nThis change will +deprecate+ {{activeTabIconTint}}, {{tabsTintColor}} and {{unselectedItemTintColor}} in favor of {{tintColor}} and {{activeTintColor}} for parity with Android.\r\n\r\n*TEST CASE*\r\n{code:js}\r\nconst tabGroup = Ti.UI.createTabGroup({\r\n\t// style: Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION\r\n});\r\n\r\nconst tabWin_home = Ti.UI.createWindow({\r\n \ttitle: 'Home',\r\n \tbackgroundColor: 'white'\r\n});\r\nconst tab_home = Ti.UI.createTab({\r\n \ticon: 'home.png',\r\n \ttitle: 'Home',\r\n \ttitleColor: 'red',\r\n \tactiveTitleColor: 'blue',\r\n \ttintColor: 'red',\r\n \tactiveTintColor: 'blue',\r\n \twindow: tabWin_home\r\n});\r\n\r\nconst tabWin_chat = Ti.UI.createWindow({\r\n\ttitle: 'Chat',\r\n\tbackgroundColor: 'white'\r\n});\r\nconst tab_chat = Ti.UI.createTab({\r\n\ticon: 'chat.png',\r\n\ttitle: 'Chat',\r\n\ttitleColor: 'red',\r\n\tactiveTitleColor: 'blue',\r\n\ttintColor: 'red',\r\n\tactiveTintColor: 'blue',\r\n\twindow: tabWin_chat\r\n});\r\n\r\ntabGroup.addTab(tab_home);\r\ntabGroup.addTab(tab_chat);\r\ntabGroup.open();\r\n{code}", "attachment": [ { "id": "67514", "filename": "TIMOB-27847.png", "author": { "name": "srai", "key": "srai", "displayName": "Saumya Rai", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-09-01T09:56:54.000+0000", "size": 1022092, "mimeType": "image/png" } ], "flagged": false, "summary": "iOS: Implement Tab tintColor and activeTintColor", "creator": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "subtasks": [], "reporter": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "environment": null, "closedSprints": [ { "id": 1198, "state": "closed", "name": "2020 Sprint 12", "startDate": "2020-06-08T21:06:41.849Z", "endDate": "2020-06-19T21:06:00.000Z", "completeDate": "2020-06-19T15:54:38.493Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "455111", "author": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "body": "master: https://github.com/appcelerator/titanium_mobile/pull/11590", "updateAuthor": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-04-13T23:53:56.000+0000", "updated": "2020-04-13T23:53:56.000+0000" }, { "id": "455669", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "FR Passed for master 9_0_X. Waiting on Jenkins build.", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-06-08T13:11:29.000+0000", "updated": "2020-06-08T13:11:29.000+0000" }, { "id": "455681", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "merged to 9_0_X for 9.0.3 target", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2020-06-08T14:47:30.000+0000", "updated": "2020-06-08T14:47:30.000+0000" }, { "id": "455687", "author": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "body": "manually merged/rebased to master for 9.1.0 target", "updateAuthor": { "name": "cwilliams", "key": "cwilliams", "displayName": "Christopher Williams", "active": true, "timeZone": "America/New_York" }, "created": "2020-06-08T14:55:14.000+0000", "updated": "2020-06-08T14:55:14.000+0000" }, { "id": "455718", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~gmathews] Usinig the following SDK versions {{9.0.3.v20200609060523}} and SDK {{9.1.0.v20200609061322}}. And using the following test case I am unable to see tint colours (Android seems fine).\r\n\r\n{code:java}\r\nconst tabGroup = Ti.UI.createTabGroup({\r\n\t// style: Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION\r\n});\r\n\r\nconst tabWin_home = Ti.UI.createWindow({\r\n \ttitle: 'Home',\r\n \tbackgroundColor: 'white'\r\n});\r\nconst tab_home = Ti.UI.createTab({\r\n \ticon: 'home.png',\r\n \ttitle: 'Home',\r\n \ttitleColor: 'red',\r\n \tactiveTitleColor: 'blue',\r\n \ttintColor: 'red',\r\n \tactiveTintColor: 'blue',\r\n \twindow: tabWin_home\r\n});\r\n\r\nconst tabWin_chat = Ti.UI.createWindow({\r\n\ttitle: 'Chat',\r\n\tbackgroundColor: 'white'\r\n});\r\nconst tab_chat = Ti.UI.createTab({\r\n\ticon: 'chat.png',\r\n\ttitle: 'Chat',\r\n\ttitleColor: 'red',\r\n\tactiveTitleColor: 'blue',\r\n\ttintColor: 'red',\r\n\tactiveTintColor: 'blue',\r\n\twindow: tabWin_chat\r\n});\r\n\r\ntabGroup.addTab(tab_home);\r\ntabGroup.addTab(tab_chat);\r\ntabGroup.open();\r\n{code}\r\n\r\n*Test Environment*\r\n{code:java}\r\nMacOS Catalina: 10.15.5 Beta\r\nXcode: 11.4\r\nJava Version: 1.8.0_131\r\nAndroid NDK: 21.1.6273396-beta2\r\nNode.js: 10.16.3\r\n\"\"NPM\":\"5.0.0\",\"CLI\":\"8.0.0\"\"\r\niphone 8 13.5 Sim\r\n{code}\r\n", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-06-09T14:46:34.000+0000", "updated": "2020-06-09T14:46:34.000+0000" }, { "id": "455722", "author": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Oh [~gmathews] After altering the test case colours I can confirm I actually do in fact see Tab tintColor and activeTintColors being applied using SDK versions 9.0.3.v20200609060523 and SDK 9.1.0.v20200609061322.\r\n\r\nTest and other information can be found at: \r\nmaster: https://github.com/appcelerator/titanium_mobile/pull/11590", "updateAuthor": { "name": "smohammed", "key": "smohammed", "displayName": "Samir Mohammed", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-06-09T15:12:42.000+0000", "updated": "2020-06-09T15:12:42.000+0000" }, { "id": "456676", "author": { "name": "srai", "key": "srai", "displayName": "Saumya Rai", "active": true, "timeZone": "America/Los_Angeles" }, "body": "[~gmathews] tintColor and activeTintColors are not being applied so reopening this ticket.\r\nSDK version: 9.1.0.v20200728082720 and 9.0.3.GA\r\nScreenshot for reference is TIMOB-27847.png\r\n", "updateAuthor": { "name": "srai", "key": "srai", "displayName": "Saumya Rai", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-09-01T09:56:15.000+0000", "updated": "2020-09-01T09:57:20.000+0000" }, { "id": "456748", "author": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "updateAuthor": { "name": "michael", "key": "michael", "displayName": "Michael Gangolf", "active": true, "timeZone": "Europe/Berlin" }, "created": "2020-09-05T19:13:05.000+0000", "updated": "2020-09-05T19:13:05.000+0000" }, { "id": "457229", "author": { "name": "perdona", "key": "perdona", "displayName": "Caio Perdona", "active": true, "timeZone": "America/Los_Angeles" }, "body": "Guys, this is broken in 9.2.0.GA as well. For Android, unselected tabs in dark mode appear black, and android's theme color stopped working as well. Also they're still not applying activeTintColors in runtime. \r\n", "updateAuthor": { "name": "perdona", "key": "perdona", "displayName": "Caio Perdona", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-10-09T21:27:02.000+0000", "updated": "2020-10-09T21:31:42.000+0000" } ], "maxResults": 9, "total": 9, "startAt": 0 } } }