{ "id": "175116", "key": "TIMOB-27947", "fields": { "issuetype": { "id": "7", "description": "gh.issue.story.desc", "name": "Story", "subtask": false }, "project": { "id": "10153", "key": "TIMOB", "name": "Titanium SDK/CLI", "projectCategory": { "id": "10100", "description": "Titanium and related SDKs used in application development", "name": "Client" } }, "fixVersions": [], "resolution": null, "resolutiondate": null, "created": "2020-06-08T17:15:54.000+0000", "priority": { "name": "None", "id": "6" }, "labels": [], "versions": [ { "id": "20972", "description": "", "name": "Release 8.3.1", "archived": false, "released": true, "releaseDate": "2020-01-17" }, { "id": "21018", "name": "Release 9.0.2", "archived": false, "released": true, "releaseDate": "2020-05-19" }, { "id": "20950", "name": "Release 9.1.0", "archived": false, "released": true, "releaseDate": "2020-08-25" } ], "issuelinks": [], "assignee": { "name": "gmathews", "key": "gmathews", "displayName": "Gary Mathews", "active": true, "timeZone": "America/Los_Angeles" }, "updated": "2020-06-09T00:47:14.000+0000", "status": { "description": "The issue is open and ready for the assignee to start work on it.", "name": "Open", "id": "1", "statusCategory": { "id": 2, "key": "new", "colorName": "blue-gray", "name": "To Do" } }, "components": [ { "id": "10202", "name": "Android", "description": "Android Platform" } ], "description": "h5.Description\r\n\r\nIn [TiLocation.java|https://github.com/appcelerator/titanium_mobile/blob/master/android/modules/geolocation/src/java/ti/modules/titanium/geolocation/TiLocation.java#L231-L232] we need to close the InputStream and BufferedReader. Some security scans flag this as an issue\r\n\r\n8_3_X: code reference https://github.com/appcelerator/titanium_mobile/blob/8_3_X/android/modules/geolocation/src/java/ti/modules/titanium/geolocation/TiLocation.java#L232", "attachment": [], "flagged": false, "summary": "Android: Close InputStream and BufferedStream in TiLocation", "creator": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "subtasks": [], "reporter": { "name": "eharris", "key": "eharris", "displayName": "Ewan Harris", "active": true, "timeZone": "Europe/Dublin" }, "environment": null, "closedSprints": [ { "id": 1199, "state": "closed", "name": "2020 Sprint 13", "startDate": "2020-06-19T16:41:04.099Z", "endDate": "2020-07-02T16:41:00.000Z", "completeDate": "2020-07-02T15:37:12.455Z", "originBoardId": 114 } ], "comment": { "comments": [ { "id": "455706", "author": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "body": "I would consider this a false-positive. We call the HTTP \"connection\" object's {{disconnect()}} method in the {{finally}} block. The {{disconnect()}} method will close the input/output streams for us... or put the connection back into the \"pool\" to be re-used for the next HTTP connection to the same end-point.\r\nhttps://developer.android.com/reference/kotlin/java/net/HttpURLConnection\r\n", "updateAuthor": { "name": "jquick", "key": "jquick", "displayName": "Joshua Quick", "active": true, "timeZone": "America/Los_Angeles" }, "created": "2020-06-09T00:47:14.000+0000", "updated": "2020-06-09T00:47:14.000+0000" } ], "maxResults": 1, "total": 1, "startAt": 0 } } }